target/linux/brcm63xx/patches-4.14/404-NET-bcm63xx_enet-move-phy_-dis-connect-into-probe-re.patch

   1 From 7fa63fdde703aaabaa7199ae879219737a98a3f3 Mon Sep 17 00:00:00 2001
   2 From: Jonas Gorski <jonas.gorski@gmail.com>
   3 Date: Fri, 6 Jan 2012 12:24:18 +0100
   4 Subject: [PATCH] NET: bcm63xx_enet: move phy_(dis)connect into probe/remove
   5
   6 Only connect/disconnect the phy during probe and remove, not during any
   7 open/close. The phy seldom changes during the runtime, and disconnecting
   8 the phy during close will prevent it from keeping any configuration over
   9 a down/up cycle.
  10
  11 Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
  12 ---
  13  drivers/net/ethernet/broadcom/bcm63xx_enet.c | 158 +++++++++++++--------------
  14  1 file changed, 78 insertions(+), 80 deletions(-)
  15
  16 --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
  17 +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
  18 @@ -870,10 +870,8 @@ static int bcm_enet_open(struct net_devi
  19         struct bcm_enet_priv *priv;
  20         struct sockaddr addr;
  21         struct device *kdev;
  22 -       struct phy_device *phydev;
  23         int i, ret;
  24         unsigned int size;
  25 -       char phy_id[MII_BUS_ID_SIZE + 3];
  26         void *p;
  27         u32 val;
  28
  29 @@ -881,40 +879,10 @@ static int bcm_enet_open(struct net_devi
  30         kdev = &priv->pdev->dev;
  31
  32         if (priv->has_phy) {
  33 -               /* connect to PHY */
  34 -               snprintf(phy_id, sizeof(phy_id), PHY_ID_FMT,
  35 -                        priv->mii_bus->id, priv->phy_id);
  36 -
  37 -               phydev = phy_connect(dev, phy_id, bcm_enet_adjust_phy_link,
  38 -                                    PHY_INTERFACE_MODE_MII);
  39 -
  40 -               if (IS_ERR(phydev)) {
  41 -                       dev_err(kdev, "could not attach to PHY\n");
  42 -                       return PTR_ERR(phydev);
  43 -               }
  44 -
  45 -               /* mask with MAC supported features */
  46 -               phydev->supported &= (SUPPORTED_10baseT_Half |
  47 -                                     SUPPORTED_10baseT_Full |
  48 -                                     SUPPORTED_100baseT_Half |
  49 -                                     SUPPORTED_100baseT_Full |
  50 -                                     SUPPORTED_Autoneg |
  51 -                                     SUPPORTED_Pause |
  52 -                                     SUPPORTED_MII);
  53 -               phydev->advertising = phydev->supported;
  54 -
  55 -               if (priv->pause_auto && priv->pause_rx && priv->pause_tx)
  56 -                       phydev->advertising |= SUPPORTED_Pause;
  57 -               else
  58 -                       phydev->advertising &= ~SUPPORTED_Pause;
  59 -
  60 -               phy_attached_info(phydev);
  61 -
  62 +               /* Reset state */
  63                 priv->old_link = 0;
  64                 priv->old_duplex = -1;
  65                 priv->old_pause = -1;
  66 -       } else {
  67 -               phydev = NULL;
  68         }
  69
  70         /* mask all interrupts and request them */
  71 @@ -924,7 +892,7 @@ static int bcm_enet_open(struct net_devi
  72
  73         ret = request_irq(dev->irq, bcm_enet_isr_mac, 0, dev->name, dev);
  74         if (ret)
  75 -               goto out_phy_disconnect;
  76 +               return ret;
  77
  78         ret = request_irq(priv->irq_rx, bcm_enet_isr_dma, 0,
  79                           dev->name, dev);
  80 @@ -1086,8 +1054,8 @@ static int bcm_enet_open(struct net_devi
  81         enet_dmac_writel(priv, priv->dma_chan_int_mask,
  82                          ENETDMAC_IRMASK, priv->tx_chan);
  83
  84 -       if (phydev)
  85 -               phy_start(phydev);
  86 +       if (priv->has_phy)
  87 +               phy_start(dev->phydev);
  88         else
  89                 bcm_enet_adjust_link(dev);
  90
  91 @@ -1128,10 +1096,6 @@ out_freeirq_rx:
  92  out_freeirq:
  93         free_irq(dev->irq, dev);
  94
  95 -out_phy_disconnect:
  96 -       if (phydev)
  97 -               phy_disconnect(phydev);
  98 -
  99         return ret;
 100  }
 101
 102 @@ -1236,10 +1200,6 @@ static int bcm_enet_stop(struct net_devi
 103         free_irq(priv->irq_rx, dev);
 104         free_irq(dev->irq, dev);
 105
 106 -       /* release phy */
 107 -       if (priv->has_phy)
 108 -               phy_disconnect(dev->phydev);
 109 -
 110         return 0;
 111  }
 112
 113 @@ -1805,14 +1765,49 @@ static int bcm_enet_probe(struct platfor
 114
 115         /* do minimal hardware init to be able to probe mii bus */
 116         bcm_enet_hw_preinit(priv);
 117 +       spin_lock_init(&priv->rx_lock);
 118 +
 119 +       /* init rx timeout (used for oom) */
 120 +       init_timer(&priv->rx_timeout);
 121 +       priv->rx_timeout.function = bcm_enet_refill_rx_timer;
 122 +       priv->rx_timeout.data = (unsigned long)dev;
 123 +
 124 +       /* init the mib update lock&work */
 125 +       mutex_init(&priv->mib_update_lock);
 126 +       INIT_WORK(&priv->mib_update_task, bcm_enet_update_mib_counters_defer);
 127 +
 128 +       /* zero mib counters */
 129 +       for (i = 0; i < ENET_MIB_REG_COUNT; i++)
 130 +               enet_writel(priv, 0, ENET_MIB_REG(i));
 131 +
 132 +       /* register netdevice */
 133 +       dev->netdev_ops = &bcm_enet_ops;
 134 +       netif_napi_add(dev, &priv->napi, bcm_enet_poll, 16);
 135 +
 136 +       dev->ethtool_ops = &bcm_enet_ethtool_ops;
 137 +       /* MTU range: 46 - 2028 */
 138 +       dev->min_mtu = ETH_ZLEN - ETH_HLEN;
 139 +       dev->max_mtu = BCMENET_MAX_MTU - VLAN_ETH_HLEN;
 140 +       SET_NETDEV_DEV(dev, &pdev->dev);
 141 +
 142 +       ret = register_netdev(dev);
 143 +       if (ret)
 144 +               goto out_uninit_hw;
 145 +
 146 +       netif_carrier_off(dev);
 147 +       platform_set_drvdata(pdev, dev);
 148 +       priv->pdev = pdev;
 149 +       priv->net_dev = dev;
 150
 151         /* MII bus registration */
 152         if (priv->has_phy) {
 153 +               struct phy_device *phydev;
 154 +               char phy_id[MII_BUS_ID_SIZE + 3];
 155
 156                 priv->mii_bus = mdiobus_alloc();
 157                 if (!priv->mii_bus) {
 158                         ret = -ENOMEM;
 159 -                       goto out_uninit_hw;
 160 +                       goto out_unregister_netdev;
 161                 }
 162
 163                 bus = priv->mii_bus;
 164 @@ -1836,6 +1831,35 @@ static int bcm_enet_probe(struct platfor
 165                         dev_err(&pdev->dev, "unable to register mdio bus\n");
 166                         goto out_free_mdio;
 167                 }
 168 +
 169 +               /* connect to PHY */
 170 +               snprintf(phy_id, sizeof(phy_id), PHY_ID_FMT,
 171 +                        priv->mii_bus->id, priv->phy_id);
 172 +
 173 +               phydev = phy_connect(dev, phy_id, bcm_enet_adjust_phy_link,
 174 +                                    PHY_INTERFACE_MODE_MII);
 175 +
 176 +               if (IS_ERR(phydev)) {
 177 +                       dev_err(&pdev->dev, "could not attach to PHY\n");
 178 +                       goto out_unregister_mdio;
 179 +               }
 180 +
 181 +               /* mask with MAC supported features */
 182 +               phydev->supported &= (SUPPORTED_10baseT_Half |
 183 +                                     SUPPORTED_10baseT_Full |
 184 +                                     SUPPORTED_100baseT_Half |
 185 +                                     SUPPORTED_100baseT_Full |
 186 +                                     SUPPORTED_Autoneg |
 187 +                                     SUPPORTED_Pause |
 188 +                                     SUPPORTED_MII);
 189 +               phydev->advertising = phydev->supported;
 190 +
 191 +               if (priv->pause_auto && priv->pause_rx && priv->pause_tx)
 192 +                       phydev->advertising |= SUPPORTED_Pause;
 193 +               else
 194 +                       phydev->advertising &= ~SUPPORTED_Pause;
 195 +
 196 +               phy_attached_info(phydev);
 197         } else {
 198
 199                 /* run platform code to initialize PHY device */
 200 @@ -1843,47 +1867,16 @@ static int bcm_enet_probe(struct platfor
 201                     pd->mii_config(dev, 1, bcm_enet_mdio_read_mii,
 202                                    bcm_enet_mdio_write_mii)) {
 203                         dev_err(&pdev->dev, "unable to configure mdio bus\n");
 204 -                       goto out_uninit_hw;
 205 +                       goto out_unregister_netdev;
 206                 }
 207         }
 208
 209 -       spin_lock_init(&priv->rx_lock);
 210 -
 211 -       /* init rx timeout (used for oom) */
 212 -       init_timer(&priv->rx_timeout);
 213 -       priv->rx_timeout.function = bcm_enet_refill_rx_timer;
 214 -       priv->rx_timeout.data = (unsigned long)dev;
 215 -
 216 -       /* init the mib update lock&work */
 217 -       mutex_init(&priv->mib_update_lock);
 218 -       INIT_WORK(&priv->mib_update_task, bcm_enet_update_mib_counters_defer);
 219 -
 220 -       /* zero mib counters */
 221 -       for (i = 0; i < ENET_MIB_REG_COUNT; i++)
 222 -               enet_writel(priv, 0, ENET_MIB_REG(i));
 223 -
 224 -       /* register netdevice */
 225 -       dev->netdev_ops = &bcm_enet_ops;
 226 -       netif_napi_add(dev, &priv->napi, bcm_enet_poll, 16);
 227 -
 228 -       dev->ethtool_ops = &bcm_enet_ethtool_ops;
 229 -       /* MTU range: 46 - 2028 */
 230 -       dev->min_mtu = ETH_ZLEN - ETH_HLEN;
 231 -       dev->max_mtu = BCMENET_MAX_MTU - VLAN_ETH_HLEN;
 232 -       SET_NETDEV_DEV(dev, &pdev->dev);
 233 -
 234 -       ret = register_netdev(dev);
 235 -       if (ret)
 236 -               goto out_unregister_mdio;
 237 -
 238 -       netif_carrier_off(dev);
 239 -       platform_set_drvdata(pdev, dev);
 240 -       priv->pdev = pdev;
 241 -       priv->net_dev = dev;
 242 -
 243         return 0;
 244
 245  out_unregister_mdio:
 246 +       if (dev->phydev)
 247 +               phy_disconnect(dev->phydev);
 248 +
 249         if (priv->mii_bus)
 250                 mdiobus_unregister(priv->mii_bus);
 251
 252 @@ -1891,6 +1884,9 @@ out_free_mdio:
 253         if (priv->mii_bus)
 254                 mdiobus_free(priv->mii_bus);
 255
 256 +out_unregister_netdev:
 257 +       unregister_netdev(dev);
 258 +
 259  out_uninit_hw:
 260         /* turn off mdc clock */
 261         enet_writel(priv, 0, ENET_MIISC_REG);
 262 @@ -1921,6 +1917,7 @@ static int bcm_enet_remove(struct platfo
 263         enet_writel(priv, 0, ENET_MIISC_REG);
 264
 265         if (priv->has_phy) {
 266 +               phy_disconnect(dev->phydev);
 267                 mdiobus_unregister(priv->mii_bus);
 268                 mdiobus_free(priv->mii_bus);
 269         } else {