target/linux/rb532/patches-2.6.28/015-korina_irqf_flags.patch

   1 As the kernel warning states: "IRQF_DISABLED is not guaranteed on shared
   2 IRQs". Since these IRQs' values are hardcoded and my test system doesn't
   3 show any shared use of IRQs at all, rather make them non-shared than
   4 non-disabled.
   5
   6 Signed-off-by: Phil Sutter <n0-1@freewrt.org>
   7 ---
   8  drivers/net/korina.c |    8 ++++----
   9  1 files changed, 4 insertions(+), 4 deletions(-)
  10
  11 diff --git a/drivers/net/korina.c b/drivers/net/korina.c
  12 index bd33fa9..1d6e48e 100644
  13 --- a/drivers/net/korina.c
  14 +++ b/drivers/net/korina.c
  15 @@ -1000,14 +1000,14 @@ static int korina_open(struct net_device *dev)
  16          * that handles the Done Finished
  17          * Ovr and Und Events */
  18         ret = request_irq(lp->rx_irq, &korina_rx_dma_interrupt,
  19 -               IRQF_SHARED | IRQF_DISABLED, "Korina ethernet Rx", dev);
  20 +                       IRQF_DISABLED, "Korina ethernet Rx", dev);
  21         if (ret < 0) {
  22                 printk(KERN_ERR DRV_NAME "%s: unable to get Rx DMA IRQ %d\n",
  23                     dev->name, lp->rx_irq);
  24                 goto err_release;
  25         }
  26         ret = request_irq(lp->tx_irq, &korina_tx_dma_interrupt,
  27 -               IRQF_SHARED | IRQF_DISABLED, "Korina ethernet Tx", dev);
  28 +                       IRQF_DISABLED, "Korina ethernet Tx", dev);
  29         if (ret < 0) {
  30                 printk(KERN_ERR DRV_NAME "%s: unable to get Tx DMA IRQ %d\n",
  31                     dev->name, lp->tx_irq);
  32 @@ -1016,7 +1016,7 @@ static int korina_open(struct net_device *dev)
  33
  34         /* Install handler for overrun error. */
  35         ret = request_irq(lp->ovr_irq, &korina_ovr_interrupt,
  36 -                       IRQF_SHARED | IRQF_DISABLED, "Ethernet Overflow", dev);
  37 +                       IRQF_DISABLED, "Ethernet Overflow", dev);
  38         if (ret < 0) {
  39                 printk(KERN_ERR DRV_NAME"%s: unable to get OVR IRQ %d\n",
  40                     dev->name, lp->ovr_irq);
  41 @@ -1025,7 +1025,7 @@ static int korina_open(struct net_device *dev)
  42
  43         /* Install handler for underflow error. */
  44         ret = request_irq(lp->und_irq, &korina_und_interrupt,
  45 -                       IRQF_SHARED | IRQF_DISABLED, "Ethernet Underflow", dev);
  46 +                       IRQF_DISABLED, "Ethernet Underflow", dev);
  47         if (ret < 0) {
  48                 printk(KERN_ERR DRV_NAME "%s: unable to get UND IRQ %d\n",
  49                     dev->name, lp->und_irq);
  50 --
  51 1.5.6.4
  52
  53