ppp: quote positional parameters when calling up/down scripts (closes: #5622)

[openwrt/openwrt.git] / package / ppp / files / etc / ppp / ip-down

diff --git a/package/ppp/files/etc/ppp/ip-down b/package/ppp/files/etc/ppp/ip-down
index 334bcb885afdd68e4f4a2ebd58acc2b9277cd6f9..499dc59d6e0d7bf56c5345bd98b59412186aa16d 100755 (executable)
--- a/package/ppp/files/etc/ppp/ip-down
+++ b/package/ppp/files/etc/ppp/ip-down
@@ -1,9 +1,22 @@
 #!/bin/sh
-[ -z "$6" ] || env -i ACTION="ifdown" INTERFACE="$6" PROTO=ppp /sbin/hotplug "iface"
+. /etc/functions.sh
+PPP_IFACE="$1"
+PPP_TTY="$2"
+PPP_SPEED="$3"
+PPP_LOCAL="$4"
+PPP_REMOTE="$5"
+PPP_IPPARAM="$6"
+export PPP_IFACE PPP_TTY PPP_SPEED PPP_LOCAL PPP_REMOTE PPP_IPPARAM
+[ -z "$PPP_IPPARAM" ] || {
+       env -i ACTION="ifdown" INTERFACE="$PPP_IPPARAM" DEVICE="$PPP_IFACE" PROTO=ppp /sbin/hotplug-call "iface"
+
+       # remove the interface's network state
+       uci_revert_state network "$PPP_IPPARAM"
+}
 
 [ -d /etc/ppp/ip-down.d ] && {
        for SCRIPT in /etc/ppp/ip-down.d/*
        do
-               [ -x "$SCRIPT" ] && "$SCRIPT" $@
+               [ -x "$SCRIPT" ] && "$SCRIPT" "$@"
        done
 }