ipq40xx: essedma: Fix dead lock
authorMasafumi UTSUGI <mutsugi@allied-telesis.co.jp>
Tue, 1 Oct 2019 09:59:18 +0000 (18:59 +0900)
committerChristian Lamparter <chunkeey@gmail.com>
Sun, 20 Oct 2019 11:01:43 +0000 (13:01 +0200)
commitf1d761f95e9664a9c11ce1b98f9e121b43c79d35
treec79b16bb72ab9a9e9b28cfe2dfe5021a55114104
parentf5c7fe2ff0deb20f76b4d65195434e35cbb4e08a
ipq40xx: essedma: Fix dead lock

edma_read_append_stats() gets called from two places in the driver.
The first place is the kernel timer that periodically updates
the statistics, so nothing gets lost due to overflows.
The second one it's part of the userspace ethtool ioctl handler
to provide up-to-date values.

For this configuration, the use of spin_lock() is not sufficient
and as per:
<https://mirrors.edge.kernel.org/pub/linux/kernel/people/rusty/kernel-locking/c214.html>
the locking has to be upgraded to spin_lock_bh().

Signed-off-by: Masafumi UTSUGI <mutsugi@allied-telesis.co.jp>
[folded patch into 710-, rewrote message]
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
target/linux/ipq40xx/patches-4.14/710-net-add-qualcomm-essedma-ethernet-driver.patch
target/linux/ipq40xx/patches-4.19/710-net-add-qualcomm-essedma-ethernet-driver.patch