tfa-layerscape: build fiptool again
authorAdrian Schmutzler <freifunk@adrianschmutzler.de>
Sat, 20 Feb 2021 18:18:12 +0000 (19:18 +0100)
committerAdrian Schmutzler <freifunk@adrianschmutzler.de>
Sun, 21 Feb 2021 12:55:30 +0000 (13:55 +0100)
The ls-ddr-phy package needs fiptool options that are not
available via the version from arm-trusted-firmware-tools.
This breaks build for layerscape with the recently added LX2160a:

  create: unrecognized option '--ddr-immem-udimm-1d'

Use the tfa-layerscape variant again for now, but rename it to
fiptool-layerscape to indicate that it's a specific variant.

This reverts 84bc7d31e0a8 ("tfa-layerscape: don't build fiptool").

Fixes: f59d7aab2a37 ("layerscape: add ddr-phy package")

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
(cherry picked from commit 910b5d669f907656c6af14242db2482be6a79323)

package/boot/tfa-layerscape/Makefile
package/firmware/layerscape/ls-ddr-phy/Makefile

index d5a1664..6285da6 100644 (file)
@@ -15,19 +15,24 @@ PKG_SOURCE_PROTO:=git
 PKG_SOURCE_URL:=https://source.codeaurora.org/external/qoriq/qoriq-components/atf
 PKG_SOURCE_VERSION:=7d748e6f0ec652ba7c43733dc67a3d0b0217390a
 PKG_MIRROR_HASH:=d209c9ad18aac9f18375450b98b8dab00f0382ccb485df14623bf9b72ea1dd9b
-PKG_BUILD_DEPENDS:=arm-trusted-firmware-tools/host tfa-layerscape/host
+PKG_BUILD_DEPENDS:=tfa-layerscape/host
 
 include $(INCLUDE_DIR)/host-build.mk
 include $(INCLUDE_DIR)/package.mk
 
 HOST_CFLAGS += -Wall -Werror -pedantic -std=c99
 define Host/Compile
+       $(MAKE) -C \
+               $(HOST_BUILD_DIR)/tools/fiptool \
+               CFLAGS="$(HOST_CFLAGS)" \
+               LDFLAGS="$(HOST_LDFLAGS)"
        $(MAKE) -C \
                $(HOST_BUILD_DIR)/plat/nxp/tools \
                CFLAGS="$(HOST_CFLAGS)"
 endef
 
 define Host/Install
+       $(INSTALL_BIN) $(HOST_BUILD_DIR)/tools/fiptool/fiptool $(STAGING_DIR_HOST)/bin/fiptool-layerscape
        $(INSTALL_BIN) $(HOST_BUILD_DIR)/plat/nxp/tools/create_pbl $(STAGING_DIR_HOST)/bin/tfa-create-pbl
        $(INSTALL_BIN) $(HOST_BUILD_DIR)/plat/nxp/tools/byte_swap $(STAGING_DIR_HOST)/bin/tfa-byte-swap
 endef
@@ -151,7 +156,7 @@ define Build/Compile
                fip pbl PLAT=$(PLAT) BOOT_MODE=$(BOOT_MODE) \
                RCW=$(STAGING_DIR_IMAGE)/fsl_$(BUILD_VARIANT)-rcw.bin \
                BL33=$(STAGING_DIR_IMAGE)/fsl_$(BUILD_VARIANT)-uboot.bin \
-               FIPTOOL=$(STAGING_DIR_HOST)/bin/fiptool \
+               FIPTOOL=$(STAGING_DIR_HOST)/bin/fiptool-layerscape \
                CREATE_PBL=$(STAGING_DIR_HOST)/bin/tfa-create-pbl \
                BYTE_SWAP=$(STAGING_DIR_HOST)/bin/tfa-byte-swap
 endef
index ea2ec31..bd86196 100644 (file)
@@ -29,7 +29,7 @@ endef
 
 define Build/Compile
        cd $(PKG_BUILD_DIR)/lx2160a/ && \
-       tfa-fiptool create \
+       fiptool-layerscape create \
                --ddr-immem-udimm-1d ddr4_pmu_train_imem.bin \
                --ddr-immem-udimm-2d ddr4_2d_pmu_train_imem.bin \
                --ddr-dmmem-udimm-1d ddr4_pmu_train_dmem.bin \