gpio-button-hotplug: gpio-keys: fix always missing first event
authorPetr Štetiar <ynezz@true.cz>
Tue, 4 Jun 2019 11:14:41 +0000 (13:14 +0200)
committerPetr Štetiar <ynezz@true.cz>
Sun, 9 Jun 2019 12:51:47 +0000 (14:51 +0200)
Commit afc056d7dc83 ("gpio-button-hotplug: support interrupt
properties") changed the gpio-keys interrupt handling logic in a way,
that it always misses first event, which causes issues with rc.button
scripts, so this patch restores the previous behaviour.

Fixes: afc056d7dc83 ("gpio-button-hotplug: support interrupt properties")
Reported-by: Kristian Evensen <kristian.evensen@gmail.com>
Tested-by: Kuan-Yi Li <kyli.tw@gmail.com>
Signed-off-by: Petr Štetiar <ynezz@true.cz>
Signed-off-by: Christian Lamparter <chunkeey@gmail.com> [drop state check]
package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c

index f429f8c..daa4b2a 100644 (file)
@@ -340,16 +340,9 @@ static void gpio_keys_irq_work_func(struct work_struct *work)
 {
        struct gpio_keys_button_data *bdata = container_of(work,
                struct gpio_keys_button_data, work.work);
-       int state = gpio_button_get_value(bdata);
 
-       if (state != bdata->last_state) {
-               unsigned int type = bdata->b->type ?: EV_KEY;
-
-               if (bdata->last_state != -1 || type == EV_SW)
-                       button_hotplug_event(bdata, type, state);
-
-               bdata->last_state = state;
-       }
+       button_hotplug_event(bdata, bdata->b->type ?: EV_KEY,
+                            gpio_button_get_value(bdata));
 }
 
 static irqreturn_t button_handle_irq(int irq, void *_bdata)