ipq40xx: Use constant to set gpio active low/high
authorSven Eckelmann <sven.eckelmann@openmesh.com>
Mon, 19 Mar 2018 13:52:38 +0000 (14:52 +0100)
committerMathias Kresin <dev@kresin.me>
Fri, 23 Mar 2018 19:31:49 +0000 (20:31 +0100)
The GPIO configuration in the DTS have as third parameter the active
low/high configuration. This parameter is not easy to parse by humans when
it is only set to 0/1. It is better to use the predefined constants
GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW.

Signed-off-by: Sven Eckelmann <sven.eckelmann@openmesh.com>
target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-a42.dts
target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-rt-ac58u.dts
target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi
target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-fritz4040.dts
target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4028-wpj428.dts
target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-gl-b1300.dts
target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-mr33.dts

index 1ccd9f9..222d39b 100644 (file)
        pinctrl-0 = <&spi_0_pins>;
        pinctrl-names = "default";
        status = "okay";
-       cs-gpios = <&tlmm 54 0>;
+       cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
 
        m25p80@0 {
                #address-cells = <1>;
index 2b40b9e..446da04 100644 (file)
        pinctrl-0 = <&spi_0_pins>;
        pinctrl-names = "default";
        status = "okay";
-       cs-gpios = <&tlmm 54 0>,
-                  <&tlmm 59 0>;
+       cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>,
+                  <&tlmm 59 GPIO_ACTIVE_HIGH>;
 
        m25p80@0 {
                #address-cells = <1>;
index 753adf9..eeadc07 100644 (file)
@@ -15,6 +15,7 @@
  */
 
 #include "qcom-ipq4019.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
        model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK04.1";
                        pinctrl-0 = <&spi_0_pins>;
                        pinctrl-names = "default";
                        status = "okay";
-                       cs-gpios = <&tlmm 12 0>;
+                       cs-gpios = <&tlmm 12 GPIO_ACTIVE_HIGH>;
 
                        mx25l25635e@0 {
                                #address-cells = <1>;
index 65e802b..4b5cbca 100644 (file)
        pinctrl-0 = <&spi_0_pins>;
        pinctrl-names = "default";
        status = "okay";
-       cs-gpios = <&tlmm 54 0>;
+       cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
 
        mx25l25635f@0 {
                compatible = "jedec,spi-nor";
index 746b289..f9f0f96 100644 (file)
        pinctrl-0 = <&spi_0_pins>;
        pinctrl-names = "default";
        status = "okay";
-       cs-gpios = <&tlmm 54 0>;
+       cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
 
        m25p80@0 {
                #address-cells = <1>;
index f3db47f..c4b002b 100644 (file)
        pinctrl-0 = <&spi_0_pins>;
        pinctrl-names = "default";
        status = "okay";
-       cs-gpios = <&tlmm 54 0>;
+       cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
 
        mx25l25635f@0 {
                compatible = "jedec,spi-nor";
index 9c1ef4f..ef62301 100644 (file)
@@ -60,7 +60,7 @@
                        status = "okay";
                        pinctrl-0 = <&mdio_pins>;
                        pinctrl-names = "default";
-                       phy-reset-gpio = <&tlmm 47 0>;
+                       phy-reset-gpio = <&tlmm 47 GPIO_ACTIVE_HIGH>;
                        /delete-node/ ethernet-phy@0;
                        /delete-node/ ethernet-phy@2;
                        /delete-node/ ethernet-phy@3;