apm821xx: fix dtc compiler warnings for MX60(W) and MR24's dts files
authorChristian Lamparter <chunkeey@gmail.com>
Fri, 21 Sep 2018 22:38:39 +0000 (00:38 +0200)
committerHauke Mehrtens <hauke@hauke-m.de>
Sat, 29 Sep 2018 15:23:11 +0000 (17:23 +0200)
This patch fixes some of the dtc warnings:

MR24:
"reg" property in [...]mdio/phy@1 has invalid length (4 bytes)
Node [...]button@1 has a unit name, but no reg property
Relying on default #address-cells value for [...]phy@1
Relying on default #size-cells value for [...]phy@1

MX60(W):
Node [..]nand/all has a reg or ranges property, but no unit name
Node [..]button@1 has a unit name, but no reg property

Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
target/linux/apm821xx/dts/meraki-mr24.dts
target/linux/apm821xx/dts/meraki-mx60.dts

index 63cb88b..fc879fe 100644 (file)
@@ -95,6 +95,9 @@
        phy-handle = <&phy>;
 
        mdio {
+               #address-cells = <1>;
+               #size-cells = <0>;
+
                phy: phy@1 {
                        compatible = "ethernet-phy-ieee802.3-c22";
                        reg = <1>;
                poll-interval = <60>;   /* 3 * 20 = 60ms */
                autorepeat;
 
-               button@1 {
-                       label = "Reset button";
+               reset {
+                       /* Label as per Meraki's "MR24 Installation Guide" */
+                       label = "Factory Reset Button";
                        linux,code = <KEY_RESTART>;
                        gpios = <&GPIO0 16 GPIO_ACTIVE_LOW>;
                };
index 881d933..80b82e4 100644 (file)
                                label = "ubi";
                                reg = <0x00240000 0x3fdc0000>;
                        };
-
-                       all {
-                               label = "all";
-                               reg = <0x00000000 0x40000000>;
-                       };
                };
        };
 };
                poll-interval = <60>;   /* 3 * 20 = 60ms */
                autorepeat;
 
-               button@1 {
+               reset {
                        label = "Reset button";
                        linux,code = <KEY_RESTART>;
                        gpios = <&GPIO0 16 GPIO_ACTIVE_LOW>;