dnsmasq: reset EXTRA_MOUNT in the right place
authorDaniel Golle <daniel@makrotopia.org>
Sun, 1 Aug 2021 14:05:18 +0000 (15:05 +0100)
committerDaniel Golle <daniel@makrotopia.org>
Sun, 1 Aug 2021 14:06:57 +0000 (15:06 +0100)
EXTRA_MOUNT variable should be reset in dnsmasq_start() rather than
just once at the beginning of the script.

Fixes: ac4e8aa2f8 ("dnsmasq: fix more dnsmasq jail issues")
Reported-by: Hartmut Birr <e9hack@gmail.com>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
package/network/services/dnsmasq/files/dnsmasq.init

index fe2edcbb56d706ab597a9fc117fddef36e9dddf4..205bfb4cf6c5bec307a90888095df8254bfc4a7f 100644 (file)
@@ -10,7 +10,6 @@ ADD_LOCAL_DOMAIN=1
 ADD_LOCAL_HOSTNAME=1
 ADD_WAN_FQDN=0
 ADD_LOCAL_FQDN=""
-EXTRA_MOUNT=""
 
 BASECONFIGFILE="/var/etc/dnsmasq.conf"
 BASEHOSTFILE="/tmp/hosts/dhcp"
@@ -818,9 +817,10 @@ dnsmasq_start()
        config_get_bool disabled "$cfg" disabled 0
        [ "$disabled" -gt 0 ] && return 0
 
-       # reset list of DOMAINS and DNS servers (for each dnsmasq instance)
+       # reset list of DOMAINS, DNS servers and EXTRA mounts (for each dnsmasq instance)
        DNS_SERVERS=""
        DOMAIN=""
+       EXTRA_MOUNT=""
        CONFIGFILE="${BASECONFIGFILE}.${cfg}"
        CONFIGFILE_TMP="${CONFIGFILE}.$$"
        HOSTFILE="${BASEHOSTFILE}.${cfg}"