dnsmasq: correct sense & usage of dnsseccheckunsigned
authorKevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
Fri, 22 Nov 2019 14:04:02 +0000 (14:04 +0000)
committerKevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
Sat, 23 Nov 2019 08:29:15 +0000 (08:29 +0000)
dnsmasq v2.80 made 'dnssec-check-unsigned' the default, thus the uci
option was rendered ineffectual: we checked unsigned zones no matter the
setting.

Disabling the checking of unsigned zones is now achieve with the
"--dnssec-check-unsigned=no" dnsmasq option.

Update init script to pass required option in the disabled case.

Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
package/network/services/dnsmasq/Makefile
package/network/services/dnsmasq/files/dnsmasq.init

index a1b5189..c57a837 100644 (file)
@@ -10,7 +10,7 @@ include $(TOPDIR)/rules.mk
 PKG_NAME:=dnsmasq
 PKG_UPSTREAM_VERSION:=2.80
 PKG_VERSION:=$(subst test,~~test,$(subst rc,~rc,$(PKG_UPSTREAM_VERSION)))
-PKG_RELEASE:=14
+PKG_RELEASE:=15
 
 PKG_SOURCE:=$(PKG_NAME)-$(PKG_UPSTREAM_VERSION).tar.xz
 PKG_SOURCE_URL:=http://thekelleys.org.uk/dnsmasq
index 1054f7a..94a069f 100644 (file)
@@ -966,7 +966,8 @@ dnsmasq_start()
                                [ -f "$TIMEVALIDFILE" ] || xappend "--dnssec-no-timecheck"
                        }
                }
-               append_bool "$cfg" dnsseccheckunsigned "--dnssec-check-unsigned"
+               config_get_bool dnsseccheckunsigned "$cfg" dnsseccheckunsigned 1
+               [ "$dnsseccheckunsigned" -eq 0 ] && xappend "--dnssec-check-unsigned=no"
        }
 
        config_get addmac "$cfg" addmac 0