Get rid of the b44 'BUG! Timeout waiting for bit 80000000 of register 428 to clear...
authorFelix Fietkau <nbd@openwrt.org>
Sat, 10 Jul 2010 00:48:37 +0000 (00:48 +0000)
committerFelix Fietkau <nbd@openwrt.org>
Sat, 10 Jul 2010 00:48:37 +0000 (00:48 +0000)
more and more users are getting confused by this, and consider it a regression in brcm47xx,
because brcm-2.4 was not showing this message. It's not particularly interesting for debugging,
most of the time it only happens because of an unconnected port.

SVN-Revision: 22110

target/linux/brcm47xx/patches-2.6.32/211-b44_timeout_spam.patch [new file with mode: 0644]
target/linux/brcm47xx/patches-2.6.32/813-use_netdev_alloc_skb.patch
target/linux/brcm47xx/patches-2.6.33/211-b44_timeout_spam.patch [new file with mode: 0644]
target/linux/brcm47xx/patches-2.6.33/813-use_netdev_alloc_skb.patch
target/linux/brcm47xx/patches-2.6.34/211-b44_timeout_spam.patch [new file with mode: 0644]
target/linux/brcm47xx/patches-2.6.35/211-b44_timeout_spam.patch [new file with mode: 0644]

diff --git a/target/linux/brcm47xx/patches-2.6.32/211-b44_timeout_spam.patch b/target/linux/brcm47xx/patches-2.6.32/211-b44_timeout_spam.patch
new file mode 100644 (file)
index 0000000..dbd46ae
--- /dev/null
@@ -0,0 +1,17 @@
+--- a/drivers/net/b44.c
++++ b/drivers/net/b44.c
+@@ -189,11 +189,13 @@ static int b44_wait_bit(struct b44 *bp, 
+               udelay(10);
+       }
+       if (i == timeout) {
+-              printk(KERN_ERR PFX "%s: BUG!  Timeout waiting for bit %08x of register "
++#if 0
++              printk(KERN_DEBUG PFX "%s: BUG!  Timeout waiting for bit %08x of register "
+                      "%lx to %s.\n",
+                      bp->dev->name,
+                      bit, reg,
+                      (clear ? "clear" : "set"));
++#endif
+               return -ENODEV;
+       }
+       return 0;
index a9b2db5..2cfa824 100644 (file)
@@ -1,6 +1,6 @@
 --- a/drivers/net/b44.c
 +++ b/drivers/net/b44.c
-@@ -848,7 +848,7 @@ static int b44_rx(struct b44 *bp, int bu
+@@ -850,7 +850,7 @@ static int b44_rx(struct b44 *bp, int bu
                        struct sk_buff *copy_skb;
  
                        b44_recycle_rx(bp, cons, bp->rx_prod);
diff --git a/target/linux/brcm47xx/patches-2.6.33/211-b44_timeout_spam.patch b/target/linux/brcm47xx/patches-2.6.33/211-b44_timeout_spam.patch
new file mode 100644 (file)
index 0000000..dbd46ae
--- /dev/null
@@ -0,0 +1,17 @@
+--- a/drivers/net/b44.c
++++ b/drivers/net/b44.c
+@@ -189,11 +189,13 @@ static int b44_wait_bit(struct b44 *bp, 
+               udelay(10);
+       }
+       if (i == timeout) {
+-              printk(KERN_ERR PFX "%s: BUG!  Timeout waiting for bit %08x of register "
++#if 0
++              printk(KERN_DEBUG PFX "%s: BUG!  Timeout waiting for bit %08x of register "
+                      "%lx to %s.\n",
+                      bp->dev->name,
+                      bit, reg,
+                      (clear ? "clear" : "set"));
++#endif
+               return -ENODEV;
+       }
+       return 0;
index a9b2db5..2cfa824 100644 (file)
@@ -1,6 +1,6 @@
 --- a/drivers/net/b44.c
 +++ b/drivers/net/b44.c
-@@ -848,7 +848,7 @@ static int b44_rx(struct b44 *bp, int bu
+@@ -850,7 +850,7 @@ static int b44_rx(struct b44 *bp, int bu
                        struct sk_buff *copy_skb;
  
                        b44_recycle_rx(bp, cons, bp->rx_prod);
diff --git a/target/linux/brcm47xx/patches-2.6.34/211-b44_timeout_spam.patch b/target/linux/brcm47xx/patches-2.6.34/211-b44_timeout_spam.patch
new file mode 100644 (file)
index 0000000..d5ade16
--- /dev/null
@@ -0,0 +1,16 @@
+--- a/drivers/net/b44.c
++++ b/drivers/net/b44.c
+@@ -190,11 +190,12 @@ static int b44_wait_bit(struct b44 *bp, 
+                       break;
+               udelay(10);
+       }
++#if 0
+       if (i == timeout) {
+               if (net_ratelimit())
+                       netdev_err(bp->dev, "BUG!  Timeout waiting for bit %08x of register %lx to %s\n",
+                                  bit, reg, clear ? "clear" : "set");
+-
++#endif
+               return -ENODEV;
+       }
+       return 0;
diff --git a/target/linux/brcm47xx/patches-2.6.35/211-b44_timeout_spam.patch b/target/linux/brcm47xx/patches-2.6.35/211-b44_timeout_spam.patch
new file mode 100644 (file)
index 0000000..d5ade16
--- /dev/null
@@ -0,0 +1,16 @@
+--- a/drivers/net/b44.c
++++ b/drivers/net/b44.c
+@@ -190,11 +190,12 @@ static int b44_wait_bit(struct b44 *bp, 
+                       break;
+               udelay(10);
+       }
++#if 0
+       if (i == timeout) {
+               if (net_ratelimit())
+                       netdev_err(bp->dev, "BUG!  Timeout waiting for bit %08x of register %lx to %s\n",
+                                  bit, reg, clear ? "clear" : "set");
+-
++#endif
+               return -ENODEV;
+       }
+       return 0;