openwrt/openwrt.git
16 years agoseparate series file fixup from quilt check to avoid series file breakages after...
Felix Fietkau [Thu, 4 Oct 2007 15:32:55 +0000 (15:32 +0000)]
separate series file fixup from quilt check to avoid series file breakages after fixing a broken patch stack with quilt

SVN-Revision: 9120

16 years agoFix sangam DSL build with 2.6.23 kernel
Matteo Croce [Thu, 4 Oct 2007 14:31:45 +0000 (14:31 +0000)]
Fix sangam DSL build with 2.6.23 kernel

SVN-Revision: 9119

16 years agoNAND driver cleanups, thanks to Alexandros C. Couloumbis for testing * use generic...
Gabor Juhos [Thu, 4 Oct 2007 10:56:38 +0000 (10:56 +0000)]
NAND driver cleanups, thanks to Alexandros C. Couloumbis for testing * use generic NAND driver from now * add experimental support for RouterBOARD 150 NAND device

SVN-Revision: 9118

16 years agoadd ar7 2.6.23 patches and config
Eugene Konev [Thu, 4 Oct 2007 02:27:37 +0000 (02:27 +0000)]
add ar7 2.6.23 patches and config

SVN-Revision: 9115

16 years agoadd generic 2.6.23 patches and config
Eugene Konev [Thu, 4 Oct 2007 02:26:27 +0000 (02:26 +0000)]
add generic 2.6.23 patches and config

SVN-Revision: 9114

16 years agofix target profiles, (closes: 2440)
Gabor Juhos [Wed, 3 Oct 2007 19:22:51 +0000 (19:22 +0000)]
fix target profiles, (closes: 2440)

SVN-Revision: 9113

16 years agoupgrade acx and acx-mac80211, removed two patches now unneeded
Matteo Croce [Wed, 3 Oct 2007 17:30:27 +0000 (17:30 +0000)]
upgrade acx and acx-mac80211, removed two patches now unneeded

SVN-Revision: 9112

16 years agofix busybox configuration submenu
Nicolas Thill [Wed, 3 Oct 2007 06:07:28 +0000 (06:07 +0000)]
fix busybox configuration submenu

SVN-Revision: 9103

16 years agomove the "BUILD_SUFFIX" options out of "SOURCE_FEEDS" options
Nicolas Thill [Wed, 3 Oct 2007 06:01:30 +0000 (06:01 +0000)]
move the "BUILD_SUFFIX" options out of "SOURCE_FEEDS" options

SVN-Revision: 9102

16 years agofix quilt integration
Tim Yardley [Tue, 2 Oct 2007 21:54:22 +0000 (21:54 +0000)]
fix quilt integration

SVN-Revision: 9100

16 years agofix target profiles
Felix Fietkau [Tue, 2 Oct 2007 17:43:57 +0000 (17:43 +0000)]
fix target profiles

SVN-Revision: 9099

16 years agomore cpmac cleanups (#2452): * don't use net_device::mem* * use net_device::stats...
Eugene Konev [Tue, 2 Oct 2007 14:53:05 +0000 (14:53 +0000)]
more cpmac cleanups (#2452): * don't use net_device::mem* * use net_device::stats * use per-device rx ring size configurable through ethtool * use more ethernet generics (get_stats, set_mac_address, change_mtu)

SVN-Revision: 9098

16 years agoUse PCI for rdc
Florian Fainelli [Tue, 2 Oct 2007 14:24:51 +0000 (14:24 +0000)]
Use PCI for rdc

SVN-Revision: 9097

16 years agoRDC vendor id is unknown
Florian Fainelli [Tue, 2 Oct 2007 14:24:17 +0000 (14:24 +0000)]
RDC vendor id is unknown

SVN-Revision: 9096

16 years agoBuild all firmware until we put back profiles
Florian Fainelli [Tue, 2 Oct 2007 14:23:43 +0000 (14:23 +0000)]
Build all firmware until we put back profiles

SVN-Revision: 9095

16 years agoRewrite platform code to be smarter
Florian Fainelli [Tue, 2 Oct 2007 14:23:27 +0000 (14:23 +0000)]
Rewrite platform code to be smarter

SVN-Revision: 9094

16 years agoAdd support for the network packet generator
Florian Fainelli [Tue, 2 Oct 2007 11:10:29 +0000 (11:10 +0000)]
Add support for the network packet generator

SVN-Revision: 9091

16 years agomake image names shorten
Gabor Juhos [Tue, 2 Oct 2007 09:09:55 +0000 (09:09 +0000)]
make image names shorten

SVN-Revision: 9089

16 years agofix gdb installation
Felix Fietkau [Mon, 1 Oct 2007 14:55:38 +0000 (14:55 +0000)]
fix gdb installation

SVN-Revision: 9088

16 years agoadd usb controller definition
Eugene Konev [Mon, 1 Oct 2007 12:35:35 +0000 (12:35 +0000)]
add usb controller definition

SVN-Revision: 9087

16 years agorevert to vlynq bus clock divisor guessing
Nicolas Thill [Mon, 1 Oct 2007 10:16:14 +0000 (10:16 +0000)]
revert to vlynq bus clock divisor guessing

SVN-Revision: 9086

16 years agoprepare trxsplit to support sysupgrade
Gabor Juhos [Mon, 1 Oct 2007 09:51:32 +0000 (09:51 +0000)]
prepare trxsplit to support sysupgrade

SVN-Revision: 9085

16 years agosplit eeprom_93cx6 patch to make quilt happy
Gabor Juhos [Mon, 1 Oct 2007 08:45:39 +0000 (08:45 +0000)]
split eeprom_93cx6 patch to make quilt happy

SVN-Revision: 9084

16 years agofix path to the snapshot packages (snapshot build/upload needs to be fixed as well)
Felix Fietkau [Sun, 30 Sep 2007 21:29:55 +0000 (21:29 +0000)]
fix path to the snapshot packages (snapshot build/upload needs to be fixed as well)

SVN-Revision: 9083

16 years agodon't enable rts/cts by default (thanks nabcore, #2400)
Eugene Konev [Sun, 30 Sep 2007 03:15:24 +0000 (03:15 +0000)]
don't enable rts/cts by default (thanks nabcore, #2400)

SVN-Revision: 9078

16 years agoAdded patch from http://www.opensubscriber.com/message/jgarzik@pobox.com/7495139...
Rod Whitby [Sun, 30 Sep 2007 00:10:57 +0000 (00:10 +0000)]
Added patch from opensubscriber.com/message/jgarzik@pobox.com/7495139.html

SVN-Revision: 9077

16 years agoUse the gpio-led driver, but do not enable it until we move to 2.6.23
Florian Fainelli [Sat, 29 Sep 2007 21:43:34 +0000 (21:43 +0000)]
Use the gpio-led driver, but do not enable it until we move to 2.6.23

SVN-Revision: 9076

16 years agoFix agmode selection (#2438)
Florian Fainelli [Sat, 29 Sep 2007 19:14:42 +0000 (19:14 +0000)]
Fix agmode selection (#2438)

SVN-Revision: 9075

16 years agoFix board_type allocation (again)
Florian Fainelli [Sat, 29 Sep 2007 19:05:23 +0000 (19:05 +0000)]
Fix board_type allocation (again)

SVN-Revision: 9074

16 years agoFix board type allocation
Florian Fainelli [Sat, 29 Sep 2007 17:09:04 +0000 (17:09 +0000)]
Fix board type allocation

SVN-Revision: 9071

16 years agoget rid of per-profile base-files
Gabor Juhos [Sat, 29 Sep 2007 14:27:54 +0000 (14:27 +0000)]
get rid of per-profile base-files

SVN-Revision: 9069

16 years agofix kernel config item for 3c95x/vortex network cards (closes: #2441)
Nicolas Thill [Sat, 29 Sep 2007 14:18:47 +0000 (14:18 +0000)]
fix kernel config item for 3c95x/vortex network cards (closes: #2441)

SVN-Revision: 9068

16 years agodisable acx & acx-mac80211 on atheros, renable check for CONFIG_MAC80211 in KCONFIG...
Nicolas Thill [Sat, 29 Sep 2007 12:42:34 +0000 (12:42 +0000)]
disable acx & acx-mac80211 on atheros, renable check for CONFIG_MAC80211 in KCONFIG in acx-mac80211 so that it does not get built on pre 2.6.22

SVN-Revision: 9065

16 years agoapply latex style patch posted on openwrt-devel@lists
Felix Fietkau [Sat, 29 Sep 2007 11:35:51 +0000 (11:35 +0000)]
apply latex style patch posted on openwrt-devel@lists

SVN-Revision: 9064

16 years agofixes for refresh/update handling
Felix Fietkau [Sat, 29 Sep 2007 04:29:11 +0000 (04:29 +0000)]
fixes for refresh/update handling

SVN-Revision: 9063

16 years agomove a stampfile to make it easier to override the patch template
Felix Fietkau [Sat, 29 Sep 2007 03:39:57 +0000 (03:39 +0000)]
move a stampfile to make it easier to override the patch template

SVN-Revision: 9062

16 years agorefactor quilt patching code
Felix Fietkau [Sat, 29 Sep 2007 03:28:03 +0000 (03:28 +0000)]
refactor quilt patching code

SVN-Revision: 9061

16 years agoadd a packaging method that installs files into a subdirectory of bin/ instead of...
Felix Fietkau [Sat, 29 Sep 2007 01:21:56 +0000 (01:21 +0000)]
add a packaging method that installs files into a subdirectory of bin/ instead of an ipkg

SVN-Revision: 9060

16 years agoproper series file support for regular packages
Felix Fietkau [Sat, 29 Sep 2007 00:25:38 +0000 (00:25 +0000)]
proper series file support for regular packages

SVN-Revision: 9059

16 years agouse $(TAR) instead of tar
Felix Fietkau [Sat, 29 Sep 2007 00:16:33 +0000 (00:16 +0000)]
use $(TAR) instead of tar

SVN-Revision: 9058

16 years agoRefactor downloading code into download.mk Support multiple file downloads Support...
Felix Fietkau [Sat, 29 Sep 2007 00:05:48 +0000 (00:05 +0000)]
Refactor downloading code into download.mk Support multiple file downloads Support svn downloads

SVN-Revision: 9057

16 years agoadd missing file from [9055]
Gabor Juhos [Fri, 28 Sep 2007 20:08:55 +0000 (20:08 +0000)]
add missing file from [9055]

SVN-Revision: 9056

16 years agomake morse LED trigger available for all platforms
Gabor Juhos [Fri, 28 Sep 2007 20:06:52 +0000 (20:06 +0000)]
make morse LED trigger available for all platforms

SVN-Revision: 9055

16 years agomorse LED trigger cleanups
Gabor Juhos [Fri, 28 Sep 2007 19:01:19 +0000 (19:01 +0000)]
morse LED trigger cleanups

SVN-Revision: 9054

16 years agoadd morse LED trigger, will be used for diagnostic, update kernel config
Gabor Juhos [Fri, 28 Sep 2007 06:32:40 +0000 (06:32 +0000)]
add morse LED trigger, will be used for diagnostic, update kernel config

SVN-Revision: 9053

16 years agoadd $(STAGING_DIR) as argument to the InstallDev template and update packages accordi...
Felix Fietkau [Fri, 28 Sep 2007 01:45:11 +0000 (01:45 +0000)]
add $(STAGING_DIR) as argument to the InstallDev template and update packages accordingly - this way we can reuse InstallDev to automatically generate UninstallDev or create -dev packages

SVN-Revision: 9052

16 years agosome minor fixes, cleanups, package build abstraction
Felix Fietkau [Fri, 28 Sep 2007 01:23:56 +0000 (01:23 +0000)]
some minor fixes, cleanups, package build abstraction

SVN-Revision: 9051

16 years agoremove duplicate include statement
Felix Fietkau [Fri, 28 Sep 2007 01:23:17 +0000 (01:23 +0000)]
remove duplicate include statement

SVN-Revision: 9050

16 years agoUse the generic NAND driver
Florian Fainelli [Thu, 27 Sep 2007 15:02:41 +0000 (15:02 +0000)]
Use the generic NAND driver

SVN-Revision: 9049

16 years agoadd initial diagnostic support
Gabor Juhos [Thu, 27 Sep 2007 15:02:19 +0000 (15:02 +0000)]
add initial diagnostic support

SVN-Revision: 9048

16 years agomodules/usb.mk: Fixed the module autoload name for cdc_ether, and removed a typo...
Rod Whitby [Thu, 27 Sep 2007 14:20:53 +0000 (14:20 +0000)]
modules/usb.mk: Fixed the module autoload name for cdc_ether, and removed a typo from usbnet.

SVN-Revision: 9047

16 years agodo not fire up the qos-scripts hotplug part if the init script is disabled
Felix Fietkau [Thu, 27 Sep 2007 14:06:07 +0000 (14:06 +0000)]
do not fire up the qos-scripts hotplug part if the init script is disabled

SVN-Revision: 9046

16 years agofix mach_type for the WP54G-WRT board
Gabor Juhos [Wed, 26 Sep 2007 17:58:44 +0000 (17:58 +0000)]
fix mach_type for the WP54G-WRT board

SVN-Revision: 9040

16 years agoadd missing PCI irq map for the RouterBOARD 133 (closes #2431)
Gabor Juhos [Wed, 26 Sep 2007 17:05:16 +0000 (17:05 +0000)]
add missing PCI irq map for the RouterBOARD 133 (closes #2431)

SVN-Revision: 9039

16 years agofix kmod-hostap build on 2.4, add kmod-hostap-cs (closes: #1957)
Nicolas Thill [Wed, 26 Sep 2007 02:49:50 +0000 (02:49 +0000)]
fix kmod-hostap build on 2.4, add kmod-hostap-cs (closes: #1957)

SVN-Revision: 9030

16 years agoinclude fixes from #2429 Thanks Lubos Stanek
Travis Kemen [Tue, 25 Sep 2007 23:16:31 +0000 (23:16 +0000)]
include fixes from #2429 Thanks Lubos Stanek

SVN-Revision: 9028

16 years agoremove unused PCI externs
Gabor Juhos [Tue, 25 Sep 2007 13:45:57 +0000 (13:45 +0000)]
remove unused PCI externs

SVN-Revision: 9017

16 years agofix initcall level of adm5120_board_setup()
Gabor Juhos [Tue, 25 Sep 2007 13:42:45 +0000 (13:42 +0000)]
fix initcall level of adm5120_board_setup()

SVN-Revision: 9016

16 years agofix vlan configuration on Dell TrueMobile 2300
Gabor Juhos [Tue, 25 Sep 2007 08:34:30 +0000 (08:34 +0000)]
fix vlan configuration on Dell TrueMobile 2300

SVN-Revision: 9015

16 years agoprom_free_memory should be __init
Florian Fainelli [Mon, 24 Sep 2007 21:21:18 +0000 (21:21 +0000)]
prom_free_memory should be __init

SVN-Revision: 9011

16 years agomove pci_irq_map definitions into the board specific files
Gabor Juhos [Mon, 24 Sep 2007 16:59:23 +0000 (16:59 +0000)]
move pci_irq_map definitions into the board specific files

SVN-Revision: 9009

16 years agoFix rb535 revision 5 detection
Florian Fainelli [Mon, 24 Sep 2007 15:09:10 +0000 (15:09 +0000)]
Fix rb535 revision 5 detection

SVN-Revision: 9008

16 years agoIncreased the size of the microcode payload area.
Rod Whitby [Mon, 24 Sep 2007 13:11:45 +0000 (13:11 +0000)]
Increased the size of the microcode payload area.

SVN-Revision: 9007

16 years agodep fix
Felix Fietkau [Mon, 24 Sep 2007 00:11:37 +0000 (00:11 +0000)]
dep fix

SVN-Revision: 9006

16 years agoremove obsolete file
Felix Fietkau [Mon, 24 Sep 2007 00:11:20 +0000 (00:11 +0000)]
remove obsolete file

SVN-Revision: 9005

16 years agofix kmod-crypto-core error missing crypto_hash (closes: #2422)
Nicolas Thill [Sun, 23 Sep 2007 23:47:08 +0000 (23:47 +0000)]
fix kmod-crypto-core error missing crypto_hash (closes: #2422)

SVN-Revision: 9004

16 years agoadd LM77 sensors support (closes: #2419)
Nicolas Thill [Sun, 23 Sep 2007 21:21:51 +0000 (21:21 +0000)]
add LM77 sensors support (closes: #2419)

SVN-Revision: 9002

16 years agoupdate acx-mac80211
Matteo Croce [Sun, 23 Sep 2007 21:07:53 +0000 (21:07 +0000)]
update acx-mac80211

SVN-Revision: 9001

16 years agoadd ipv6 conntrack support (closes: #2192)
Nicolas Thill [Sun, 23 Sep 2007 17:22:17 +0000 (17:22 +0000)]
add ipv6 conntrack support (closes: #2192)

SVN-Revision: 8984

16 years agomove hardware monitoring support in a separate hwmon.mk (before adding other modules)
Nicolas Thill [Sun, 23 Sep 2007 17:14:24 +0000 (17:14 +0000)]
move hardware monitoring support in a separate hwmon.mk (before adding other modules)

SVN-Revision: 8983

16 years agomove crypto support to a seperate crypto.mk file, split modules into multiple package...
Nicolas Thill [Sun, 23 Sep 2007 15:12:12 +0000 (15:12 +0000)]
move crypto support to a seperate crypto.mk file, split modules into multiple packages and adjust dependencies, sync crypto options in kconfigs.

SVN-Revision: 8980

16 years agofix a copy-paste error
Gabor Juhos [Sun, 23 Sep 2007 14:04:46 +0000 (14:04 +0000)]
fix a copy-paste error

SVN-Revision: 8979

16 years agoadd preliminary support for the Mikrotik RouterBOARD 192
Gabor Juhos [Sun, 23 Sep 2007 13:11:35 +0000 (13:11 +0000)]
add preliminary support for the Mikrotik RouterBOARD 192

SVN-Revision: 8978

16 years agofix ethernet vlan matrix of the NP28G board (closes: #2387)
Gabor Juhos [Sun, 23 Sep 2007 13:05:33 +0000 (13:05 +0000)]
fix ethernet vlan matrix of the NP28G board (closes: #2387)

SVN-Revision: 8977

16 years agobackport [8862] to pre 2.6.22 kernels as well
Nicolas Thill [Sun, 23 Sep 2007 11:12:54 +0000 (11:12 +0000)]
backport [8862] to pre 2.6.22 kernels as well

SVN-Revision: 8975

16 years agoadd necessary includes
Eugene Konev [Sun, 23 Sep 2007 08:13:08 +0000 (08:13 +0000)]
add necessary includes

SVN-Revision: 8974

16 years agoadd initial version of a package feeds management script
Felix Fietkau [Sun, 23 Sep 2007 02:39:01 +0000 (02:39 +0000)]
add initial version of a package feeds management script

SVN-Revision: 8973

16 years agoadded option to atheros kernel to be able to disable reset button from inside the...
John Crispin [Sun, 23 Sep 2007 00:32:31 +0000 (00:32 +0000)]
added option to atheros kernel to be able to disable reset button from inside the fon mp3 driver

SVN-Revision: 8969

16 years agoonly build linux-atm if it's actually selected
Felix Fietkau [Sat, 22 Sep 2007 23:40:41 +0000 (23:40 +0000)]
only build linux-atm if it's actually selected

SVN-Revision: 8968

16 years agomake ATM_DRIVERS default to n
Felix Fietkau [Sat, 22 Sep 2007 23:36:37 +0000 (23:36 +0000)]
make ATM_DRIVERS default to n

SVN-Revision: 8967

16 years agoadd missing kconfig option for pppoa
Felix Fietkau [Sat, 22 Sep 2007 23:34:39 +0000 (23:34 +0000)]
add missing kconfig option for pppoa

SVN-Revision: 8965

16 years agoremove linux-atm from ppp build deps - the internal version seems to be working
Felix Fietkau [Sat, 22 Sep 2007 23:32:24 +0000 (23:32 +0000)]
remove linux-atm from ppp build deps - the internal version seems to be working

SVN-Revision: 8964

16 years agoadd missing 2.6 conntrack/nat helpers, add 2.6 conntrack/nat helper for RTSP (closes...
Nicolas Thill [Sat, 22 Sep 2007 18:37:24 +0000 (18:37 +0000)]
add missing 2.6 conntrack/nat helpers, add 2.6 conntrack/nat helper for RTSP (closes: #2297, thanks to aorlinsk), sync 2.4 / 2.6 kconfigs.

SVN-Revision: 8955

16 years agorefresh brcm-2.4 kconfig
Nicolas Thill [Sat, 22 Sep 2007 15:06:15 +0000 (15:06 +0000)]
refresh brcm-2.4 kconfig

SVN-Revision: 8949

16 years agoset CONFIG_JFFS2_FS_DEBUG=0 in generic 2.4 kconfig
Nicolas Thill [Sat, 22 Sep 2007 15:03:39 +0000 (15:03 +0000)]
set CONFIG_JFFS2_FS_DEBUG=0 in generic 2.4 kconfig

SVN-Revision: 8948

16 years agobase-files: Added support for swap configuration in /etc/config/fstab
Rod Whitby [Sat, 22 Sep 2007 13:47:20 +0000 (13:47 +0000)]
base-files: Added support for swap configuration in /etc/config/fstab

SVN-Revision: 8947

16 years agoenable ps -w by default
Felix Fietkau [Sat, 22 Sep 2007 13:41:28 +0000 (13:41 +0000)]
enable ps -w by default

SVN-Revision: 8946

16 years agoadd back scx200 gpio i2c module removed in [8825] (too early for generic gpio), renam...
Nicolas Thill [Sat, 22 Sep 2007 04:27:35 +0000 (04:27 +0000)]
add back scx200 gpio i2c module removed in [8825] (too early for generic gpio), rename scx200 access bus i2c module to scx200-acb

SVN-Revision: 8944

16 years agoremove uneeded flags, fix shared lib install
Nicolas Thill [Sat, 22 Sep 2007 04:22:30 +0000 (04:22 +0000)]
remove uneeded flags, fix shared lib install

SVN-Revision: 8943

16 years agoadd 2 new kernel modules for USB webcams: ovc511 and ovcamchip
Nicolas Thill [Sat, 22 Sep 2007 04:17:24 +0000 (04:17 +0000)]
add 2 new kernel modules for USB webcams: ovc511 and ovcamchip

SVN-Revision: 8942

16 years agoinstall OpenSSL pkgconfig dev files
Nicolas Thill [Sat, 22 Sep 2007 04:15:33 +0000 (04:15 +0000)]
install OpenSSL pkgconfig dev files

SVN-Revision: 8941

16 years agoBuild both NPE-B and NPE-C microcode for the fsg-3 and other dual-ethernet ixp4xx...
Rod Whitby [Fri, 21 Sep 2007 23:32:40 +0000 (23:32 +0000)]
Build both NPE-B and NPE-C microcode for the fsg-3 and other dual-ethernet ixp4xx devices.

SVN-Revision: 8939

16 years agorename NAND driver
Gabor Juhos [Fri, 21 Sep 2007 19:00:45 +0000 (19:00 +0000)]
rename NAND driver

SVN-Revision: 8932

16 years agouse prepare_generic_squashfs in image generation, thanks ffrrrr
Gabor Juhos [Fri, 21 Sep 2007 17:13:51 +0000 (17:13 +0000)]
use prepare_generic_squashfs in image generation, thanks ffrrrr

SVN-Revision: 8922

16 years agofix image preconfiguration
Eugene Konev [Fri, 21 Sep 2007 17:01:46 +0000 (17:01 +0000)]
fix image preconfiguration

SVN-Revision: 8921

16 years agoadd initial generic gpio-leds support
Eugene Konev [Fri, 21 Sep 2007 14:04:29 +0000 (14:04 +0000)]
add initial generic gpio-leds support

SVN-Revision: 8918

16 years agoAdded support for /etc/default/fstab - a means of automatically mounting devices...
Rod Whitby [Fri, 21 Sep 2007 13:20:50 +0000 (13:20 +0000)]
Added support for /etc/default/fstab - a means of automatically mounting devices on boot.

SVN-Revision: 8916

16 years agoadd support for OV51x based USB video devices with in-kernel JPEG decompression ...
Nicolas Thill [Fri, 21 Sep 2007 13:10:13 +0000 (13:10 +0000)]
add support for OV51x based USB video devices with in-kernel JPEG decompression (closes: #2315)

SVN-Revision: 8915

16 years agoadd support for NW8xx based USB video devices (closes: #2319)
Nicolas Thill [Fri, 21 Sep 2007 13:06:31 +0000 (13:06 +0000)]
add support for NW8xx based USB video devices (closes: #2319)

SVN-Revision: 8914

16 years agoadd support Konica based USB video devices
Nicolas Thill [Fri, 21 Sep 2007 13:05:13 +0000 (13:05 +0000)]
add support Konica based USB video devices

SVN-Revision: 8913