generic: drop support for get_port_stats() on ar8xxx
authorThibaut VARENE <hacks@slashdirt.org>
Tue, 12 Sep 2017 21:22:37 +0000 (23:22 +0200)
committerMathias Kresin <dev@kresin.me>
Wed, 13 Sep 2017 06:07:54 +0000 (08:07 +0200)
commiteff3549c5883a9abc5dbff00c084cabbcfdf4437
tree4de1960519ea37204b73f45aa9c97de4361dd45c
parentfd84ecda7d3bfebb4237110b8efe2ab2713ea8e1
generic: drop support for get_port_stats() on ar8xxx

The implementation is not efficient on ar8xxx switches. It triggers high
CPU load and degrades device performance.

The high CPU load has been traced down to the ar8xxx_reg_wait() call in
ar8xxx_mib_op(), which has to usleep_range() till the MIB busy flag set
by the request to update the MIB counter is cleared.

This commit removes the get_port_stats() code introduced in 4d8a66d and
leaves a note for future hacker's beware.

Fixes: FS#1004
Signed-off-by: Thibaut VARENE <hacks@slashdirt.org>
target/linux/generic/files/drivers/net/phy/ar8216.c
target/linux/generic/files/drivers/net/phy/ar8216.h
target/linux/generic/files/drivers/net/phy/ar8327.c