From e606b1603bd65ac4ecf4e60d4ca20d5296f0ecee Mon Sep 17 00:00:00 2001 From: Felix Fietkau Date: Wed, 30 Jul 2008 05:22:02 +0000 Subject: [PATCH] properly keep track of bridged interfaces in the network state SVN-Revision: 12004 --- package/base-files/files/lib/network/config.sh | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/package/base-files/files/lib/network/config.sh b/package/base-files/files/lib/network/config.sh index 7fa1d37e49..3d58c63f78 100755 --- a/package/base-files/files/lib/network/config.sh +++ b/package/base-files/files/lib/network/config.sh @@ -64,6 +64,16 @@ add_vlan() { } } +# sort the device list, drop duplicates +sort_list() { + local arg="$*" + ( + for item in $arg; do + echo "$item" + done + ) | sort -u +} + # Create the interface, if necessary. # Return status 0 indicates that the setup_interface() call should continue # Return status 1 means that everything is set up already. @@ -94,6 +104,13 @@ prepare_interface() { bridge) [ -x /usr/sbin/brctl ] && { ifconfig "br-$config" 2>/dev/null >/dev/null && { + local newdevs= + + config_get devices "$config" device + for dev in $(sort_list "$devices" "$iface"); do + append newdevs "$dev" + done + uci_set_state network "$config" device "$newdevs" $DEBUG brctl addif "br-$config" "$iface" # Bridge existed already. No further processing necesary } || { -- 2.30.2