target/linux/brcm2708/patches-4.4/0212-vchiq_arm-Service-callbacks-must-not-fail.patch

   1 From 523feff6ae02ad31e7d35aa07685ea1d37eae9f1 Mon Sep 17 00:00:00 2001
   2 From: Phil Elwell <phil@raspberrypi.org>
   3 Date: Wed, 23 Mar 2016 20:53:47 +0000
   4 Subject: [PATCH 212/304] vchiq_arm: Service callbacks must not fail
   5
   6 Service callbacks are not allowed to return an error. The internal callback
   7 that delivers events and messages to user tasks does not enqueue them if
   8 the service is closing, but this is not an error and should not be
   9 reported as such.
  10
  11 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
  12 ---
  13  drivers/misc/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
  14  1 file changed, 1 insertion(+), 1 deletion(-)
  15
  16 --- a/drivers/misc/vc04_services/interface/vchiq_arm/vchiq_arm.c
  17 +++ b/drivers/misc/vc04_services/interface/vchiq_arm/vchiq_arm.c
  18 @@ -224,7 +224,7 @@ add_completion(VCHIQ_INSTANCE_T instance
  19                 } else if (instance->closing) {
  20                         vchiq_log_info(vchiq_arm_log_level,
  21                                 "service_callback closing");
  22 -                       return VCHIQ_ERROR;
  23 +                       return VCHIQ_SUCCESS;
  24                 }
  25                 DEBUG_TRACE(SERVICE_CALLBACK_LINE);
  26         }