dnsmasq: fix dnssec+ntp chicken-and-egg workaround (FS#2574)
authorHenrique de Moraes Holschuh <henrique@nic.br>
Sun, 1 Mar 2020 03:08:43 +0000 (00:08 -0300)
committerHans Dedecker <dedeckeh@gmail.com>
Wed, 25 Mar 2020 20:40:51 +0000 (21:40 +0100)
commit556b8581a15c855b2de0efbea6b625ab16cc9daf
treec47599d445eb830597a83d32001695369c3d2b65
parentf81403c43354ad646bff647a5f5e58c1588b599d
dnsmasq: fix dnssec+ntp chicken-and-egg workaround (FS#2574)

Fix the test for an enabled sysntp initscript in dnsmasq.init, and get
rid of "test -o" while at it.

Issue reproduced on openwrt-19.07 with the help of pool.ntp.br and an
RTC-less ath79 router.  dnssec-no-timecheck would be clearly missing
from /var/etc/dnsmasq.conf.* while the router was still a few days in
the past due to non-working DNSSEC + DNS-based NTP server config.

The fix was tested with the router in the "DNSSEC broken state": it
properly started dnsmasq in dnssec-no-timecheck mode, and eventually ntp
was able to resolve the server name to an IP address, and set the system
time.  DNSSEC was then enabled by SIGINT through the ntp hotplug hook,
as expected.

A missing system.ntp.enabled UCI node is required for the bug to show
up.  The reasons for why it would be missing in the first place were not
investigated.

Signed-off-by: Henrique de Moraes Holschuh <henrique@nic.br>
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com> [PKG_RELEASE increase]
package/network/services/dnsmasq/Makefile
package/network/services/dnsmasq/files/dnsmasq.init