dnsmasq: add config option for connmark DNS filtering
[openwrt/staging/ldir.git] / package / network / services / dnsmasq / files / dnsmasq.init
index e19c56f6a92348a3dda66d96a1bb475178712fb3..3e06218a430eca0afa74ec9cdea8a12b11d7079b 100644 (file)
@@ -22,15 +22,18 @@ DHCPSCRIPT="/usr/lib/dnsmasq/dhcp-script.sh"
 
 DNSMASQ_DHCP_VER=4
 
-dnsmasq_features="$(dnsmasq --version | grep -m1 'Compile time options:' | cut -d: -f2) "
-[ "${dnsmasq_features#* DHCP }" = "$dnsmasq_features" ] || dnsmasq_has_dhcp=1
-[ "${dnsmasq_features#* DHCPv6 }" = "$dnsmasq_features" ] || dnsmasq_has_dhcp6=1
-[ "${dnsmasq_features#* DNSSEC }" = "$dnsmasq_features" ] || dnsmasq_has_dnssec=1
-[ "${dnsmasq_features#* TFTP }" = "$dnsmasq_features" ] || dnsmasq_has_tftp=1
-[ "${dnsmasq_features#* ipset }" = "$dnsmasq_features" ] || dnsmasq_has_ipset=1
 dnsmasq_ignore_opt() {
        local opt="$1"
 
+       if [ -z "$dnsmasq_features" ]; then
+               dnsmasq_features="$(dnsmasq --version | grep -m1 'Compile time options:' | cut -d: -f2) "
+               [ "${dnsmasq_features#* DHCP }" = "$dnsmasq_features" ] || dnsmasq_has_dhcp=1
+               [ "${dnsmasq_features#* DHCPv6 }" = "$dnsmasq_features" ] || dnsmasq_has_dhcp6=1
+               [ "${dnsmasq_features#* DNSSEC }" = "$dnsmasq_features" ] || dnsmasq_has_dnssec=1
+               [ "${dnsmasq_features#* TFTP }" = "$dnsmasq_features" ] || dnsmasq_has_tftp=1
+               [ "${dnsmasq_features#* ipset }" = "$dnsmasq_features" ] || dnsmasq_has_ipset=1
+       fi
+
        case "$opt" in
                dhcp-duid|\
                ra-param)
@@ -39,9 +42,14 @@ dnsmasq_ignore_opt() {
                bootp-*|\
                pxe-*)
                        [ -z "$dnsmasq_has_dhcp" ] ;;
-               dnssec-*|\
+               dnssec*|\
                trust-anchor)
-                       [ -z "$dnsmasq_has_dnssec" ] ;;
+                       if [ -z "$dnsmasq_has_dnssec" ]; then
+                               echo "dnsmasq: \"$opt\" requested, but dnssec support is not available" >&2
+                               exit 1
+                       fi
+                       return 1
+                       ;;
                tftp-*)
                        [ -z "$dnsmasq_has_tftp" ] ;;
                ipset)
@@ -99,19 +107,14 @@ dhcp_check() {
 
        [ -s "$stamp" ] && return $(cat "$stamp")
 
-       # If there's no carrier yet, skip this interface.
+       # If interface is down, skip it.
        # The init script will be called again once the link is up
-       case "$(devstatus "$ifname" | jsonfilter -e @.carrier)" in
+       case "$(devstatus "$ifname" | jsonfilter -e @.up)" in
                false) return 1;;
        esac
 
        udhcpc -n -q -s /bin/true -t 1 -i "$ifname" >&- && rv=1 || rv=0
 
-       [ $rv -eq 1 ] && \
-               logger -t dnsmasq \
-                       "found already running DHCP-server on interface '$ifname'" \
-                       "refusing to start, use 'option force 1' to override"
-
        echo $rv > "$stamp"
        return $rv
 }
@@ -169,6 +172,10 @@ append_ipset() {
        xappend "--ipset=$1"
 }
 
+append_connmark_allowlist() {
+       xappend "--connmark-allowlist=$1"
+}
+
 append_interface() {
        network_get_device ifname "$1" || ifname="$1"
        xappend "--interface=$ifname"
@@ -204,7 +211,7 @@ filter_dnsmasq() {
 
        # use entry when no instance entry set, or if it matches
        config_get found_cfg "$cfg" "instance"
-       if [ -z "$found_cfg" -o "$found_cfg" = "$match_cfg" ]; then
+       if [ -z "$found_cfg" ] || [ "$found_cfg" = "$match_cfg" ]; then
                $func $cfg
        fi
 }
@@ -323,10 +330,10 @@ dhcp_host_add() {
        config_get ip "$cfg" ip
        config_get hostid "$cfg" hostid
 
-       [ -n "$ip" -o -n "$name" -o -n "$hostid" ] || return 0
+       [ -z "$ip" ] && [ -z "$name" ] && [ -z "$hostid" ] && return 0
 
        config_get_bool dns "$cfg" dns 0
-       [ "$dns" = "1" -a -n "$ip" -a -n "$name" ] && {
+       [ "$dns" = "1" ] && [ -n "$ip" ] && [ -n "$name" ] && {
                echo "$ip $name${DOMAIN:+.$DOMAIN}" >> $HOSTFILE_TMP
        }
 
@@ -340,13 +347,13 @@ dhcp_host_add() {
                for m in $mac; do append macs "$m" ","; done
        fi
 
-       if [ $DNSMASQ_DHCP_VER -eq 6 -a -n "$duid" ]; then
+       if [ $DNSMASQ_DHCP_VER -eq 6 ] && [ -n "$duid" ]; then
                # --dhcp-host=id:00:03:00:01:12:00:00:01:02:03,[::beef],lap
                # one (virtual) machine gets one DUID per RFC3315
                duids="id:${duid// */}"
        fi
 
-       if [ -z "$macs" -a -z "$duids" ]; then
+       if [ -z "$macs" ] && [ -z "$duids" ]; then
                # --dhcp-host=lap,192.168.0.199,[::beef]
                [ -n "$name" ] || return 0
                macs="$name"
@@ -413,7 +420,7 @@ dhcp_this_host_add() {
                                dhcp_domain_add "" "$routername" "$lanaddr"
                        fi
 
-                       if [ -n "$ulaprefix" -a -n "$lanaddrs6" ] ; then
+                       if [ -n "$ulaprefix" ] && [ -n "$lanaddrs6" ] ; then
                                for lanaddr6 in $lanaddrs6 ; do
                                        case "$lanaddr6" in
                                        "${ulaprefix%%:/*}"*)
@@ -469,7 +476,7 @@ dhcp_boot_add() {
        config_get servername "$cfg" servername
        config_get serveraddress "$cfg" serveraddress
 
-       [ -n "$serveraddress" -a ! -n "$servername" ] && return 0
+       [ -n "$serveraddress" ] && [ ! -n "$servername" ] && return 0
 
        xappend "--dhcp-boot=${networkid:+net:$networkid,}${filename}${servername:+,$servername}${serveraddress:+,$serveraddress}"
 
@@ -514,7 +521,12 @@ dhcp_add() {
 
        #check for an already active dhcp server on the interface, unless 'force' is set
        config_get_bool force "$cfg" force 0
-       [ $force -gt 0 ] || dhcp_check "$ifname" || return 0
+       [ $force -gt 0 ] || dhcp_check "$ifname" || {
+               logger -t dnsmasq \
+                       "found already running DHCP-server on interface '$ifname'" \
+                       "refusing to start, use 'option force 1' to override"
+               return 0
+       }
 
        config_get start "$cfg" start 100
        config_get limit "$cfg" limit 150
@@ -563,7 +575,7 @@ dhcp_add() {
        fi
 
 
-       if [ $DNSMASQ_DHCP_VER -eq 6 -a "$ra" = "server" ] ; then
+       if [ $DNSMASQ_DHCP_VER -eq 6 ] && [ "$ra" = "server" ] ; then
                # Note: dnsmasq cannot just be a DHCPv6 server (all-in-1)
                # and let some other machine(s) send RA pointing to it.
 
@@ -761,11 +773,34 @@ dhcp_relay_add() {
        fi
 }
 
+dnsmasq_ipset_add() {
+       local cfg="$1"
+       local ipsets domains
+
+       add_ipset() {
+               ipsets="${ipsets:+$ipsets,}$1"
+       }
+
+       add_domain() {
+               # leading '/' is expected
+               domains="$domains/$1"
+       }
+
+       config_list_foreach "$cfg" "name" add_ipset
+       config_list_foreach "$cfg" "domain" add_domain
+
+       if [ -z "$ipsets" ] || [ -z "$domains" ]; then
+               return 0
+       fi
+
+       xappend "--ipset=$domains/$ipsets"
+}
+
 dnsmasq_start()
 {
        local cfg="$1"
        local disabled user_dhcpscript
-       local resolvfile localuse=0
+       local resolvfile resolvdir localuse=0
 
        config_get_bool disabled "$cfg" disabled 0
        [ "$disabled" -gt 0 ] && return 0
@@ -802,13 +837,13 @@ dnsmasq_start()
        $PROG --version | grep -osqE "^Compile time options:.* DHCPv6( |$)" && DHCPv6CAPABLE=1 || DHCPv6CAPABLE=0
 
 
-       if [ -x /usr/sbin/odhcpd -a -x /etc/init.d/odhcpd ] ; then
+       if [ -x /usr/sbin/odhcpd ] && [ -x /etc/init.d/odhcpd ] ; then
                local odhcpd_is_main odhcpd_is_enabled
                config_get odhcpd_is_main odhcpd maindhcp 0
                /etc/init.d/odhcpd enabled && odhcpd_is_enabled=1 || odhcpd_is_enabled=0
 
 
-               if [ "$odhcpd_is_enabled" -eq 0 -a "$DHCPv6CAPABLE" -eq 1 ] ; then
+               if [ "$odhcpd_is_enabled" -eq 0 ] && [ "$DHCPv6CAPABLE" -eq 1 ] ; then
                        # DHCP V4 and V6 in DNSMASQ
                        DNSMASQ_DHCP_VER=6
                elif [ "$odhcpd_is_main" -gt 0 ] ; then
@@ -831,7 +866,7 @@ dnsmasq_start()
                if [ -x /etc/init.d/dhcpd ] ; then
                        /etc/init.d/dhcpd enabled && DNSMASQ_DHCP_VER=0
                fi
-               if [ -x /etc/init.d/dhcpd6 -a "$DNSMASQ_DHCP_VER" -gt 0 ] ; then
+               if [ -x /etc/init.d/dhcpd6 ] && [ "$DNSMASQ_DHCP_VER" -gt 0 ] ; then
                        /etc/init.d/dhcpd6 enabled && DNSMASQ_DHCP_VER=4
                fi
        fi
@@ -863,6 +898,7 @@ dnsmasq_start()
        append_bool "$cfg" allservers "--all-servers"
        append_bool "$cfg" noping "--no-ping"
        append_bool "$cfg" rapidcommit "--dhcp-rapid-commit"
+       append_bool "$cfg" scriptarp "--script-arp"
 
        append_parm "$cfg" logfacility "--log-facility"
 
@@ -881,6 +917,14 @@ dnsmasq_start()
        config_list_foreach "$cfg" "rev_server" append_rev_server
        config_list_foreach "$cfg" "address" append_address
        config_list_foreach "$cfg" "ipset" append_ipset
+
+       local connmark_allowlist_enable
+       config_get connmark_allowlist_enable "$cfg" connmark_allowlist_enable 0
+       [ "$connmark_allowlist_enable" -gt 0 ] && {
+               append_parm "$cfg" "connmark_allowlist_enable" "--connmark-allowlist-enable"
+               config_list_foreach "$cfg" "connmark_allowlist" append_connmark_allowlist
+       }
+
        [ -n "$BOOT" ] || {
                config_list_foreach "$cfg" "interface" append_interface
                config_list_foreach "$cfg" "notinterface" append_notinterface
@@ -896,6 +940,7 @@ dnsmasq_start()
        append_parm "$cfg" "min_cache_ttl" "--min-cache-ttl"
        append_parm "$cfg" "max_cache_ttl" "--max-cache-ttl"
        append_parm "$cfg" "pxe_prompt" "--pxe-prompt"
+       append_parm "$cfg" "tftp_unique_root" "--tftp-unique-root"
        config_list_foreach "$cfg" "pxe_service" append_pxe_service
        config_get DOMAIN "$cfg" domain
 
@@ -912,18 +957,20 @@ dnsmasq_start()
        config_get user_dhcpscript $cfg dhcpscript
        if has_handler || [ -n "$user_dhcpscript" ]; then
                xappend "--dhcp-script=$DHCPSCRIPT"
+               xappend "--script-arp"
        fi
 
        config_get leasefile $cfg leasefile "/tmp/dhcp.leases"
-       [ -n "$leasefile" -a \! -e "$leasefile" ] && touch "$leasefile"
+       [ -n "$leasefile" ] && [ ! -e "$leasefile" ] && touch "$leasefile"
        config_get_bool cachelocal "$cfg" cachelocal 1
 
        config_get_bool noresolv "$cfg" noresolv 0
        if [ "$noresolv" != "1" ]; then
-               config_get resolvfile "$cfg" resolvfile /tmp/resolv.conf.auto
-               [ -n "$resolvfile" -a ! -e "$resolvfile" ] && touch "$resolvfile"
+               config_get resolvfile "$cfg" resolvfile /tmp/resolv.conf.d/resolv.conf.auto
+               [ -n "$resolvfile" ] && [ ! -e "$resolvfile" ] && touch "$resolvfile"
                xappend "--resolv-file=$resolvfile"
-               [ "$resolvfile" = "/tmp/resolv.conf.auto" ] && localuse=1
+               [ "$resolvfile" = "/tmp/resolv.conf.d/resolv.conf.auto" ] && localuse=1
+               resolvdir="$(dirname "$resolvfile")"
        fi
        config_get_bool localuse "$cfg" localuse "$localuse"
 
@@ -958,12 +1005,12 @@ dnsmasq_start()
                xappend "--conf-file=$TRUSTANCHORSFILE"
                xappend "--dnssec"
                [ -x /etc/init.d/sysntpd ] && {
-                       /etc/init.d/sysntpd enabled
-                       [ "$?" -ne 0 -o "$(uci_get system.ntp.enabled)" = "1" ] && {
+                       if /etc/init.d/sysntpd enabled || [ "$(uci_get system.ntp.enabled)" = "1" ] ; then
                                [ -f "$TIMEVALIDFILE" ] || xappend "--dnssec-no-timecheck"
-                       }
+                       fi
                }
-               append_bool "$cfg" dnsseccheckunsigned "--dnssec-check-unsigned"
+               config_get_bool dnsseccheckunsigned "$cfg" dnsseccheckunsigned 1
+               [ "$dnsseccheckunsigned" -eq 0 ] && xappend "--dnssec-check-unsigned=no"
        }
 
        config_get addmac "$cfg" addmac 0
@@ -977,7 +1024,12 @@ dnsmasq_start()
 
        xappend "--dhcp-broadcast=tag:needs-broadcast"
 
-       xappend "--addn-hosts=$(dirname $HOSTFILE)"
+       config_get_bool ignore_hosts_dir "$cfg" ignore_hosts_dir 0
+       if [ "$ignore_hosts_dir" = "1" ]; then
+               xappend "--addn-hosts=$HOSTFILE"
+       else
+               xappend "--addn-hosts=$(dirname $HOSTFILE)"
+       fi
 
        config_get dnsmasqconfdir "$cfg" confdir "/tmp/dnsmasq.d"
        xappend "--conf-dir=$dnsmasqconfdir"
@@ -1044,6 +1096,10 @@ dnsmasq_start()
        config_foreach filter_dnsmasq cname dhcp_cname_add "$cfg"
        echo >> $CONFIGFILE_TMP
 
+       echo >> $CONFIGFILE_TMP
+       config_foreach filter_dnsmasq ipset dnsmasq_ipset_add "$cfg"
+       echo >> $CONFIGFILE_TMP
+
        echo >> $CONFIGFILE_TMP
        mv -f $CONFIGFILE_TMP $CONFIGFILE
        mv -f $HOSTFILE_TMP $HOSTFILE
@@ -1054,6 +1110,7 @@ dnsmasq_start()
                        echo "search $DOMAIN" >> /tmp/resolv.conf
                }
                DNS_SERVERS="$DNS_SERVERS 127.0.0.1"
+               [ -e /proc/sys/net/ipv6 ] && DNS_SERVERS="$DNS_SERVERS ::1"
                for DNS_SERVER in $DNS_SERVERS ; do
                        echo "nameserver $DNS_SERVER" >> /tmp/resolv.conf
                done
@@ -1066,7 +1123,7 @@ dnsmasq_start()
        procd_set_param respawn
 
        procd_add_jail dnsmasq ubus log
-       procd_add_jail_mount $CONFIGFILE $TRUSTANCHORSFILE $HOSTFILE $RFC6761FILE $DHCPBOGUSHOSTNAMEFILE /etc/passwd /etc/group /etc/TZ /dev/null /dev/urandom $dnsmasqconffile $dnsmasqconfdir $resolvfile $user_dhcpscript /etc/hosts /etc/ethers /sbin/hotplug-call $EXTRA_MOUNT $DHCPSCRIPT
+       procd_add_jail_mount $CONFIGFILE $TRUSTANCHORSFILE $HOSTFILE $RFC6761FILE $DHCPBOGUSHOSTNAMEFILE /etc/passwd /etc/group /etc/TZ /dev/null /dev/urandom $dnsmasqconffile $dnsmasqconfdir $resolvdir $user_dhcpscript /etc/hosts /etc/ethers /sbin/hotplug-call $EXTRA_MOUNT $DHCPSCRIPT
        procd_add_jail_mount_rw /var/run/dnsmasq/ $leasefile
 
        procd_close_instance
@@ -1080,9 +1137,9 @@ dnsmasq_stop()
        config_get_bool noresolv "$cfg" noresolv 0
        config_get resolvfile "$cfg" "resolvfile"
 
-       [ "$noresolv" = 0 -a "$resolvfile" = "/tmp/resolv.conf.auto" ] && localuse=1
+       [ "$noresolv" = 0 ] && [ "$resolvfile" = "/tmp/resolv.conf.d/resolv.conf.auto" ] && localuse=1
        config_get_bool localuse "$cfg" localuse "$localuse"
-       [ "$localuse" -gt 0 ] && ln -sf "/tmp/resolv.conf.auto" /tmp/resolv.conf
+       [ "$localuse" -gt 0 ] && ln -sf "/tmp/resolv.conf.d/resolv.conf.auto" /tmp/resolv.conf
 
        rm -f ${BASEDHCPSTAMPFILE}.${cfg}.*.dhcp
 }
@@ -1094,7 +1151,7 @@ add_interface_trigger()
        config_get interface "$1" interface
        config_get_bool ignore "$1" ignore 0
 
-       [ -n "$interface" -a $ignore -eq 0 ] && procd_add_interface_trigger "interface.*" "$interface" /etc/init.d/dnsmasq reload
+       [ -n "$interface" ] && [ $ignore -eq 0 ] && procd_add_interface_trigger "interface.*" "$interface" /etc/init.d/dnsmasq reload
 }
 
 service_triggers()
@@ -1122,7 +1179,7 @@ start_service() {
                local type="$1"
                local name="$2"
                if [ "$type" = "dnsmasq" ]; then
-                       if [ -n "$instance" -a "$instance" = "$name" ]; then
+                       if [ -n "$instance" ] && [ "$instance" = "$name" ]; then
                                instance_found=1
                        fi
                fi
@@ -1151,7 +1208,7 @@ stop_service() {
                local type="$1"
                local name="$2"
                if [ "$type" = "dnsmasq" ]; then
-                       if [ -n "$instance" -a "$instance" = "$name" ]; then
+                       if [ -n "$instance" ] && [ "$instance" = "$name" ]; then
                                instance_found=1
                        fi
                fi