target/linux/bcm27xx/patches-4.19/950-0407-staging-bcm2835-audio-update-TODO.patch

   1 From 56b704581afbd8d9ccd73cfa7935b6178749a3e9 Mon Sep 17 00:00:00 2001
   2 From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
   3 Date: Wed, 17 Oct 2018 21:01:56 +0200
   4 Subject: [PATCH] staging: bcm2835-audio: update TODO
   5
   6 commit 01ec7398c56e8f1b903ecb3c5c75400e263eef43 upstream.
   7
   8 The following tasks were completed or not the right solution:
   9
  10 1/2- Not the proper solution, we should register a platform device in
  11 vchiq the same way it's done with bcm2835-camera as commented here:
  12 https://lkml.org/lkml/2018/10/16/1131
  13
  14 2/3- Fixed by Takashi Iwai here: https://lkml.org/lkml/2018/9/4/587
  15
  16 Also, adds a new task as per mailing list conversation.
  17
  18 Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
  19 Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
  20 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  21 ---
  22  .../staging/vc04_services/bcm2835-audio/TODO  | 25 +++----------------
  23  1 file changed, 3 insertions(+), 22 deletions(-)
  24
  25 --- a/drivers/staging/vc04_services/bcm2835-audio/TODO
  26 +++ b/drivers/staging/vc04_services/bcm2835-audio/TODO
  27 @@ -4,26 +4,7 @@
  28  *                                                                           *
  29  *****************************************************************************
  30
  31 +1) Revisit multi-cards options and PCM route mixer control (as per comment
  32 +https://lkml.org/lkml/2018/9/8/200)
  33
  34 -1) Document the device tree node
  35 -
  36 -The downstream tree(the tree that the driver was imported from) at
  37 -http://www.github.com/raspberrypi/linux uses this node:
  38 -
  39 -audio: audio {
  40 -       compatible = "brcm,bcm2835-audio";
  41 -       brcm,pwm-channels = <8>;
  42 -};
  43 -
  44 -Since the driver requires the use of VCHIQ, it may be useful to have a link
  45 -in the device tree to the VCHIQ driver.
  46 -
  47 -2) Gracefully handle the case where VCHIQ is missing from the device tree or
  48 -it has not been initialized yet.
  49 -
  50 -3) Review error handling and remove duplicate code.
  51 -
  52 -4) Cleanup the logging mechanism.  The driver should probably be using the
  53 -standard kernel logging mechanisms such as dev_info, dev_dbg, and friends.
  54 -
  55 -5) Fix the remaining checkpatch.pl errors and warnings.
  56 +2) Fix the remaining checkpatch.pl errors and warnings.