dnsmasq: Fix hosts file format when MAC address is not specified
authorJohn Crispin <john@openwrt.org>
Thu, 28 Aug 2014 06:27:53 +0000 (06:27 +0000)
committerJohn Crispin <john@openwrt.org>
Thu, 28 Aug 2014 06:27:53 +0000 (06:27 +0000)
commit504620931254f4a484b089f593ca631339373152
tree70bb2be73ece874ed02ac4f4b689d421944c1647
parent449994b8c21921f8894fe626ecea3ecbe5ffcd16
dnsmasq: Fix hosts file format when MAC address is not specified

An entry like this in /etc/config/dhcp:

    config 'host'
        option 'name' 'pc2'
        option 'ip' '192.168.100.56'
        option 'dns' '1'

results in a /tmp/hosts/dhcp entry that looks like this:

    192.168.100.56 .lan

Obviously it should say "pc2.lan".

This happens because $name is set to "" in order to support the MAC-less
syntax: "--dhcp-host=lap,192.168.0.199".  Fix this by reordering the
operations.  Also, refuse to add a DNS entry if the hostname or IP is
missing.

Fixes #17683

Reported-by: Kostas Papadopoulos <kpapad75@travelguide.gr>
Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
SVN-Revision: 42319
package/network/services/dnsmasq/files/dnsmasq.init