Fix a memory leak in hotplug2 environment handling. Bump hotplug2 to the latest svn...
authorFelix Fietkau <nbd@openwrt.org>
Wed, 9 Dec 2009 18:50:49 +0000 (18:50 +0000)
committerFelix Fietkau <nbd@openwrt.org>
Wed, 9 Dec 2009 18:50:49 +0000 (18:50 +0000)
commit679cab88fe71ce59c158f2a6ba99b669a9069f63
treeacc30c3875e38895d7b46a93b2d2977b70d3425f
parentd5d8a225f886ebe776a75d5a877a5af96f658abf
Fix a memory leak in hotplug2 environment handling. Bump hotplug2 to the latest svn revision, remove obsolete patches.

Memory leak is caused by the way hotplug2 handles environment variables,
using setenv() and unsetenv(). setenv() creates copies of the supplied
strings, but, due to a POSIX blunder, these copies are never destroyed
by unsetenv(), neither in glibc nor uclibc - not until the program
terminates.

Since some events are handled directly in the main process, even when
configured with the "fork" worker, hotplug2 memory usage will keep
growing over time. This can be observed by running "udevtrigger" and
noting the increase in hotplug2 VmRSS after each run.

This patch uses putenv() instead, which leaves storage management to
the caller, so that we can explicitly delete stuff when it's no longer
needed.

Signed-off-by: Aleksandar Radovanovic <biblbroks@sezampro.rs>
SVN-Revision: 18725
package/hotplug2/Makefile
package/hotplug2/patches/100-env_memleak.patch [new file with mode: 0644]
package/hotplug2/patches/100-recv_check.patch [deleted file]
package/hotplug2/patches/110-static_worker.patch