package/kernel/mac80211/patches/350-0002-brcmfmac-add-eth_type_trans-back-for-PCIe-full-dongl.patch

   1 From: Franky Lin <franky.lin@broadcom.com>
   2 Date: Thu, 2 Jun 2016 02:00:27 -0700
   3 Subject: [PATCH] brcmfmac: add eth_type_trans back for PCIe full dongle
   4
   5 A regression was introduced in commit 9c349892ccc9 ("brcmfmac: revise
   6 handling events in receive path") which moves eth_type_trans() call
   7 to brcmf_rx_frame(). Msgbuf layer doesn't use brcmf_rx_frame() but invokes
   8 brcmf_netif_rx() directly. In such case the Ethernet header was not
   9 stripped out resulting in null pointer dereference in the networking
  10 stack.
  11
  12 BUG: unable to handle kernel NULL pointer dereference at 0000000000000048
  13 IP: [<ffffffff814c3ce6>] enqueue_to_backlog+0x56/0x260
  14 PGD 0
  15 Oops: 0000 [#1] PREEMPT SMP
  16 Modules linked in: fuse ipt_MASQUERADE nf_nat_masquerade_ipv4
  17 iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 xt_addrtype
  18 [...]
  19 rtsx_pci scsi_mod usbcore usb_common i8042 serio nvme nvme_core
  20 CPU: 7 PID: 1340 Comm: irq/136-brcmf_p Not tainted 4.7.0-rc1-mainline #1
  21 Hardware name: Dell Inc. XPS 15 9550/0N7TVV, BIOS 01.02.00 04/07/2016
  22 task: ffff8804a0c5bd00 ti: ffff88049e124000 task.ti: ffff88049e124000
  23 RIP: 0010:[<ffffffff814c3ce6>] [<ffffffff814c3ce6>]
  24 enqueue_to_backlog+0x56/0x260
  25 RSP: 0018:ffff88049e127ca0 EFLAGS: 00010046
  26 RAX: 0000000000000000 RBX: ffff8804bddd7c40 RCX: 000000000000002f
  27 RDX: 0000000000000000 RSI: 0000000000000007 RDI: ffff8804bddd7d4c
  28 RBP: ffff88049e127ce8 R08: 0000000000000000 R09: 0000000000000000
  29 R10: ffff8804bddd12c0 R11: 000000000000149e R12: 0000000000017c40
  30 R13: ffff88049e127d08 R14: ffff8804a9bd6d00 R15: ffff8804bddd7d4c
  31 FS: 0000000000000000(0000) GS:ffff8804bddc0000(0000) knlGS:0000000000000000
  32 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  33 CR2: 0000000000000048 CR3: 0000000001806000 CR4: 00000000003406e0
  34 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
  35 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
  36 Stack:
  37 ffff8804bdddad00 ffff8804ad089e00 0000000000000000 0000000000000282
  38 0000000000000000 ffff8804a9bd6d00 ffff8804a1b27e00 ffff8804a9bd6d00
  39 ffff88002ee88000 ffff88049e127d28 ffffffff814c3f3b ffffffff81311fc3
  40 Call Trace:
  41 [<ffffffff814c3f3b>] netif_rx_internal+0x4b/0x170
  42 [<ffffffff81311fc3>] ? swiotlb_tbl_unmap_single+0xf3/0x120
  43 [<ffffffff814c5467>] netif_rx_ni+0x27/0xc0
  44 [<ffffffffa08519e9>] brcmf_netif_rx+0x49/0x70 [brcmfmac]
  45 [<ffffffffa08564d4>] brcmf_msgbuf_process_rx+0x2b4/0x570 [brcmfmac]
  46 [<ffffffff81020017>] ? __xen_set_pgd_hyper+0x57/0xd0
  47 [<ffffffff810d60b0>] ? irq_forced_thread_fn+0x70/0x70
  48 [<ffffffffa0857381>] brcmf_proto_msgbuf_rx_trigger+0x31/0xe0 [brcmfmac]
  49 [<ffffffffa0861e8f>] brcmf_pcie_isr_thread+0x7f/0x110 [brcmfmac]
  50 [<ffffffff810d60d0>] irq_thread_fn+0x20/0x50
  51 [<ffffffff810d63ad>] irq_thread+0x12d/0x1c0
  52 [<ffffffff815d07d5>] ? __schedule+0x2f5/0x7a0
  53 [<ffffffff810d61d0>] ? wake_threads_waitq+0x30/0x30
  54 [<ffffffff810d6280>] ? irq_thread_dtor+0xb0/0xb0
  55 [<ffffffff81098ea8>] kthread+0xd8/0xf0
  56 [<ffffffff815d4b7f>] ret_from_fork+0x1f/0x40
  57 [<ffffffff81098dd0>] ? kthread_worker_fn+0x170/0x170
  58 Code: 1c f5 60 9a 8e 81 9c 58 0f 1f 44 00 00 48 89 45 d0 fa 66 0f 1f
  59 44 00 00 4c 8d bb 0c 01 00 00 4c 89 ff e8 5e 08 11 00 49 8b 56 20 <48>
  60 8b 52 48 83 e2 01 74 10 8b 8b 08 01 00 00 8b 15 59 c5 42 00
  61 RIP [<ffffffff814c3ce6>] enqueue_to_backlog+0x56/0x260
  62 RSP <ffff88049e127ca0>
  63 CR2: 0000000000000048
  64
  65 Fixes: 9c349892ccc9 ("brcmfmac: revise handling events in receive path")
  66 Reported-by: Rafal Milecki <zajec5@gmail.com>
  67 Reported-by: Grey Christoforo <grey@christoforo.net>
  68 Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
  69 Reviewed-by: Arend Van Spriel <arend@broadcom.com>
  70 Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
  71 Signed-off-by: Franky Lin <franky.lin@broadcom.com>
  72 [arend@broadcom.com: rephrased the commit message]
  73 Signed-off-by: Arend van Spriel <arend@broadcom.com>
  74 Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
  75 ---
  76
  77 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
  78 +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
  79 @@ -1157,6 +1157,8 @@ brcmf_msgbuf_process_rx_complete(struct
  80                 brcmu_pkt_buf_free_skb(skb);
  81                 return;
  82         }
  83 +
  84 +       skb->protocol = eth_type_trans(skb, ifp->ndev);
  85         brcmf_netif_rx(ifp, skb);
  86  }
  87