target/linux/ipq806x/patches/0031-pinctrl-msm-Remove-impossible-WARN_ON-s.patch

   1 From 286113578287b9c7619b4104864cffb91820f49d Mon Sep 17 00:00:00 2001
   2 From: Stephen Boyd <sboyd@codeaurora.org>
   3 Date: Thu, 6 Mar 2014 22:44:45 -0800
   4 Subject: [PATCH 031/182] pinctrl: msm: Remove impossible WARN_ON()s
   5
   6 All these functions are limited in what they can pass as the gpio
   7 or irq number to whatever is setup during probe. Remove the
   8 checks.
   9
  10 Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
  11 Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
  12 Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  13 ---
  14  drivers/pinctrl/pinctrl-msm.c |   16 ----------------
  15  1 file changed, 16 deletions(-)
  16
  17 --- a/drivers/pinctrl/pinctrl-msm.c
  18 +++ b/drivers/pinctrl/pinctrl-msm.c
  19 @@ -401,8 +401,6 @@ static int msm_gpio_direction_input(stru
  20         u32 val;
  21
  22         g = &pctrl->soc->groups[offset];
  23 -       if (WARN_ON(g->io_reg < 0))
  24 -               return -EINVAL;
  25
  26         spin_lock_irqsave(&pctrl->lock, flags);
  27
  28 @@ -423,8 +421,6 @@ static int msm_gpio_direction_output(str
  29         u32 val;
  30
  31         g = &pctrl->soc->groups[offset];
  32 -       if (WARN_ON(g->io_reg < 0))
  33 -               return -EINVAL;
  34
  35         spin_lock_irqsave(&pctrl->lock, flags);
  36
  37 @@ -451,8 +447,6 @@ static int msm_gpio_get(struct gpio_chip
  38         u32 val;
  39
  40         g = &pctrl->soc->groups[offset];
  41 -       if (WARN_ON(g->io_reg < 0))
  42 -               return -EINVAL;
  43
  44         val = readl(pctrl->regs + g->io_reg);
  45         return !!(val & BIT(g->in_bit));
  46 @@ -466,8 +460,6 @@ static void msm_gpio_set(struct gpio_chi
  47         u32 val;
  48
  49         g = &pctrl->soc->groups[offset];
  50 -       if (WARN_ON(g->io_reg < 0))
  51 -               return;
  52
  53         spin_lock_irqsave(&pctrl->lock, flags);
  54
  55 @@ -616,8 +608,6 @@ static void msm_gpio_irq_mask(struct irq
  56
  57         pctrl = irq_data_get_irq_chip_data(d);
  58         g = &pctrl->soc->groups[d->hwirq];
  59 -       if (WARN_ON(g->intr_cfg_reg < 0))
  60 -               return;
  61
  62         spin_lock_irqsave(&pctrl->lock, flags);
  63
  64 @@ -639,8 +629,6 @@ static void msm_gpio_irq_unmask(struct i
  65
  66         pctrl = irq_data_get_irq_chip_data(d);
  67         g = &pctrl->soc->groups[d->hwirq];
  68 -       if (WARN_ON(g->intr_status_reg < 0))
  69 -               return;
  70
  71         spin_lock_irqsave(&pctrl->lock, flags);
  72
  73 @@ -666,8 +654,6 @@ static void msm_gpio_irq_ack(struct irq_
  74
  75         pctrl = irq_data_get_irq_chip_data(d);
  76         g = &pctrl->soc->groups[d->hwirq];
  77 -       if (WARN_ON(g->intr_status_reg < 0))
  78 -               return;
  79
  80         spin_lock_irqsave(&pctrl->lock, flags);
  81
  82 @@ -692,8 +678,6 @@ static int msm_gpio_irq_set_type(struct
  83
  84         pctrl = irq_data_get_irq_chip_data(d);
  85         g = &pctrl->soc->groups[d->hwirq];
  86 -       if (WARN_ON(g->intr_cfg_reg < 0))
  87 -               return -EINVAL;
  88
  89         spin_lock_irqsave(&pctrl->lock, flags);
  90