[package] uhttpd: do not dispatch pipe error events, fixes use after free for cgi...

[openwrt/svn-archive/archive.git] / package / uhttpd / src / uhttpd.c

diff --git a/package/uhttpd/src/uhttpd.c b/package/uhttpd/src/uhttpd.c
index 73f6e03bd47c980dfd1c46db03c288d96f280abb..3237fbab5794d4a71d079a50e422c50cca758f05 100644 (file)
--- a/package/uhttpd/src/uhttpd.c
+++ b/package/uhttpd/src/uhttpd.c
@@ -573,9 +573,13 @@ static void uh_pipe_cb(struct uloop_fd *u, unsigned int events)
 {
        struct client *cl = container_of(u, struct client, pipe);
 
-       D("SRV: Client(%d) pipe(%d) readable\n", cl->fd.fd, cl->pipe.fd);
+       if (!u->error)
+       {
+               D("SRV: Client(%d) pipe(%d) readable\n",
+                 cl->fd.fd, cl->pipe.fd);
 
-       uh_client_cb(&cl->fd, ULOOP_WRITE);
+               uh_client_cb(&cl->fd, ULOOP_WRITE);
+       }
 }
 
 static void uh_child_cb(struct uloop_process *p, int rv)