deptest: Add sanity check to avoid trouble with illegal package names

[openwrt/svn-archive/archive.git] / scripts / deptest.sh

diff --git a/scripts/deptest.sh b/scripts/deptest.sh
index b82ac465874271c7639348312029dc103eb8a5d3..762821a39cb078a278c55f88fd24f95af532683e 100755 (executable)
--- a/scripts/deptest.sh
+++ b/scripts/deptest.sh
@@ -1,42 +1,59 @@
 #!/bin/bash
+#
+# Automated OpenWrt package dependency checker
+#
+# Copyright (C) 2009-2010 OpenWrt.org
+#
+# This is free software, licensed under the GNU General Public License v2.
+# See /LICENSE for more information.
+#
+# Usage:
+#   No commandline arguments => check dependencies of all installed packages
+#   Package name(s) as arguments => only test the specified packages
+#
 
-DIR="$PWD/tmp/deptest"
+SCRIPTDIR="$(dirname "$0")"
+[ "${SCRIPTDIR:0:1}" = "/" ] || SCRIPTDIR="$PWD/$SCRIPTDIR"
+BASEDIR="$SCRIPTDIR/.."
+
+DIR="$BASEDIR/tmp/deptest"
 STAMP_DIR_SUCCESS="$DIR/stamp-success"
 STAMP_DIR_FAILED="$DIR/stamp-failed"
-BUILD_DIR="$DIR/build"
-BUILD_DIR_HOST="$DIR/build_host"
-STAGING_DIR="$DIR/staging"
-STAGING_DIR_HOST="$DIR/staging_host"
-STAGING_DIR_HOST_TMPL="$DIR/staging_host_tmpl"
+STAMP_DIR_BLACKLIST="$DIR/stamp-blacklist"
+BUILD_DIR="$DIR/build_dir/target"
+BUILD_DIR_HOST="$DIR/build_dir/host"
+STAGING_DIR="$DIR/staging_dir"
+STAGING_DIR_HOST="$DIR/staging_dir_host"
+STAGING_DIR_HOST_TMPL="$DIR/staging_dir_host_tmpl"
 LOG_DIR="$DIR/logs"
 
-mkdir -p "$STAMP_DIR_SUCCESS" "$STAMP_DIR_FAILED" "$BUILD_DIR" "$LOG_DIR"
-
 die()
 {
        echo "$@"
        exit 1
 }
 
-[ -d "$STAGING_DIR_HOST_TMPL" ] || {
-       rm -rf staging_dir/host
-       make tools/install V=99 || die "make tools/install failed, please check"
-       cp -al staging_dir/host "$STAGING_DIR_HOST_TMPL"
-       make toolchain/install V=99 || die "make toolchain/install failed, please check"
-}
-
-for pkg in `cat tmp/.packagedeps  | grep CONFIG_PACKAGE | grep -v curdir | sed -e 's,.*[/=]\s*,,' | sort -u`; do
-       SELECTED=
+test_package() # $1=pkgname
+{
+       local pkg="$1"
+       [ -z "$(echo "$pkg" | grep -e '/')" -a "$pkg" != "." -a "$pkg" != ".." ] || \
+               die "Package name \"$pkg\" contains illegal characters"
+       local SELECTED=
        for conf in `grep CONFIG_PACKAGE tmp/.packagedeps | grep -E "[ /]$pkg\$" | sed -e 's,package-$(\(CONFIG_PACKAGE_.*\)).*,\1,'`; do
-               grep "$conf=" .config > /dev/null && SELECTED=1
+               grep "$conf=" .config > /dev/null && SELECTED=1 && break
        done
-       STAMP_SUCCESS="$STAMP_DIR_SUCCESS/$pkg"
-       STAMP_FAILED="$STAMP_DIR_FAILED/$pkg"
+       local STAMP_SUCCESS="$STAMP_DIR_SUCCESS/$pkg"
+       local STAMP_FAILED="$STAMP_DIR_FAILED/$pkg"
+       local STAMP_BLACKLIST="$STAMP_DIR_BLACKLIST/$pkg"
        rm -f "$STAMP_FAILED"
-       [ -f "$STAMP_SUCCESS" ] && continue
+       [ -f "$STAMP_SUCCESS" ] && return
        [ -n "$SELECTED" ] || {
                echo "Package $pkg is not selected"
-               continue
+               return
+       }
+       [ -f "$STAMP_BLACKLIST" ] && {
+               echo "Package $pkg is blacklisted"
+               return
        }
        echo "Testing package $pkg..."
        rm -rf "$STAGING_DIR"
@@ -55,4 +72,34 @@ for pkg in `cat tmp/.packagedeps  | grep CONFIG_PACKAGE | grep -v curdir | sed -
                touch "$STAMP_FAILED"
                echo "Building package $pkg failed!"
        fi
-done
+}
+
+[ -f "$BASEDIR/include/toplevel.mk" ] || \
+       die "Error: Could not find buildsystem base directory"
+[ -f "$BASEDIR/.config" ] || \
+       die "The buildsystem is not configured. Please run make menuconfig."
+cd "$BASEDIR" || die "Failed to enter base directory"
+
+mkdir -p "$STAMP_DIR_SUCCESS" "$STAMP_DIR_FAILED" "$STAMP_DIR_BLACKLIST" \
+       "$BUILD_DIR" "$BUILD_DIR_HOST" "$LOG_DIR"
+
+[ -d "$STAGING_DIR_HOST_TMPL" ] || {
+       rm -rf staging_dir/host
+       make tools/install V=99 || die "make tools/install failed, please check"
+       cp -al staging_dir/host "$STAGING_DIR_HOST_TMPL"
+       make toolchain/install V=99 || die "make toolchain/install failed, please check"
+       make target/linux/install V=99 || die "make target/linux/install failed, please check"
+}
+
+if [ $# -eq 0 ]; then
+       # iterate over all packages
+       for pkg in `cat tmp/.packagedeps  | grep CONFIG_PACKAGE | grep -v curdir | sed -e 's,.*[/=]\s*,,' | sort -u`; do
+               test_package "$pkg"
+       done
+else
+       # Only check the specified packages
+       while [ $# -ne 0 ]; do
+               test_package "$1"
+               shift
+       done
+fi