#define MAX_VLANS 16
#define MAX_PORTS 9
+#undef DUMP_MII_IO
typedef struct ip175c_reg {
u16 p; // phy
.ADD_TAG_REG = {0,23},
.REMOVE_TAG_REG = {0,23},
- .ADD_TAG_BIT = {11,12,13,14,15,1,-1,-1,-1},
- .REMOVE_TAG_BIT = {6,7,8,9,10,0,-1,-1,-1},
+ .ADD_TAG_BIT = {11,12,13,14,15,-1,-1,-1,-1},
+ .REMOVE_TAG_BIT = {6,7,8,9,10,-1,-1,-1,-1},
- .SIMPLE_VLAN_REGISTERS = 1,
+ .SIMPLE_VLAN_REGISTERS = 0,
+
+ // Register 19-21 documentation is missing/contradictory.
+ // For registers 19-21 ports need to be: even numbers to MSB, odd to LSB.
+ // This contradicts text for ROM registers, but follows logic of CoS bits.
- // Only programmable via. EEPROM
- .VLAN_LOOKUP_REG = NOTSUPPORTED,// +N/2
+ .VLAN_LOOKUP_REG = {0,19},// +N/2
.VLAN_LOOKUP_REG_5 = NOTSUPPORTED,
- .VLAN_LOOKUP_EVEN_BIT = {8,9,10,11,12,15,-1,-1,-1},
- .VLAN_LOOKUP_ODD_BIT = {0,1,2,3,4,7,-1,-1,-1},
+ .VLAN_LOOKUP_EVEN_BIT = {8,9,10,11,12,-1,-1,-1,-1},
+ .VLAN_LOOKUP_ODD_BIT = {0,1,2,3,4,-1,-1,-1,-1},
- .TAG_VLAN_MASK_REG = NOTSUPPORTED, // +N/2
- .TAG_VLAN_MASK_EVEN_BIT = {0,1,2,3,4,5,-1,-1,-1},
- .TAG_VLAN_MASK_ODD_BIT = {8,9,10,11,12,13,-1,-1,-1},
+ .TAG_VLAN_MASK_REG = NOTSUPPORTED, // +N/2,
+ .TAG_VLAN_MASK_EVEN_BIT = {-1,-1,-1,-1,-1,-1,-1,-1,-1},
+ .TAG_VLAN_MASK_ODD_BIT = {-1,-1,-1,-1,-1,-1,-1,-1,-1},
.RESET_VAL = -1,
.RESET_REG = NOTSUPPORTED,
.NUMLAN_GROUPS_MAX = -1,
.NUMLAN_GROUPS_BIT = -1, // {0-2}
- .NUM_PORTS = 6,
- .CPU_PORT = 5,
+ .NUM_PORTS = 5,
+ .CPU_PORT = 4,
- .MII_REGISTER_EN = {0, 12},
+ .MII_REGISTER_EN = {0, 18},
.MII_REGISTER_EN_BIT = 7,
};
+
struct ip175c_state {
struct switch_dev dev;
struct mii_bus *mii_bus;
char buf[80];
};
-static int ip_phy_read(struct mii_bus *bus, int port, int reg)
+static int ip_phy_read(struct ip175c_state *state, int port, int reg)
{
- int val;
-
- mutex_lock(&bus->mdio_lock);
- val = bus->read(bus, port, reg);
- mutex_unlock(&bus->mdio_lock);
-
+ int val = mdiobus_read(state->mii_bus, port, reg);
+ if (val < 0)
+ pr_warning("IP175C: Unable to get MII register %d,%d: error %d\n", port, reg, -val);
+#ifdef DUMP_MII_IO
+ else
+ pr_debug("IP175C: Read MII(%d,%d) -> %04x\n", port, reg, val);
+#endif
return val;
}
-static int ip_phy_write(struct mii_bus *bus, int port, int reg, u16 val)
+static int ip_phy_write(struct ip175c_state *state, int port, int reg, u16 val)
{
int err;
- mutex_lock(&bus->mdio_lock);
- err = bus->write(bus, port, reg, val);
- mutex_unlock(&bus->mdio_lock);
-
+#ifdef DUMP_MII_IO
+ pr_debug("IP175C: Write MII(%d,%d) <- %04x\n", port, reg, val);
+#endif
+ err = mdiobus_write(state->mii_bus, port, reg, val);
+ if (err < 0)
+ pr_warning("IP175C: Unable to write MII register %d,%d: error %d\n", port, reg, -err);
return err;
}
-static int getPhy (struct ip175c_state *state, reg mii)
+static int ip_phy_write_masked(struct ip175c_state *state, int port, int reg, unsigned int mask, unsigned int data)
{
- struct mii_bus *bus = state->mii_bus;
- int val;
+ int val = ip_phy_read(state, port, reg);
+ if (val < 0)
+ return 0;
+ return ip_phy_write(state, port, reg, (val & ~mask) | data);
+}
+static int getPhy(struct ip175c_state *state, reg mii)
+{
if (!REG_SUPP(mii))
return -EFAULT;
-
- val = ip_phy_read(bus, mii.p, mii.m);
- if (val < 0)
- pr_warning("IP175C: Unable to get MII register %d,%d: error %d\n", mii.p,mii.m,-val);
-
- return val;
+ return ip_phy_read(state, mii.p, mii.m);
}
-static int setPhy (struct ip175c_state *state, reg mii, u16 value)
+static int setPhy(struct ip175c_state *state, reg mii, u16 value)
{
- struct mii_bus *bus = state->mii_bus;
int err;
if (!REG_SUPP(mii))
return -EFAULT;
-
- err = ip_phy_write(bus, mii.p, mii.m, value);
- if (err < 0) {
- pr_warning("IP175C: Unable to set MII register %d,%d to %d: error %d\n", mii.p,mii.m,value,-err);
+ err = ip_phy_write(state, mii.p, mii.m, value);
+ if (err < 0)
return err;
- }
- mdelay(2);
getPhy(state, mii);
return 0;
}
if (state->vlan_enabled == -1) {
// not sure how to get this...
- state->vlan_enabled = (!state->remove_tag && !state->add_tag);
+ state->vlan_enabled = (state->remove_tag || state->add_tag);
}
if (REG_SUPP(state->regs->VLAN_LOOKUP_REG)) {
return 0;
}
-static int ip175c_reset(struct switch_dev *dev, const struct switch_attr *attr, struct switch_val *val)
+static int ip175c_reset(struct switch_dev *dev)
{
struct ip175c_state *state = dev->priv;
int i, err;
}
/* reset switch ports */
- for (i = 0; i < 5; i++) {
- err = state->mii_bus->write(state->mii_bus, i,
- MII_BMCR, BMCR_RESET);
+ for (i = 0; i < state->regs->NUM_PORTS-1; i++) {
+ err = ip_phy_write(state, i, MII_BMCR, BMCR_RESET);
if (err < 0)
return err;
}
static int ip175c_set_port_speed(struct switch_dev *dev, const struct switch_attr *attr, struct switch_val *val)
{
struct ip175c_state *state = dev->priv;
- struct mii_bus *bus = state->mii_bus;
int nr = val->port_vlan;
int ctrl;
int autoneg;
if (nr >= dev->ports || nr < 0)
return -EINVAL;
- ctrl = ip_phy_read(bus, nr, 0);
+ ctrl = ip_phy_read(state, nr, 0);
if (ctrl < 0)
return -EIO;
ctrl |= (autoneg<<12);
ctrl |= (speed<<13);
- return ip_phy_write(bus, nr, 0, ctrl);
+ return ip_phy_write(state, nr, 0, ctrl);
}
static int ip175c_get_port_speed(struct switch_dev *dev, const struct switch_attr *attr, struct switch_val *val)
{
struct ip175c_state *state = dev->priv;
- struct mii_bus *bus = state->mii_bus;
int nr = val->port_vlan;
int speed, status;
if (nr >= dev->ports || nr < 0)
return -EINVAL;
- status = ip_phy_read(bus, nr, 1);
- speed = ip_phy_read(bus, nr, 18);
+ status = ip_phy_read(state, nr, 1);
+ speed = ip_phy_read(state, nr, 18);
if (status < 0 || speed < 0)
return -EIO;
static int ip175c_get_port_status(struct switch_dev *dev, const struct switch_attr *attr, struct switch_val *val)
{
struct ip175c_state *state = dev->priv;
- struct mii_bus *bus = state->mii_bus;
int ctrl, speed, status;
int nr = val->port_vlan;
int len;
if (nr >= dev->ports || nr < 0)
return -EINVAL;
- ctrl = ip_phy_read(bus, nr, 0);
- status = ip_phy_read(bus, nr, 1);
- speed = ip_phy_read(bus, nr, 18);
+ ctrl = ip_phy_read(state, nr, 0);
+ status = ip_phy_read(state, nr, 1);
+ speed = ip_phy_read(state, nr, 18);
if (ctrl < 0 || status < 0 || speed < 0)
return -EIO;
};
enum Globals {
- IP175C_RESET,
IP175C_ENABLE_VLAN,
IP175C_GET_NAME,
IP175C_REGISTER_PHY,
};
static const struct switch_attr ip175c_global[] = {
- [IP175C_RESET] = {
- .id = IP175C_RESET,
- .type = SWITCH_TYPE_NOVAL,
- .name = "reset",
- .get = NULL,
- .description = "Resets the switch but does not clear vlan configuration",
- .set = ip175c_reset,
- },
[IP175C_ENABLE_VLAN] = {
.id = IP175C_ENABLE_VLAN,
.type = SWITCH_TYPE_INT,
dev->get_vlan_ports = ip175c_get_ports;
dev->set_vlan_ports = ip175c_set_ports;
dev->apply_config = ip175c_apply;
+ dev->reset_switch = ip175c_reset;
dev->priv = state;
pdev->priv = state;
if (err < 0)
return err;
- ip175c_reset(&state->dev, NULL, NULL);
+ ip175c_reset(&state->dev);
state->registered = true;
netif_carrier_on(pdev->attached_dev);
.driver = { .owner = THIS_MODULE },
};
+static struct phy_driver ip175a_driver = {
+ .name = "IC+ IP175A",
+ .phy_id = 0x02430c50,
+ .phy_id_mask = 0x0ffffff0,
+ .features = PHY_BASIC_FEATURES,
+ .probe = ip175c_probe,
+ .remove = ip175c_remove,
+ .config_init = ip175c_config_init,
+ .config_aneg = ip175c_config_aneg,
+ .read_status = ip175c_read_status,
+ .driver = { .owner = THIS_MODULE },
+};
+
int __init ip175c_init(void)
{
+ int ret;
+
+ ret = phy_driver_register(&ip175a_driver);
+ if (ret < 0)
+ return ret;
+
return phy_driver_register(&ip175c_driver);
}
void __exit ip175c_exit(void)
{
phy_driver_unregister(&ip175c_driver);
+ phy_driver_unregister(&ip175a_driver);
}
MODULE_AUTHOR("Patrick Horn <patrick.horn@gmail.com>");
projects / openwrt / svn-archive / archive.git / blobdiff