generic: rtl8366: cleanup MIB counter printing
[openwrt/svn-archive/archive.git] / target / linux / generic-2.6 / files / drivers / net / phy / rtl8366rb.c
index 8bf0046fcda4e0123d4ce1a703bceea65cc15b2a..eaff759b3f7e51c2eb39df65df9d25c44288895f 100644 (file)
@@ -186,39 +186,39 @@ struct mib_counter {
 };
 
 static struct mib_counter rtl8366rb_mib_counters[RTL8366S_MIB_COUNT] = {
-       {  0, 4, "IfInOctets                        " },
-       {  4, 4, "EtherStatsOctets                  " },
-       {  8, 2, "EtherStatsUnderSizePkts           " },
-       { 10, 2, "EtherFregament                    " },
-       { 12, 2, "EtherStatsPkts64Octets            " },
-       { 14, 2, "EtherStatsPkts65to127Octets       " },
-       { 16, 2, "EtherStatsPkts128to255Octets      " },
-       { 18, 2, "EtherStatsPkts256to511Octets      " },
-       { 20, 2, "EtherStatsPkts512to1023Octets     " },
-       { 22, 2, "EtherStatsPkts1024to1518Octets    " },
-       { 24, 2, "EtherOversizeStats                " },
-       { 26, 2, "EtherStatsJabbers                 " },
-       { 28, 2, "IfInUcastPkts                     " },
-       { 30, 2, "EtherStatsMulticastPkts           " },
-       { 32, 2, "EtherStatsBroadcastPkts           " },
-       { 34, 2, "EtherStatsDropEvents              " },
-       { 36, 2, "Dot3StatsFCSErrors                " },
-       { 38, 2, "Dot3StatsSymbolErrors             " },
-       { 40, 2, "Dot3InPauseFrames                 " },
-       { 42, 2, "Dot3ControlInUnknownOpcodes       " },
-       { 44, 4, "IfOutOctets                       " },
-       { 48, 2, "Dot3StatsSingleCollisionFrames    " },
-       { 50, 2, "Dot3StatMultipleCollisionFrames   " },
-       { 52, 2, "Dot3sDeferredTransmissions        " },
-       { 54, 2, "Dot3StatsLateCollisions           " },
-       { 56, 2, "EtherStatsCollisions              " },
-       { 58, 2, "Dot3StatsExcessiveCollisions      " },
-       { 60, 2, "Dot3OutPauseFrames                " },
-       { 62, 2, "Dot1dBasePortDelayExceededDiscards" },
-       { 64, 2, "Dot1dTpPortInDiscards             " },
-       { 66, 2, "IfOutUcastPkts                    " },
-       { 68, 2, "IfOutMulticastPkts                " },
-       { 70, 2, "IfOutBroadcastPkts                " },
+       {  0, 4, "IfInOctets"                           },
+       {  4, 4, "EtherStatsOctets"                     },
+       {  8, 2, "EtherStatsUnderSizePkts"              },
+       { 10, 2, "EtherFragments"                       },
+       { 12, 2, "EtherStatsPkts64Octets"               },
+       { 14, 2, "EtherStatsPkts65to127Octets"          },
+       { 16, 2, "EtherStatsPkts128to255Octets"         },
+       { 18, 2, "EtherStatsPkts256to511Octets"         },
+       { 20, 2, "EtherStatsPkts512to1023Octets"        },
+       { 22, 2, "EtherStatsPkts1024to1518Octets"       },
+       { 24, 2, "EtherOversizeStats"                   },
+       { 26, 2, "EtherStatsJabbers"                    },
+       { 28, 2, "IfInUcastPkts"                        },
+       { 30, 2, "EtherStatsMulticastPkts"              },
+       { 32, 2, "EtherStatsBroadcastPkts"              },
+       { 34, 2, "EtherStatsDropEvents"                 },
+       { 36, 2, "Dot3StatsFCSErrors"                   },
+       { 38, 2, "Dot3StatsSymbolErrors"                },
+       { 40, 2, "Dot3InPauseFrames"                    },
+       { 42, 2, "Dot3ControlInUnknownOpcodes"          },
+       { 44, 4, "IfOutOctets"                          },
+       { 48, 2, "Dot3StatsSingleCollisionFrames"       },
+       { 50, 2, "Dot3StatMultipleCollisionFrames"      },
+       { 52, 2, "Dot3sDeferredTransmissions"           },
+       { 54, 2, "Dot3StatsLateCollisions"              },
+       { 56, 2, "EtherStatsCollisions"                 },
+       { 58, 2, "Dot3StatsExcessiveCollisions"         },
+       { 60, 2, "Dot3OutPauseFrames"                   },
+       { 62, 2, "Dot1dBasePortDelayExceededDiscards"   },
+       { 64, 2, "Dot1dTpPortInDiscards"                },
+       { 66, 2, "IfOutUcastPkts"                       },
+       { 68, 2, "IfOutMulticastPkts"                   },
+       { 70, 2, "IfOutBroadcastPkts"                   },
 };
 
 static inline struct rtl8366rb *smi_to_rtl8366rb(struct rtl8366_smi *smi)
@@ -231,9 +231,14 @@ static inline struct rtl8366rb *sw_to_rtl8366rb(struct switch_dev *sw)
        return container_of(sw, struct rtl8366rb, dev);
 }
 
-static int rtl8366rb_reset_chip(struct rtl8366rb *rtl)
+static inline struct rtl8366_smi *sw_to_rtl8366_smi(struct switch_dev *sw)
+{
+       struct rtl8366rb *rtl = sw_to_rtl8366rb(sw);
+       return &rtl->smi;
+}
+
+static int rtl8366rb_reset_chip(struct rtl8366_smi *smi)
 {
-       struct rtl8366_smi *smi = &rtl->smi;
        int timeout = 10;
        u32 data;
 
@@ -322,10 +327,9 @@ static int rtl8366rb_write_phy_reg(struct rtl8366_smi *smi,
        return 0;
 }
 
-static int rtl8366_get_mib_counter(struct rtl8366rb *rtl, int counter,
+static int rtl8366_get_mib_counter(struct rtl8366_smi *smi, int counter,
                                   int port, unsigned long long *val)
 {
-       struct rtl8366_smi *smi = &rtl->smi;
        int i;
        int err;
        u32 addr, data;
@@ -371,21 +375,21 @@ static int rtl8366_get_mib_counter(struct rtl8366rb *rtl, int counter,
        return 0;
 }
 
-static int rtl8366rb_get_vlan_4k(struct rtl8366rb *rtl, u32 vid,
-                                struct rtl8366rb_vlan_4k *vlan4k)
+static int rtl8366rb_get_vlan_4k(struct rtl8366_smi *smi, u32 vid,
+                                struct rtl8366_vlan_4k *vlan4k)
 {
-       struct rtl8366_smi *smi = &rtl->smi;
+       struct rtl8366rb_vlan_4k vlan4k_priv;
        int err;
        u32 data;
        u16 *tableaddr;
 
-       memset(vlan4k, '\0', sizeof(struct rtl8366rb_vlan_4k));
-       vlan4k->vid = vid;
+       memset(vlan4k, '\0', sizeof(struct rtl8366_vlan_4k));
+       vlan4k_priv.vid = vid;
 
        if (vid >= RTL8366_NUM_VIDS)
                return -EINVAL;
 
-       tableaddr = (u16 *)vlan4k;
+       tableaddr = (u16 *)&vlan4k_priv;
 
        /* write VID */
        data = *tableaddr;
@@ -419,15 +423,19 @@ static int rtl8366rb_get_vlan_4k(struct rtl8366rb *rtl, u32 vid,
        if (err)
                return err;
        *tableaddr = data;
+
        vlan4k->vid = vid;
+       vlan4k->untag = vlan4k_priv.untag;
+       vlan4k->member = vlan4k_priv.member;
+       vlan4k->fid = vlan4k_priv.fid;
 
        return 0;
 }
 
-static int rtl8366rb_set_vlan_4k(struct rtl8366rb *rtl,
-                                const struct rtl8366rb_vlan_4k *vlan4k)
+static int rtl8366rb_set_vlan_4k(struct rtl8366_smi *smi,
+                                const struct rtl8366_vlan_4k *vlan4k)
 {
-       struct rtl8366_smi *smi = &rtl->smi;
+       struct rtl8366rb_vlan_4k vlan4k_priv;
        int err;
        u32 data;
        u16 *tableaddr;
@@ -438,7 +446,12 @@ static int rtl8366rb_set_vlan_4k(struct rtl8366rb *rtl,
            vlan4k->fid > RTL8366S_FIDMAX)
                return -EINVAL;
 
-       tableaddr = (u16 *)vlan4k;
+       vlan4k_priv.vid = vlan4k->vid;
+       vlan4k_priv.untag = vlan4k->untag;
+       vlan4k_priv.member = vlan4k->member;
+       vlan4k_priv.fid = vlan4k->fid;
+
+       tableaddr = (u16 *)&vlan4k_priv;
 
        data = *tableaddr;
 
@@ -471,10 +484,9 @@ static int rtl8366rb_set_vlan_4k(struct rtl8366rb *rtl,
        return err;
 }
 
-static int rtl8366rb_get_vlan_mc(struct rtl8366rb *rtl, u32 index,
+static int rtl8366rb_get_vlan_mc(struct rtl8366_smi *smi, u32 index,
                                 struct rtl8366_vlan_mc *vlanmc)
 {
-       struct rtl8366_smi *smi = &rtl->smi;
        struct rtl8366rb_vlan_mc vlanmc_priv;
        int err;
        u32 addr;
@@ -520,10 +532,9 @@ static int rtl8366rb_get_vlan_mc(struct rtl8366rb *rtl, u32 index,
        return 0;
 }
 
-static int rtl8366rb_set_vlan_mc(struct rtl8366rb *rtl, u32 index,
+static int rtl8366rb_set_vlan_mc(struct rtl8366_smi *smi, u32 index,
                                 const struct rtl8366_vlan_mc *vlanmc)
 {
-       struct rtl8366_smi *smi = &rtl->smi;
        struct rtl8366rb_vlan_mc vlanmc_priv;
        int err;
        u32 addr;
@@ -575,10 +586,9 @@ static int rtl8366rb_set_vlan_mc(struct rtl8366rb *rtl, u32 index,
        return 0;
 }
 
-static int rtl8366rb_get_port_vlan_index(struct rtl8366rb *rtl, int port,
+static int rtl8366rb_get_port_vlan_index(struct rtl8366_smi *smi, int port,
                                       int *val)
 {
-       struct rtl8366_smi *smi = &rtl->smi;
        u32 data;
        int err;
 
@@ -597,18 +607,18 @@ static int rtl8366rb_get_port_vlan_index(struct rtl8366rb *rtl, int port,
 
 }
 
-static int rtl8366rb_get_vlan_port_pvid(struct rtl8366rb *rtl, int port,
+static int rtl8366rb_get_vlan_port_pvid(struct rtl8366_smi *smi, int port,
                                       int *val)
 {
        struct rtl8366_vlan_mc vlanmc;
        int err;
        int index;
 
-       err = rtl8366rb_get_port_vlan_index(rtl, port, &index);
+       err = rtl8366rb_get_port_vlan_index(smi, port, &index);
        if (err)
                return err;
 
-       err = rtl8366rb_get_vlan_mc(rtl, index, &vlanmc);
+       err = rtl8366rb_get_vlan_mc(smi, index, &vlanmc);
        if (err)
                return err;
 
@@ -616,10 +626,9 @@ static int rtl8366rb_get_vlan_port_pvid(struct rtl8366rb *rtl, int port,
        return 0;
 }
 
-static int rtl8366rb_set_port_vlan_index(struct rtl8366rb *rtl, int port,
+static int rtl8366rb_set_port_vlan_index(struct rtl8366_smi *smi, int port,
                                        int index)
 {
-       struct rtl8366_smi *smi = &rtl->smi;
        u32 data;
        int err;
 
@@ -641,35 +650,36 @@ static int rtl8366rb_set_port_vlan_index(struct rtl8366rb *rtl, int port,
        return err;
 }
 
-static int rtl8366rb_set_vlan_port_pvid(struct rtl8366rb *rtl, int port, int val)
+static int rtl8366rb_set_vlan_port_pvid(struct rtl8366_smi *smi, int port,
+                                       int val)
 {
        int i;
        struct rtl8366_vlan_mc vlanmc;
-       struct rtl8366rb_vlan_4k vlan4k;
+       struct rtl8366_vlan_4k vlan4k;
 
        if (port >= RTL8366_NUM_PORTS || val >= RTL8366_NUM_VIDS)
                return -EINVAL;
 
        /* Updating the 4K entry; lookup it and change the port member set */
-       rtl8366rb_get_vlan_4k(rtl, val, &vlan4k);
+       rtl8366rb_get_vlan_4k(smi, val, &vlan4k);
        vlan4k.member |= ((1 << port) | RTL8366_PORT_CPU);
        vlan4k.untag = RTL8366_PORT_ALL_BUT_CPU;
-       rtl8366rb_set_vlan_4k(rtl, &vlan4k);
+       rtl8366rb_set_vlan_4k(smi, &vlan4k);
 
        /*
         * For the 16 entries more work needs to be done. First see if such
         * VID is already there and change it
         */
        for (i = 0; i < RTL8366_NUM_VLANS; ++i) {
-               rtl8366rb_get_vlan_mc(rtl, i, &vlanmc);
+               rtl8366rb_get_vlan_mc(smi, i, &vlanmc);
 
                /* Try to find an existing vid and update port member set */
                if (val == vlanmc.vid) {
                        vlanmc.member |= ((1 << port) | RTL8366_PORT_CPU);
-                       rtl8366rb_set_vlan_mc(rtl, i, &vlanmc);
+                       rtl8366rb_set_vlan_mc(smi, i, &vlanmc);
 
                        /* Now update PVID register settings */
-                       rtl8366rb_set_port_vlan_index(rtl, port, i);
+                       rtl8366rb_set_port_vlan_index(smi, port, i);
 
                        return 0;
                }
@@ -680,7 +690,7 @@ static int rtl8366rb_set_vlan_port_pvid(struct rtl8366rb *rtl, int port, int val
         * has no member ports) with new one
         */
        for (i = 0; i < RTL8366_NUM_VLANS; ++i) {
-               rtl8366rb_get_vlan_mc(rtl, i, &vlanmc);
+               rtl8366rb_get_vlan_mc(smi, i, &vlanmc);
 
                /*
                 * See if this vlan member configuration is unused. It is
@@ -693,25 +703,24 @@ static int rtl8366rb_set_vlan_port_pvid(struct rtl8366rb *rtl, int port, int val
                        vlanmc.member = ((1 << port) | RTL8366_PORT_CPU);
                        vlanmc.fid = 0;
 
-                       rtl8366rb_set_vlan_mc(rtl, i, &vlanmc);
+                       rtl8366rb_set_vlan_mc(smi, i, &vlanmc);
 
                        /* Now update PVID register settings */
-                       rtl8366rb_set_port_vlan_index(rtl, port, i);
+                       rtl8366rb_set_port_vlan_index(smi, port, i);
 
                        return 0;
                }
        }
 
-       dev_err(rtl->parent,
+       dev_err(smi->parent,
                "All 16 vlan member configurations are in use\n");
 
        return -EINVAL;
 }
 
 
-static int rtl8366rb_vlan_set_vlan(struct rtl8366rb *rtl, int enable)
+static int rtl8366rb_vlan_set_vlan(struct rtl8366_smi *smi, int enable)
 {
-       struct rtl8366_smi *smi = &rtl->smi;
        u32 data = 0;
 
        rtl8366_smi_read_reg(smi, RTL8366_CHIP_GLOBAL_CTRL_REG, &data);
@@ -724,9 +733,8 @@ static int rtl8366rb_vlan_set_vlan(struct rtl8366rb *rtl, int enable)
        return rtl8366_smi_write_reg(smi, RTL8366_CHIP_GLOBAL_CTRL_REG, data);
 }
 
-static int rtl8366rb_vlan_set_4ktable(struct rtl8366rb *rtl, int enable)
+static int rtl8366rb_vlan_set_4ktable(struct rtl8366_smi *smi, int enable)
 {
-       struct rtl8366_smi *smi = &rtl->smi;
        u32 data = 0;
 
        rtl8366_smi_read_reg(smi, RTL8366_CHIP_GLOBAL_CTRL_REG, &data);
@@ -739,9 +747,9 @@ static int rtl8366rb_vlan_set_4ktable(struct rtl8366rb *rtl, int enable)
        return rtl8366_smi_write_reg(smi, RTL8366_CHIP_GLOBAL_CTRL_REG, data);
 }
 
-static int rtl8366rb_reset_vlan(struct rtl8366rb *rtl)
+static int rtl8366rb_reset_vlan(struct rtl8366_smi *smi)
 {
-       struct rtl8366rb_vlan_4k vlan4k;
+       struct rtl8366_vlan_4k vlan4k;
        struct rtl8366_vlan_mc vlanmc;
        int err;
        int i;
@@ -753,7 +761,7 @@ static int rtl8366rb_reset_vlan(struct rtl8366rb *rtl)
        vlanmc.untag = 0;
        vlanmc.fid = 0;
        for (i = 0; i < RTL8366_NUM_VLANS; i++) {
-               err = rtl8366rb_set_vlan_mc(rtl, i, &vlanmc);
+               err = rtl8366rb_set_vlan_mc(smi, i, &vlanmc);
                if (err)
                        return err;
        }
@@ -763,13 +771,13 @@ static int rtl8366rb_reset_vlan(struct rtl8366rb *rtl)
        vlan4k.member = RTL8366_PORT_ALL;
        vlan4k.untag = RTL8366_PORT_ALL;
        vlan4k.fid = 0;
-       err = rtl8366rb_set_vlan_4k(rtl, &vlan4k);
+       err = rtl8366rb_set_vlan_4k(smi, &vlan4k);
        if (err)
                return err;
 
        /* Set all ports PVID to default VLAN */
        for (i = 0; i < RTL8366_NUM_PORTS; i++) {
-               err = rtl8366rb_set_vlan_port_pvid(rtl, i, 0);
+               err = rtl8366rb_set_vlan_port_pvid(smi, i, 0);
                if (err)
                        return err;
        }
@@ -789,46 +797,34 @@ static ssize_t rtl8366rb_read_debugfs_mibs(struct file *file,
                                          size_t count, loff_t *ppos)
 {
        struct rtl8366rb *rtl = (struct rtl8366rb *)file->private_data;
+       struct rtl8366_smi *smi = &rtl->smi;
        int i, j, len = 0;
        char *buf = rtl->buf;
 
-       len += snprintf(buf + len, sizeof(rtl->buf) - len, "MIB Counters:\n");
-       len += snprintf(buf + len, sizeof(rtl->buf) - len, "Counter"
-                       "                            "
-                       "Port 0 \t\t Port 1 \t\t Port 2 \t\t Port 3 \t\t "
-                       "Port 4\n");
-
-       for (i = 0; i < 33; ++i) {
-               len += snprintf(buf + len, sizeof(rtl->buf) - len, "%d:%s ",
-                               i, rtl8366rb_mib_counters[i].name);
+       len += snprintf(buf + len, sizeof(rtl->buf) - len,
+                       "%-36s %12s %12s %12s %12s %12s %12s\n",
+                       "Counter",
+                       "Port 0", "Port 1", "Port 2",
+                       "Port 3", "Port 4", "Port 5");
+
+       for (i = 0; i < ARRAY_SIZE(rtl8366rb_mib_counters); ++i) {
+               len += snprintf(buf + len, sizeof(rtl->buf) - len, "%-36s ",
+                               rtl8366rb_mib_counters[i].name);
                for (j = 0; j < RTL8366_NUM_PORTS; ++j) {
                        unsigned long long counter = 0;
 
-                       if (!rtl8366_get_mib_counter(rtl, i, j, &counter))
+                       if (!rtl8366_get_mib_counter(smi, i, j, &counter))
                                len += snprintf(buf + len,
                                                sizeof(rtl->buf) - len,
-                                               "[%llu]", counter);
+                                               "%12llu ", counter);
                        else
                                len += snprintf(buf + len,
                                                sizeof(rtl->buf) - len,
-                                               "[error]");
-
-                       if (j != RTL8366_NUM_PORTS - 1) {
-                               if (counter < 100000)
-                                       len += snprintf(buf + len,
-                                                       sizeof(rtl->buf) - len,
-                                                       "\t");
-
-                               len += snprintf(buf + len,
-                                               sizeof(rtl->buf) - len,
-                                               "\t");
-                       }
+                                               "%12s ", "error");
                }
                len += snprintf(buf + len, sizeof(rtl->buf) - len, "\n");
        }
 
-       len += snprintf(buf + len, sizeof(rtl->buf) - len, "\n");
-
        return simple_read_from_buffer(user_buf, count, ppos, buf, len);
 }
 
@@ -837,6 +833,7 @@ static ssize_t rtl8366rb_read_debugfs_vlan(struct file *file,
                                          size_t count, loff_t *ppos)
 {
        struct rtl8366rb *rtl = (struct rtl8366rb *)file->private_data;
+       struct rtl8366_smi *smi = &rtl->smi;
        int i, j, len = 0;
        char *buf = rtl->buf;
 
@@ -849,7 +846,7 @@ static ssize_t rtl8366rb_read_debugfs_vlan(struct file *file,
        for (i = 0; i < RTL8366_NUM_VLANS; ++i) {
                struct rtl8366_vlan_mc vlanmc;
 
-               rtl8366rb_get_vlan_mc(rtl, i, &vlanmc);
+               rtl8366rb_get_vlan_mc(smi, i, &vlanmc);
 
                len += snprintf(buf + len, sizeof(rtl->buf) - len,
                                "\t[%d] \t %d \t %d \t 0x%04x \t 0x%04x \t %d "
@@ -858,7 +855,7 @@ static ssize_t rtl8366rb_read_debugfs_vlan(struct file *file,
 
                for (j = 0; j < RTL8366_NUM_PORTS; ++j) {
                        int index = 0;
-                       if (!rtl8366rb_get_port_vlan_index(rtl, j, &index)) {
+                       if (!rtl8366rb_get_port_vlan_index(smi, j, &index)) {
                                if (index == i)
                                        len += snprintf(buf + len,
                                                        sizeof(rtl->buf) - len,
@@ -1015,8 +1012,7 @@ static int rtl8366rb_sw_reset_mibs(struct switch_dev *dev,
                                  const struct switch_attr *attr,
                                  struct switch_val *val)
 {
-       struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
-       struct rtl8366_smi *smi = &rtl->smi;
+       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
        u32 data = 0;
 
        if (val->value.i == 1) {
@@ -1032,8 +1028,7 @@ static int rtl8366rb_sw_get_vlan_enable(struct switch_dev *dev,
                                       const struct switch_attr *attr,
                                       struct switch_val *val)
 {
-       struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
-       struct rtl8366_smi *smi = &rtl->smi;
+       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
        u32 data;
 
        if (attr->ofs == 1) {
@@ -1059,8 +1054,7 @@ static int rtl8366rb_sw_get_blinkrate(struct switch_dev *dev,
                                     const struct switch_attr *attr,
                                     struct switch_val *val)
 {
-       struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
-       struct rtl8366_smi *smi = &rtl->smi;
+       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
        u32 data;
 
        rtl8366_smi_read_reg(smi, RTL8366_LED_BLINKRATE_REG, &data);
@@ -1074,8 +1068,7 @@ static int rtl8366rb_sw_set_blinkrate(struct switch_dev *dev,
                                    const struct switch_attr *attr,
                                    struct switch_val *val)
 {
-       struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
-       struct rtl8366_smi *smi = &rtl->smi;
+       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
        u32 data;
 
        if (val->value.i >= 6)
@@ -1095,12 +1088,12 @@ static int rtl8366rb_sw_set_vlan_enable(struct switch_dev *dev,
                                       const struct switch_attr *attr,
                                       struct switch_val *val)
 {
-       struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
+       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
 
        if (attr->ofs == 1)
-               return rtl8366rb_vlan_set_vlan(rtl, val->value.i);
+               return rtl8366rb_vlan_set_vlan(smi, val->value.i);
        else
-               return rtl8366rb_vlan_set_4ktable(rtl, val->value.i);
+               return rtl8366rb_vlan_set_4ktable(smi, val->value.i);
 }
 
 static const char *rtl8366rb_speed_str(unsigned speed)
@@ -1167,8 +1160,9 @@ static int rtl8366rb_sw_get_vlan_info(struct switch_dev *dev,
        int i;
        u32 len = 0;
        struct rtl8366_vlan_mc vlanmc;
-       struct rtl8366rb_vlan_4k vlan4k;
+       struct rtl8366_vlan_4k vlan4k;
        struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
+       struct rtl8366_smi *smi = &rtl->smi;
        char *buf = rtl->buf;
 
        if (val->port_vlan == 0 || val->port_vlan >= RTL8366_NUM_VLANS)
@@ -1176,15 +1170,15 @@ static int rtl8366rb_sw_get_vlan_info(struct switch_dev *dev,
 
        memset(buf, '\0', sizeof(rtl->buf));
 
-       rtl8366rb_get_vlan_mc(rtl, val->port_vlan, &vlanmc);
-       rtl8366rb_get_vlan_4k(rtl, vlanmc.vid, &vlan4k);
+       rtl8366rb_get_vlan_mc(smi, val->port_vlan, &vlanmc);
+       rtl8366rb_get_vlan_4k(smi, vlanmc.vid, &vlan4k);
 
        len += snprintf(buf + len, sizeof(rtl->buf) - len, "VLAN %d: Ports: ",
                        val->port_vlan);
 
        for (i = 0; i < RTL8366_NUM_PORTS; ++i) {
                int index = 0;
-               if (!rtl8366rb_get_port_vlan_index(rtl, i, &index) &&
+               if (!rtl8366rb_get_port_vlan_index(smi, i, &index) &&
                    index == val->port_vlan)
                        len += snprintf(buf + len, sizeof(rtl->buf) - len,
                                        "%d", i);
@@ -1213,8 +1207,7 @@ static int rtl8366rb_sw_set_port_led(struct switch_dev *dev,
                                    const struct switch_attr *attr,
                                    struct switch_val *val)
 {
-       struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
-       struct rtl8366_smi *smi = &rtl->smi;
+       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
        u32 data = 0;
 
        if (val->port_vlan >= RTL8366_NUM_PORTS)
@@ -1238,8 +1231,7 @@ static int rtl8366rb_sw_get_port_led(struct switch_dev *dev,
                                    const struct switch_attr *attr,
                                    struct switch_val *val)
 {
-       struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
-       struct rtl8366_smi *smi = &rtl->smi;
+       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
        u32 data = 0;
 
        if (val->port_vlan >= RTL8366_NUM_LEDGROUPS)
@@ -1255,8 +1247,7 @@ static int rtl8366rb_sw_reset_port_mibs(struct switch_dev *dev,
                                       const struct switch_attr *attr,
                                       struct switch_val *val)
 {
-       struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
-       struct rtl8366_smi *smi = &rtl->smi;
+       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
        u32 data = 0;
 
        if (val->port_vlan >= RTL8366_NUM_PORTS)
@@ -1274,6 +1265,7 @@ static int rtl8366rb_sw_get_port_mib(struct switch_dev *dev,
                                    struct switch_val *val)
 {
        struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
+       struct rtl8366_smi *smi = &rtl->smi;
        int i, len = 0;
        unsigned long long counter = 0;
        char *buf = rtl->buf;
@@ -1285,15 +1277,15 @@ static int rtl8366rb_sw_get_port_mib(struct switch_dev *dev,
                        "Port %d MIB counters\n",
                        val->port_vlan);
 
-       for (i = 0; i < RTL8366S_MIB_COUNT; ++i) {
+       for (i = 0; i < ARRAY_SIZE(rtl8366rb_mib_counters); ++i) {
                len += snprintf(buf + len, sizeof(rtl->buf) - len,
-                               "%d:%s\t", i, rtl8366rb_mib_counters[i].name);
-               if (!rtl8366_get_mib_counter(rtl, i, val->port_vlan, &counter))
+                               "%-36s: ", rtl8366rb_mib_counters[i].name);
+               if (!rtl8366_get_mib_counter(smi, i, val->port_vlan, &counter))
                        len += snprintf(buf + len, sizeof(rtl->buf) - len,
-                                       "[%llu]\n", counter);
+                                       "%llu\n", counter);
                else
                        len += snprintf(buf + len, sizeof(rtl->buf) - len,
-                                       "[error]\n");
+                                       "%s\n", "error");
        }
 
        val->value.s = buf;
@@ -1305,14 +1297,14 @@ static int rtl8366rb_sw_get_vlan_ports(struct switch_dev *dev,
                                      struct switch_val *val)
 {
        struct rtl8366_vlan_mc vlanmc;
-       struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
+       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
        struct switch_port *port;
        int i;
 
        if (val->port_vlan == 0 || val->port_vlan >= RTL8366_NUM_VLANS)
                return -EINVAL;
 
-       rtl8366rb_get_vlan_mc(rtl, val->port_vlan, &vlanmc);
+       rtl8366rb_get_vlan_mc(smi, val->port_vlan, &vlanmc);
 
        port = &val->value.ports[0];
        val->len = 0;
@@ -1333,16 +1325,16 @@ static int rtl8366rb_sw_set_vlan_ports(struct switch_dev *dev,
                                      struct switch_val *val)
 {
        struct rtl8366_vlan_mc vlanmc;
-       struct rtl8366rb_vlan_4k vlan4k;
-       struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
+       struct rtl8366_vlan_4k vlan4k;
+       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
        struct switch_port *port;
        int i;
 
        if (val->port_vlan == 0 || val->port_vlan >= RTL8366_NUM_VLANS)
                return -EINVAL;
 
-       rtl8366rb_get_vlan_mc(rtl, val->port_vlan, &vlanmc);
-       rtl8366rb_get_vlan_4k(rtl, vlanmc.vid, &vlan4k);
+       rtl8366rb_get_vlan_mc(smi, val->port_vlan, &vlanmc);
+       rtl8366rb_get_vlan_4k(smi, vlanmc.vid, &vlan4k);
 
        vlanmc.untag = 0;
        vlanmc.member = 0;
@@ -1358,33 +1350,33 @@ static int rtl8366rb_sw_set_vlan_ports(struct switch_dev *dev,
        vlan4k.member = vlanmc.member;
        vlan4k.untag = vlanmc.untag;
 
-       rtl8366rb_set_vlan_mc(rtl, val->port_vlan, &vlanmc);
-       rtl8366rb_set_vlan_4k(rtl, &vlan4k);
+       rtl8366rb_set_vlan_mc(smi, val->port_vlan, &vlanmc);
+       rtl8366rb_set_vlan_4k(smi, &vlan4k);
        return 0;
 }
 
 static int rtl8366rb_sw_get_port_pvid(struct switch_dev *dev, int port, int *val)
 {
-       struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
-       return rtl8366rb_get_vlan_port_pvid(rtl, port, val);
+       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
+       return rtl8366rb_get_vlan_port_pvid(smi, port, val);
 }
 
 static int rtl8366rb_sw_set_port_pvid(struct switch_dev *dev, int port, int val)
 {
-       struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
-       return rtl8366rb_set_vlan_port_pvid(rtl, port, val);
+       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
+       return rtl8366rb_set_vlan_port_pvid(smi, port, val);
 }
 
 static int rtl8366rb_sw_reset_switch(struct switch_dev *dev)
 {
-       struct rtl8366rb *rtl = sw_to_rtl8366rb(dev);
+       struct rtl8366_smi *smi = sw_to_rtl8366_smi(dev);
        int err;
 
-       err = rtl8366rb_reset_chip(rtl);
+       err = rtl8366rb_reset_chip(smi);
        if (err)
                return err;
 
-       return rtl8366rb_reset_vlan(rtl);
+       return rtl8366rb_reset_vlan(smi);
 }
 
 static struct switch_attr rtl8366rb_globals[] = {
@@ -1546,9 +1538,10 @@ static int rtl8366rb_mii_bus_match(struct mii_bus *bus)
 
 static int rtl8366rb_setup(struct rtl8366rb *rtl)
 {
+       struct rtl8366_smi *smi = &rtl->smi;
        int ret;
 
-       ret = rtl8366rb_reset_chip(rtl);
+       ret = rtl8366rb_reset_chip(smi);
        if (ret)
                return ret;