uhttpd: fix keep-alive bug (#20607, #20661)
authorJo-Philipp Wich <jow@openwrt.org>
Wed, 7 Oct 2015 22:14:48 +0000 (22:14 +0000)
committerJo-Philipp Wich <jow@openwrt.org>
Wed, 7 Oct 2015 22:14:48 +0000 (22:14 +0000)
commit4f7a138a4b3fa327800e82035052db76c4314f86
tree4fb5a7565e0d9e66245336504dfa6cd8422ae076
parent62eb2e4df19ecc1ca3d723b80ec3d046b7dcf665
uhttpd: fix keep-alive bug (#20607, #20661)

The two commits

  5162e3b0ee7bd1d0fd6e75e1ca7993a1834b5291
"allow request handlers to disable chunked reponses"

and

  618493e378e2239f0d30902e47adfa134e649fdc
"file: disable chunked encoding for file responses"

broke the chunked transfer encoding handling for proc responses in keep-alive
connections that followed a file response with http status 204 or 304.

The effect of this bug is that cgi responses following a 204 or 304 one where
sent neither in chunked encoding nor with a content-length header, causing
browsers to stall until the keep alive timeout was reached.

Fix the logic flaw by inverting the chunk prevention flag in the client state
and by testing the chunked encoding preconditions every time instead of
once upon client (re-)initialization.

Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>
SVN-Revision: 47161
package/network/services/uhttpd/Makefile
package/network/services/uhttpd/files/uhttpd.init