base-files: reorder led trigger/brightness writes
authorFelix Fietkau <nbd@openwrt.org>
Thu, 16 Apr 2015 20:09:30 +0000 (20:09 +0000)
committerFelix Fietkau <nbd@openwrt.org>
Thu, 16 Apr 2015 20:09:30 +0000 (20:09 +0000)
Depending on configuration, disable the LED before writing the trigger
and enable it after writing it. Fixes LEDs where the value defaults to 1

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
SVN-Revision: 45463

package/base-files/files/etc/init.d/led

index 6962bfa..ba4dd67 100755 (executable)
@@ -34,14 +34,17 @@ load_led() {
 
        [ -e /sys/class/leds/${sysfs}/brightness ] && {
                echo "setting up led ${name}"
-               [ "$default" != nil ] && {
-                       [ $default -eq 1 ] &&
-                               echo 1 >/sys/class/leds/${sysfs}/brightness
-                       [ $default -eq 1 ] ||
-                               echo 0 >/sys/class/leds/${sysfs}/brightness
-               }
+
+               [ "$default" = 0 ] ||
+                       echo 0 >/sys/class/leds/${sysfs}/brightness
+
                echo $trigger > /sys/class/leds/${sysfs}/trigger 2> /dev/null
-               [ $? = 0 ] || {
+               ret="$?"
+
+               [ $default = 1 ] &&
+                       echo 1 >/sys/class/leds/${sysfs}/brightness
+
+               [ $ret = 0 ] || {
                        echo >&2 "Skipping trigger '$trigger' for led '$name' due to missing kernel module"
                        return 1
                }