lldpd: wrap procd command args in separate quotes
authorJohn Crispin <john@openwrt.org>
Mon, 5 Oct 2015 10:29:01 +0000 (10:29 +0000)
committerJohn Crispin <john@openwrt.org>
Mon, 5 Oct 2015 10:29:01 +0000 (10:29 +0000)
Seems the match pattern was being adapted from 'eth0' to ' eth0'
because of the way I added the procd command args.

This did not seem to be a problem when there were multiple interfaces,
just on devices with single interfaces for lldpd to listen on.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
SVN-Revision: 47136

package/network/services/lldpd/files/lldpd.init

index 278dbaf..3d7d8b9 100644 (file)
@@ -54,14 +54,14 @@ start_service() {
        procd_set_param command /usr/sbin/lldpd
        procd_append_param command -d # don't daemonize, procd will handle that for us
 
-       [ -n "$ifnames" ] && procd_append_param command "-I $ifnames"
+       [ -n "$ifnames" ] && procd_append_param command -I "$ifnames"
        [ $enable_cdp -gt 0 ] && procd_append_param command '-c'
        [ $enable_fdp -gt 0 ] && procd_append_param command '-f'
        [ $enable_sonmp -gt 0 ] && procd_append_param command '-s'
        [ $enable_edp -gt 0 ] && procd_append_param command '-e'
        [ $readonly_mode -gt 0 ] && procd_append_param command '-r'
-       [ -n "$lldp_class" ] && procd_append_param command "-M $lldp_class"
-       [ -n "$lldp_description" ] && procd_append_param command "-S $lldp_description"
+       [ -n "$lldp_class" ] && procd_append_param command -M "$lldp_class"
+       [ -n "$lldp_description" ] && procd_append_param command -S "$lldp_description"
 
        # set auto respawn behavior
        procd_set_param respawn