fix interface enumeration issues related to /var/state/network (thx to fish for debug...
authorFelix Fietkau <nbd@openwrt.org>
Wed, 2 Apr 2008 21:27:28 +0000 (21:27 +0000)
committerFelix Fietkau <nbd@openwrt.org>
Wed, 2 Apr 2008 21:27:28 +0000 (21:27 +0000)
SVN-Revision: 10715

package/base-files/files/lib/network/config.sh
package/ppp/files/pppoe.sh

index 611da71..d76c4bf 100755 (executable)
@@ -40,10 +40,11 @@ scan_interfaces() {
                                append interfaces "$CONFIG_SECTION"
                                config_get iftype "$CONFIG_SECTION" type
                                config_get ifname "$CONFIG_SECTION" ifname
-                               config_set "$CONFIG_SECTION" device "$ifname"
+                               config_get device "$CONFIG_SECTION" device
+                               config_set "$CONFIG_SECTION" device "${device:-$ifname}"
                                case "$iftype" in
                                        bridge)
-                                               config_set "$CONFIG_SECTION" ifnames "$ifname"
+                                               config_set "$CONFIG_SECTION" ifnames "${device:-$ifname}"
                                                config_set "$CONFIG_SECTION" ifname br-"$CONFIG_SECTION"
                                        ;;
                                esac
@@ -113,6 +114,15 @@ prepare_interface() {
        return 0
 }
 
+set_interface_ifname() {
+       local config="$1"
+       local ifname="$2"
+
+       config_get device "$1" device
+       uci_set_state "network.$config.ifname=$ifname"
+       uci_set_state "network.$config.device=$device"
+}
+
 setup_interface() {
        local iface="$1"
        local config="$2"
@@ -140,7 +150,7 @@ setup_interface() {
        config_get macaddr "$config" macaddr
        grep "$iface:" /proc/net/dev > /dev/null && \
                $DEBUG ifconfig "$iface" ${macaddr:+hw ether "$macaddr"} ${mtu:+mtu $mtu} up
-       uci_set_state network "$config" ifname "$iface"
+       set_interface_ifname "$config" "$iface"
 
        pidfile="/var/run/$iface.pid"
        case "$proto" in
index f33d37a..e1c9a20 100644 (file)
@@ -13,7 +13,7 @@ setup_interface_pppoe() {
        # make sure the network state references the correct ifname
        scan_ppp "$config"
        config_get ifname "$config" ifname
-       uci set "/var/state/network.$config.ifname=$ifname"
+       set_interface_ifname "$config" "$ifname"
 
        config_get mtu "$cfg" mtu
        mtu=${mtu:-1492}