From: Travis Kemen <thepeople@openwrt.org>
Date: Tue, 23 Mar 2010 01:43:31 +0000 (+0000)
Subject: This patch fixes wrong error checking in stop() and adds checking for already running... 
X-Git-Url: http://git.openwrt.org/?p=openwrt%2Fsvn-archive%2Farchive.git;a=commitdiff_plain;h=218316d16abc4eb24ba8fceca1be1f475915dd26

This patch fixes wrong error checking in stop() and adds checking for already running named, from #6903

SVN-Revision: 20379
---

diff --git a/net/bind/files/named.init b/net/bind/files/named.init
index a82fed9067..3c4c76adf2 100644
--- a/net/bind/files/named.init
+++ b/net/bind/files/named.init
@@ -2,9 +2,14 @@
 START=50
 
 config_file=/etc/bind/named.conf
-pid_file=/var/run/named/named.pid
+pid_file=/var/run/named.pid
 
 start() {
+  if [ -e $pid_file ]
+  then
+     echo "  named already running with PID `cat $pid_file`"
+     return 1
+  fi
   echo Starting isc-bind
 
   /usr/sbin/named -c $config_file
@@ -21,13 +26,13 @@ stop() {
   then
     kill `cat $pid_file`
 
-    if [ $? -eq 0 ]
+    if [ $? -ne 0 ]
     then
       echo "  PID " `cat $pid_file` not found
       echo "  Is the named server running?"
     fi
 
-    rm $pid_file
+    rm -f $pid_file
 
     else
     echo "  $pid_file not found"