From: Nicolas Thill <nico@openwrt.org>
Date: Tue, 28 Apr 2009 15:29:14 +0000 (+0000)
Subject: [packages] mini-snmpd: fix a segfault when passing an invalid oid to the -V option... 
X-Git-Url: http://git.openwrt.org/?p=openwrt%2Fsvn-archive%2Farchive.git;a=commitdiff_plain;h=5d972d5ae880f4f459a72decf12a43d7b4d6f25a;hp=1b26381d9ea40a68a2e9645147a4b871cdb87872

[packages] mini-snmpd: fix a segfault when passing an invalid oid to the -V option (closes: #5021), log messages to syslog


SVN-Revision: 15469
---

diff --git a/net/mini_snmpd/Makefile b/net/mini_snmpd/Makefile
index 0ed7dcb20f..9b746782c8 100644
--- a/net/mini_snmpd/Makefile
+++ b/net/mini_snmpd/Makefile
@@ -31,7 +31,7 @@ endef
 define Build/Compile
 	$(MAKE) -C $(PKG_BUILD_DIR) \
 		CC="$(TARGET_CC)" \
-		OFLAGS="$(TARGET_CFLAGS)" \
+		OFLAGS="$(TARGET_CFLAGS) -DSYSLOG" \
 		STRIP="/bin/true" \
 		INSTALL_ROOT="$(PKG_INSTALL_DIR)" \
 		mini_snmpd install
diff --git a/net/mini_snmpd/patches/103-mib_encode_snmp_element_oid_fix.patch b/net/mini_snmpd/patches/103-mib_encode_snmp_element_oid_fix.patch
new file mode 100644
index 0000000000..a46ace24eb
--- /dev/null
+++ b/net/mini_snmpd/patches/103-mib_encode_snmp_element_oid_fix.patch
@@ -0,0 +1,21 @@
+--- a/mib.c
++++ b/mib.c
+@@ -120,6 +120,9 @@ static int encode_snmp_element_oid(value
+ 	int length;
+ 	int i;
+ 
++	if (oid_value == NULL) {
++		return -1;
++	}
+ 	buffer = value->data.buffer;
+ 	length = 1;
+ 	for (i = 2; i < oid_value->subid_list_length; i++) {
+@@ -293,6 +296,8 @@ static int mib_build_entry(const oid_t *
+ 			value->data.encoded_length = 0;
+ 			value->data.buffer = malloc(value->data.max_length);
+ 			if (encode_snmp_element_oid(value, oid_aton((const char *)default_value)) == -1) {
++				lprintf(LOG_ERR, "could not create MIB entry '%s.%d.%d': invalid oid '%s'\n",
++					oid_ntoa(prefix), column, row, (char *)default_value);
+ 				return -1;
+ 			}
+ 			break;