From: Daniel Dickinson <crazycshore@gmail.com>
Date: Tue, 5 Apr 2011 10:30:33 +0000 (+0000)
Subject: [net] Firewall: miniupnpd: Fixed miniupnpd attaching to shell when extra logging... 
X-Git-Url: http://git.openwrt.org/?p=openwrt%2Fsvn-archive%2Farchive.git;a=commitdiff_plain;hb=20b2dad87e704322943ee4340e199dd7f3ad3e76

[net] Firewall: miniupnpd: Fixed miniupnpd attaching to shell when extra logging enabled.  Fixed duplicated log messages when doing extra logging and removed unnecessary eval.

SVN-Revision: 26478
---

diff --git a/net/miniupnpd/files/miniupnpd.init b/net/miniupnpd/files/miniupnpd.init
index 1cf3fc15ec..3d41ba8ab8 100644
--- a/net/miniupnpd/files/miniupnpd.init
+++ b/net/miniupnpd/files/miniupnpd.init
@@ -163,9 +163,9 @@ start() {
 		miniupnpd_add_rules "$zone" "${extiface:-wan}" "$ifname"
 
 	    if [ "$logging" = "1" ]; then
-		eval start-stop-daemon -S -x miniupnpd -- $args -d | logger -t miniupnpd &
+		start-stop-daemon -b -S -x miniupnpd -- $args -d 
 	    else
-		eval start-stop-daemon -S -x miniupnpd -- $args 2>/dev/null
+		start-stop-daemon -S -x miniupnpd -- $args 
 	    fi
 	else
 		logger -t "upnp daemon" "external interface not found, not starting"