From: Daniel Dickinson <crazycshore@gmail.com>
Date: Sun, 18 Jul 2010 15:18:38 +0000 (+0000)
Subject: [package] base-files & telnet: Fixed telnet starting even with root password when... 
X-Git-Url: http://git.openwrt.org/?p=openwrt%2Fsvn-archive%2Farchive.git;a=commitdiff_plain;hb=33e5f9d26dd8ae228a526610ca5d58ddca92771e

[package] base-files & telnet: Fixed telnet starting even with root password when shadow passwords in use.

SVN-Revision: 22279
---

diff --git a/package/base-files/files/bin/login.sh b/package/base-files/files/bin/login.sh
index ff5d3660e4..00f2f81ab4 100755
--- a/package/base-files/files/bin/login.sh
+++ b/package/base-files/files/bin/login.sh
@@ -1,9 +1,16 @@
 #!/bin/sh
 # Copyright (C) 2006 OpenWrt.org
 
+
+regpassresult="0"
 grep '^root:[^!]' /etc/passwd >&- 2>&-
-[ "$?" = "0" -a -z "$FAILSAFE" ]  &&  
-{
+regpassresult="$?"
+shadowresult="0"
+if [ -e "/etc/shadow" ]; then
+	grep '^root:[^!]' /etc/shadow >&- 2>&-
+        shadowresult="$?"
+fi
+[ "$regpassresult" = "0" ] && [ "$shadowresult" = "0" ] && [ -z "$FAILSAFE" ] && {
     echo "Login failed."
     exit 0
 } || {
diff --git a/package/busybox/files/telnet b/package/busybox/files/telnet
index 082aba7e90..2fbbb23575 100755
--- a/package/busybox/files/telnet
+++ b/package/busybox/files/telnet
@@ -4,7 +4,8 @@ START=50
 
 start() {
 	if 	[ \! -f /etc/passwd ] || \
-		awk -F: '/^root:/ && ($2 != "") && ($2 !~ /\!/) {exit 1}' /etc/passwd 2>/dev/null || \
+		( awk -F: '/^root:/ && ($2 != "") && ($2 !~ /\!/) {exit 1}' /etc/passwd 2>/dev/null && \
+		awk -F: '/^root:/ && ($2 != "") && ($2 !~ /\!/) {exit 1}' /etc/shadow 2>/dev/null ) || \
 		( [ \! -x /usr/sbin/dropbear ] && [ \! -x /usr/sbin/sshd ] )
 	then \
 		telnetd -l /bin/login.sh