From 5e206f9d59f0e668e0d5068a158468114c637512 Mon Sep 17 00:00:00 2001 From: Felix Fietkau Date: Thu, 26 Jul 2007 21:38:35 +0000 Subject: [PATCH] protect the adm5120 pci ops with a spinlock - fixes race conditions that happened in combination with madwifi and more than one card SVN-Revision: 8186 --- .../linux/adm5120-2.6/files/arch/mips/pci/ops-adm5120.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/target/linux/adm5120-2.6/files/arch/mips/pci/ops-adm5120.c b/target/linux/adm5120-2.6/files/arch/mips/pci/ops-adm5120.c index f7e4e6686f..0bd0baa8da 100644 --- a/target/linux/adm5120-2.6/files/arch/mips/pci/ops-adm5120.c +++ b/target/linux/adm5120-2.6/files/arch/mips/pci/ops-adm5120.c @@ -28,6 +28,7 @@ #include #include #include +#include #include @@ -40,6 +41,8 @@ #define PCI_ENABLE 0x80000000 +static spinlock_t pci_lock = SPIN_LOCK_UNLOCKED; + static inline void write_cfgaddr(u32 addr) { *(volatile u32*)KSEG1ADDR(ADM5120_PCICFG_ADDR) = (addr | PCI_ENABLE); @@ -65,8 +68,10 @@ static inline u32 mkaddr(struct pci_bus *bus, unsigned int devfn, int where) static int pci_config_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val) { + unsigned long flags; u32 data; + spin_lock_irqsave(&pci_lock, flags); write_cfgaddr(mkaddr(bus,devfn,where)); data = read_cfgdata(); @@ -90,6 +95,7 @@ static int pci_config_read(struct pci_bus *bus, unsigned int devfn, int where, *val = data; DBG(", 0x%08X returned\n", data); + spin_unlock_irqrestore(&pci_lock, flags); return PCIBIOS_SUCCESSFUL; } @@ -97,9 +103,11 @@ static int pci_config_read(struct pci_bus *bus, unsigned int devfn, int where, static int pci_config_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val) { + unsigned long flags; u32 data; int s; + spin_lock_irqsave(&pci_lock, flags); write_cfgaddr(mkaddr(bus,devfn,where)); data = read_cfgdata(); @@ -124,6 +132,7 @@ static int pci_config_write(struct pci_bus *bus, unsigned int devfn, int where, write_cfgdata(data); DBG(", 0x%08X written\n", data); + spin_unlock_irqrestore(&pci_lock, flags); return PCIBIOS_SUCCESSFUL; } -- 2.30.2