X-Git-Url: http://git.openwrt.org/?p=project%2Ffstools.git;a=blobdiff_plain;f=block.c;h=720ecb11dc25814638ee8bee051fff58d135a1c6;hp=13992f20ebbce0bccb0fb664188c6d2b3e9a3c81;hb=addd7dc21fe99f2701c1d4708071578052af401d;hpb=0453f48e509077c83129b8aaceecb4e4430c8309

diff --git a/block.c b/block.c
index 13992f2..720ecb1 100644
--- a/block.c
+++ b/block.c
@@ -464,6 +464,16 @@ static int config_load(char *cfg)
 static struct blkid_struct_probe* _probe_path(char *path)
 {
 	struct blkid_struct_probe *pr;
+	char tmppath[64];
+
+	/* skip ubi device if ubiblock device is present */
+	if (path[5] == 'u' && path[6] == 'b' && path[7] == 'i' &&
+	    path[8] >= '0' && path[8] <= '9' ) {
+		snprintf(tmppath, sizeof(tmppath), "/dev/ubiblock%s", path + 8);
+		list_for_each_entry(pr, &devices, list)
+			if (!strcasecmp(pr->dev, tmppath))
+				return NULL;
+	}
 
 	pr = malloc(sizeof(*pr));
 
@@ -506,7 +516,7 @@ static void cache_load(int mtd)
 	if (mtd) {
 		_cache_load("/dev/mtdblock*");
 		_cache_load("/dev/ubiblock*");
-		_cache_load("/dev/ubi?*_?*");
+		_cache_load("/dev/ubi[0-9]*");
 	}
 	_cache_load("/dev/mmcblk*");
 	_cache_load("/dev/sd*");
@@ -577,25 +587,86 @@ static struct blkid_struct_probe* find_block_info(char *uuid, char *label, char
 
 static char* find_mount_point(char *block)
 {
-	FILE *fp = fopen("/proc/mounts", "r");
+	FILE *fp = fopen("/proc/self/mountinfo", "r");
 	static char line[256];
 	int len = strlen(block);
-	char *point = NULL;
+	char *point = NULL, *pos, *tmp, *cpoint, *devname;
+	struct stat s;
+	int rstat;
+	unsigned int minor, major;
 
-	if(!fp)
+	if (!fp)
 		return NULL;
 
+	rstat = stat(block, &s);
+
 	while (fgets(line, sizeof(line), fp)) {
-		if (!strncmp(line, block, len)) {
-			char *p = &line[len + 1];
-			char *t = strstr(p, " ");
+		pos = strchr(line, ' ');
+		if (!pos)
+			continue;
 
-			if (!t) {
-				fclose(fp);
-				return NULL;
-			}
-			*t = '\0';
-			point = p;
+		pos = strchr(pos + 1, ' ');
+		if (!pos)
+			continue;
+
+		tmp = ++pos;
+		pos = strchr(pos, ':');
+		if (!pos)
+			continue;
+
+		*pos = '\0';
+		major = atoi(tmp);
+		tmp = ++pos;
+		pos = strchr(pos, ' ');
+		if (!pos)
+			continue;
+
+		*pos = '\0';
+		minor = atoi(tmp);
+		pos = strchr(pos + 1, ' ');
+		if (!pos)
+			continue;
+		tmp = ++pos;
+
+		pos = strchr(pos, ' ');
+		if (!pos)
+			continue;
+		*pos = '\0';
+		cpoint = tmp;
+
+		pos = strchr(pos + 1, ' ');
+		if (!pos)
+			continue;
+
+		pos = strchr(pos + 1, ' ');
+		if (!pos)
+			continue;
+
+		pos = strchr(pos + 1, ' ');
+		if (!pos)
+			continue;
+
+		tmp = ++pos;
+		pos = strchr(pos, ' ');
+		if (!pos)
+			continue;
+
+		*pos = '\0';
+		devname = tmp;
+		if (!strncmp(block, devname, len)) {
+			point = strdup(cpoint);
+			break;
+		}
+
+		if (rstat)
+			continue;
+
+		if (!S_ISBLK(s.st_mode))
+			continue;
+
+		if (major == major(s.st_rdev) &&
+		    minor == minor(s.st_rdev)) {
+			point = strdup(cpoint);
 			break;
 		}
 	}
@@ -690,6 +761,7 @@ static int mount_device(struct blkid_struct_probe *pr, int hotplug)
 {
 	struct mount *m;
 	char *device;
+	char *mp;
 
 	if (!pr)
 		return -1;
@@ -709,8 +781,10 @@ static int mount_device(struct blkid_struct_probe *pr, int hotplug)
 	if (hotplug && !auto_mount)
 		return -1;
 
-	if (find_mount_point(pr->dev)) {
-		ULOG_ERR("%s is already mounted\n", pr->dev);
+	mp = find_mount_point(pr->dev);
+	if (mp) {
+		ULOG_ERR("%s is already mounted on %s\n", pr->dev, mp);
+		free(mp);
 		return -1;
 	}
 
@@ -743,7 +817,7 @@ static int mount_device(struct blkid_struct_probe *pr, int hotplug)
 	}
 
 	if (anon_mount) {
-		char target[] = "/mnt/mmcblk123";
+		char target[32];
 		int err = 0;
 
 		snprintf(target, sizeof(target), "/mnt/%s", device);
@@ -793,6 +867,7 @@ static int umount_device(struct blkid_struct_probe *pr)
 		ULOG_INFO("unmounted %s (%s)\n",
 		          pr->dev, mp);
 
+	free(mp);
 	return err;
 }
 
@@ -818,6 +893,7 @@ static int main_hotplug(int argc, char **argv)
 			ULOG_ERR("umount of %s failed (%d) - %s\n",
 			         mount_point, err, strerror(err));
 
+		free(mount_point);
 		return 0;
 	} else if (strcmp(action, "add")) {
 		ULOG_ERR("Unkown action %s\n", action);
@@ -1267,7 +1343,7 @@ static int main_info(int argc, char **argv)
 			ULOG_ERR("failed to stat %s\n", argv[i]);
 			continue;
 		}
-		if (!S_ISBLK(s.st_mode)) {
+		if (!S_ISBLK(s.st_mode) && !(S_ISCHR(s.st_mode) && major(s.st_rdev) == 250)) {
 			ULOG_ERR("%s is not a block device\n", argv[i]);
 			continue;
 		}