config: log config parse failures to syslog
[project/odhcpd.git] / src / config.c
index d6b4e81ab027e8cdbfa1d0784837f4f71afbcb88..e46ecb0d1063962603a1d9f8d1fd1b83e8a63e2e 100644 (file)
@@ -4,29 +4,44 @@
 #include <arpa/inet.h>
 #include <unistd.h>
 #include <libgen.h>
+#include <net/if.h>
 #include <string.h>
 #include <sys/stat.h>
 #include <syslog.h>
 
 #include <uci.h>
 #include <uci_blob.h>
+#include <libubox/utils.h>
+#include <libubox/avl.h>
+#include <libubox/avl-cmp.h>
+#include <libubox/list.h>
+#include <libubox/vlist.h>
 
 #include "odhcpd.h"
 
 static struct blob_buf b;
-static int reload_pipe[2];
-struct list_head leases = LIST_HEAD_INIT(leases);
-struct list_head interfaces = LIST_HEAD_INIT(interfaces);
+static int reload_pipe[2] = { -1, -1 };
+
+static int lease_cmp(const void *k1, const void *k2, void *ptr);
+static void lease_update(struct vlist_tree *tree, struct vlist_node *node_new,
+                        struct vlist_node *node_old);
+
+struct vlist_tree leases = VLIST_TREE_INIT(leases, lease_cmp, lease_update, true, false);
+AVL_TREE(interfaces, avl_strcmp, false, NULL);
 struct config config = {.legacy = false, .main_dhcpv4 = false,
                        .dhcp_cb = NULL, .dhcp_statefile = NULL,
-                       .log_level = LOG_INFO};
+                       .log_level = LOG_WARNING};
+
+#define START_DEFAULT  100
+#define LIMIT_DEFAULT  150
+
+#define OAF_DHCPV6     (OAF_DHCPV6_NA | OAF_DHCPV6_PD)
 
 enum {
        IFACE_ATTR_INTERFACE,
        IFACE_ATTR_IFNAME,
        IFACE_ATTR_NETWORKID,
        IFACE_ATTR_DYNAMICDHCP,
-       IFACE_ATTR_IGNORE,
        IFACE_ATTR_LEASETIME,
        IFACE_ATTR_LIMIT,
        IFACE_ATTR_START,
@@ -38,11 +53,18 @@ enum {
        IFACE_ATTR_NDP,
        IFACE_ATTR_ROUTER,
        IFACE_ATTR_DNS,
+       IFACE_ATTR_DNS_SERVICE,
        IFACE_ATTR_DOMAIN,
        IFACE_ATTR_FILTER_CLASS,
+       IFACE_ATTR_DHCPV4_FORCERECONF,
        IFACE_ATTR_DHCPV6_RAW,
+       IFACE_ATTR_DHCPV6_ASSIGNALL,
+       IFACE_ATTR_DHCPV6_PD,
+       IFACE_ATTR_DHCPV6_NA,
        IFACE_ATTR_RA_DEFAULT,
        IFACE_ATTR_RA_MANAGEMENT,
+       IFACE_ATTR_RA_FLAGS,
+       IFACE_ATTR_RA_SLAAC,
        IFACE_ATTR_RA_OFFLINK,
        IFACE_ATTR_RA_PREFERENCE,
        IFACE_ATTR_RA_ADVROUTER,
@@ -50,11 +72,17 @@ enum {
        IFACE_ATTR_RA_MAXINTERVAL,
        IFACE_ATTR_RA_LIFETIME,
        IFACE_ATTR_RA_USELEASETIME,
+       IFACE_ATTR_RA_REACHABLETIME,
+       IFACE_ATTR_RA_RETRANSTIME,
+       IFACE_ATTR_RA_HOPLIMIT,
        IFACE_ATTR_RA_MTU,
+       IFACE_ATTR_RA_DNS,
        IFACE_ATTR_PD_MANAGER,
        IFACE_ATTR_PD_CER,
        IFACE_ATTR_NDPROXY_ROUTING,
        IFACE_ATTR_NDPROXY_SLAVE,
+       IFACE_ATTR_PREFIX_FILTER,
+       IFACE_ATTR_PREFERRED_LIFETIME,
        IFACE_ATTR_MAX
 };
 
@@ -63,7 +91,6 @@ static const struct blobmsg_policy iface_attrs[IFACE_ATTR_MAX] = {
        [IFACE_ATTR_IFNAME] = { .name = "ifname", .type = BLOBMSG_TYPE_STRING },
        [IFACE_ATTR_NETWORKID] = { .name = "networkid", .type = BLOBMSG_TYPE_STRING },
        [IFACE_ATTR_DYNAMICDHCP] = { .name = "dynamicdhcp", .type = BLOBMSG_TYPE_BOOL },
-       [IFACE_ATTR_IGNORE] = { .name = "ignore", .type = BLOBMSG_TYPE_BOOL },
        [IFACE_ATTR_LEASETIME] = { .name = "leasetime", .type = BLOBMSG_TYPE_STRING },
        [IFACE_ATTR_START] = { .name = "start", .type = BLOBMSG_TYPE_INT32 },
        [IFACE_ATTR_LIMIT] = { .name = "limit", .type = BLOBMSG_TYPE_INT32 },
@@ -75,13 +102,20 @@ static const struct blobmsg_policy iface_attrs[IFACE_ATTR_MAX] = {
        [IFACE_ATTR_NDP] = { .name = "ndp", .type = BLOBMSG_TYPE_STRING },
        [IFACE_ATTR_ROUTER] = { .name = "router", .type = BLOBMSG_TYPE_ARRAY },
        [IFACE_ATTR_DNS] = { .name = "dns", .type = BLOBMSG_TYPE_ARRAY },
+       [IFACE_ATTR_DNS_SERVICE] = { .name = "dns_service", .type = BLOBMSG_TYPE_BOOL },
        [IFACE_ATTR_DOMAIN] = { .name = "domain", .type = BLOBMSG_TYPE_ARRAY },
        [IFACE_ATTR_FILTER_CLASS] = { .name = "filter_class", .type = BLOBMSG_TYPE_STRING },
+       [IFACE_ATTR_DHCPV4_FORCERECONF] = { .name = "dhcpv4_forcereconf", .type = BLOBMSG_TYPE_BOOL },
        [IFACE_ATTR_DHCPV6_RAW] = { .name = "dhcpv6_raw", .type = BLOBMSG_TYPE_STRING },
+       [IFACE_ATTR_DHCPV6_ASSIGNALL] = { .name ="dhcpv6_assignall", .type = BLOBMSG_TYPE_BOOL },
+       [IFACE_ATTR_DHCPV6_PD] = { .name = "dhcpv6_pd", .type = BLOBMSG_TYPE_BOOL },
+       [IFACE_ATTR_DHCPV6_NA] = { .name = "dhcpv6_na", .type = BLOBMSG_TYPE_BOOL },
        [IFACE_ATTR_PD_MANAGER] = { .name = "pd_manager", .type = BLOBMSG_TYPE_STRING },
        [IFACE_ATTR_PD_CER] = { .name = "pd_cer", .type = BLOBMSG_TYPE_STRING },
        [IFACE_ATTR_RA_DEFAULT] = { .name = "ra_default", .type = BLOBMSG_TYPE_INT32 },
        [IFACE_ATTR_RA_MANAGEMENT] = { .name = "ra_management", .type = BLOBMSG_TYPE_INT32 },
+       [IFACE_ATTR_RA_FLAGS] = { .name = "ra_flags", . type = BLOBMSG_TYPE_ARRAY },
+       [IFACE_ATTR_RA_SLAAC] = { .name = "ra_slaac", .type = BLOBMSG_TYPE_BOOL },
        [IFACE_ATTR_RA_OFFLINK] = { .name = "ra_offlink", .type = BLOBMSG_TYPE_BOOL },
        [IFACE_ATTR_RA_PREFERENCE] = { .name = "ra_preference", .type = BLOBMSG_TYPE_STRING },
        [IFACE_ATTR_RA_ADVROUTER] = { .name = "ra_advrouter", .type = BLOBMSG_TYPE_BOOL },
@@ -89,9 +123,15 @@ static const struct blobmsg_policy iface_attrs[IFACE_ATTR_MAX] = {
        [IFACE_ATTR_RA_MAXINTERVAL] = { .name = "ra_maxinterval", .type = BLOBMSG_TYPE_INT32 },
        [IFACE_ATTR_RA_LIFETIME] = { .name = "ra_lifetime", .type = BLOBMSG_TYPE_INT32 },
        [IFACE_ATTR_RA_USELEASETIME] = { .name = "ra_useleasetime", .type = BLOBMSG_TYPE_BOOL },
+       [IFACE_ATTR_RA_REACHABLETIME] = { .name = "ra_reachabletime", .type = BLOBMSG_TYPE_INT32 },
+       [IFACE_ATTR_RA_RETRANSTIME] = { .name = "ra_retranstime", .type = BLOBMSG_TYPE_INT32 },
+       [IFACE_ATTR_RA_HOPLIMIT] = { .name = "ra_hoplimit", .type = BLOBMSG_TYPE_INT32 },
        [IFACE_ATTR_RA_MTU] = { .name = "ra_mtu", .type = BLOBMSG_TYPE_INT32 },
+       [IFACE_ATTR_RA_DNS] = { .name = "ra_dns", .type = BLOBMSG_TYPE_BOOL },
        [IFACE_ATTR_NDPROXY_ROUTING] = { .name = "ndproxy_routing", .type = BLOBMSG_TYPE_BOOL },
        [IFACE_ATTR_NDPROXY_SLAVE] = { .name = "ndproxy_slave", .type = BLOBMSG_TYPE_BOOL },
+       [IFACE_ATTR_PREFIX_FILTER] = { .name = "prefix_filter", .type = BLOBMSG_TYPE_STRING },
+       [IFACE_ATTR_PREFERRED_LIFETIME] = { .name = "preferred_lifetime", .type = BLOBMSG_TYPE_STRING },
 };
 
 static const struct uci_blob_param_info iface_attr_info[IFACE_ATTR_MAX] = {
@@ -106,17 +146,7 @@ const struct uci_blob_param_list interface_attr_list = {
        .info = iface_attr_info,
 };
 
-enum {
-       LEASE_ATTR_IP,
-       LEASE_ATTR_MAC,
-       LEASE_ATTR_DUID,
-       LEASE_ATTR_HOSTID,
-       LEASE_ATTR_LEASETIME,
-       LEASE_ATTR_NAME,
-       LEASE_ATTR_MAX
-};
-
-static const struct blobmsg_policy lease_attrs[LEASE_ATTR_MAX] = {
+const struct blobmsg_policy lease_attrs[LEASE_ATTR_MAX] = {
        [LEASE_ATTR_IP] = { .name = "ip", .type = BLOBMSG_TYPE_STRING },
        [LEASE_ATTR_MAC] = { .name = "mac", .type = BLOBMSG_TYPE_STRING },
        [LEASE_ATTR_DUID] = { .name = "duid", .type = BLOBMSG_TYPE_STRING },
@@ -139,7 +169,7 @@ enum {
        ODHCPD_ATTR_MAX
 };
 
-static const struct blobmsg_policy odhcpd_attrs[LEASE_ATTR_MAX] = {
+static const struct blobmsg_policy odhcpd_attrs[ODHCPD_ATTR_MAX] = {
        [ODHCPD_ATTR_LEGACY] = { .name = "legacy", .type = BLOBMSG_TYPE_BOOL },
        [ODHCPD_ATTR_MAINDHCP] = { .name = "maindhcp", .type = BLOBMSG_TYPE_BOOL },
        [ODHCPD_ATTR_LEASEFILE] = { .name = "leasefile", .type = BLOBMSG_TYPE_STRING },
@@ -152,57 +182,36 @@ const struct uci_blob_param_list odhcpd_attr_list = {
        .params = odhcpd_attrs,
 };
 
-static int mkdir_p(char *dir, mode_t mask)
-{
-       char *l = strrchr(dir, '/');
-       int ret;
-
-       if (!l)
-               return 0;
-
-       *l = '\0';
-
-       if (mkdir_p(dir, mask))
-               return -1;
-
-       *l = '/';
-
-       ret = mkdir(dir, mask);
-       if (ret && errno == EEXIST)
-               return 0;
-
-       if (ret)
-               syslog(LOG_ERR, "mkdir(%s, %d) failed: %s\n", dir, mask, strerror(errno));
-
-       return ret;
-}
-
-static void free_lease(struct lease *l)
-{
-       if (l->head.next)
-               list_del(&l->head);
-
-       free(l->duid);
-       free(l);
-}
-
-static struct interface* get_interface(const char *name)
-{
-       struct interface *c;
-       list_for_each_entry(c, &interfaces, head)
-               if (!strcmp(c->name, name))
-                       return c;
-       return NULL;
-}
+static const struct { const char *name; uint8_t flag; } ra_flags[] = {
+       { .name = "managed-config", .flag = ND_RA_FLAG_MANAGED },
+       { .name = "other-config", .flag = ND_RA_FLAG_OTHER },
+       { .name = "home-agent", .flag = ND_RA_FLAG_HOME_AGENT },
+       { .name = "none", . flag = 0 },
+       { .name = NULL, },
+};
 
 static void set_interface_defaults(struct interface *iface)
 {
-       iface->managed = 1;
+       iface->ignore = true;
+       iface->dhcpv4 = MODE_DISABLED;
+       iface->dhcpv6 = MODE_DISABLED;
+       iface->ra = MODE_DISABLED;
+       iface->ndp = MODE_DISABLED;
        iface->learn_routes = 1;
-       iface->dhcpv4_leasetime = 43200;
+       iface->dhcp_leasetime = 43200;
+       iface->preferred_lifetime = 43200;
+       iface->dhcpv4_start.s_addr = htonl(START_DEFAULT);
+       iface->dhcpv4_end.s_addr = htonl(START_DEFAULT + LIMIT_DEFAULT - 1);
+       iface->dhcpv6_assignall = true;
+       iface->dhcpv6_pd = true;
+       iface->dhcpv6_na = true;
+       iface->dns_service = true;
+       iface->ra_flags = ND_RA_FLAG_OTHER;
+       iface->ra_slaac = true;
        iface->ra_maxinterval = 600;
        iface->ra_mininterval = iface->ra_maxinterval/3;
        iface->ra_lifetime = -1;
+       iface->ra_dns = true;
 }
 
 static void clean_interface(struct interface *iface)
@@ -220,32 +229,64 @@ static void clean_interface(struct interface *iface)
 
 static void close_interface(struct interface *iface)
 {
-       if (iface->head.next)
-               list_del(&iface->head);
+       avl_delete(&interfaces, &iface->avl);
 
-       setup_router_interface(iface, false);
-       setup_dhcpv6_interface(iface, false);
-       setup_ndp_interface(iface, false);
-       setup_dhcpv4_interface(iface, false);
+       router_setup_interface(iface, false);
+       dhcpv6_setup_interface(iface, false);
+       ndp_setup_interface(iface, false);
+#ifdef DHCPV4_SUPPORT
+       dhcpv4_setup_interface(iface, false);
+#endif
 
        clean_interface(iface);
+       free(iface->addr4);
+       free(iface->addr6);
+       free(iface->ifname);
        free(iface);
 }
 
 static int parse_mode(const char *mode)
 {
        if (!strcmp(mode, "disabled"))
-               return RELAYD_DISABLED;
+               return MODE_DISABLED;
        else if (!strcmp(mode, "server"))
-               return RELAYD_SERVER;
+               return MODE_SERVER;
        else if (!strcmp(mode, "relay"))
-               return RELAYD_RELAY;
+               return MODE_RELAY;
        else if (!strcmp(mode, "hybrid"))
-               return RELAYD_HYBRID;
+               return MODE_HYBRID;
        else
                return -1;
 }
 
+static int parse_ra_flags(uint8_t *flags, struct blob_attr *attr)
+{
+       struct blob_attr *cur;
+       unsigned rem;
+
+       blobmsg_for_each_attr(cur, attr, rem) {
+               int i;
+
+               if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
+                       continue;
+
+                if (!blobmsg_check_attr(cur, false))
+                        continue;
+
+               for (i = 0; ra_flags[i].name; i++) {
+                       if (!strcmp(ra_flags[i].name, blobmsg_get_string(cur))) {
+                               *flags |= ra_flags[i].flag;
+                               break;
+                       }
+               }
+
+               if (!ra_flags[i].name)
+                       return -1;
+       }
+
+       return 0;
+}
+
 static void set_config(struct uci_section *s)
 {
        struct blob_attr *tb[ODHCPD_ATTR_MAX], *c;
@@ -308,53 +349,63 @@ err:
        return -1;
 }
 
-static int set_lease(struct uci_section *s)
+static void free_lease(struct lease *l)
 {
-       struct blob_attr *tb[LEASE_ATTR_MAX], *c;
+       free(l->hostname);
+       free(l);
+}
 
-       blob_buf_init(&b, 0);
-       uci_to_blob(&b, s, &lease_attr_list);
-       blobmsg_parse(lease_attrs, LEASE_ATTR_MAX, tb, blob_data(b.head), blob_len(b.head));
 
-       size_t hostlen = 1;
-       if ((c = tb[LEASE_ATTR_NAME]))
-               hostlen = blobmsg_data_len(c);
+int set_lease_from_blobmsg(struct blob_attr *ba)
+{
+       struct blob_attr *tb[LEASE_ATTR_MAX], *c;
+       struct lease *l;
+       size_t duidlen = 0;
+       uint8_t *duid;
 
-       struct lease *lease = calloc(1, sizeof(*lease) + hostlen);
-       if (!lease)
-               goto err;
+       blobmsg_parse(lease_attrs, LEASE_ATTR_MAX, tb, blob_data(ba), blob_len(ba));
 
-       if (hostlen > 1)
-               memcpy(lease->hostname, blobmsg_get_string(c), hostlen);
+       if ((c = tb[LEASE_ATTR_DUID]))
+               duidlen = (blobmsg_data_len(c) - 1) / 2;
 
-       if ((c = tb[LEASE_ATTR_IP]))
-               if (inet_pton(AF_INET, blobmsg_get_string(c), &lease->ipaddr) < 0)
-                       goto err;
+       l = calloc_a(sizeof(*l), &duid, duidlen);
+       if (!l)
+               goto err;
 
        if ((c = tb[LEASE_ATTR_MAC]))
-               if (!ether_aton_r(blobmsg_get_string(c), &lease->mac))
+               if (!ether_aton_r(blobmsg_get_string(c), &l->mac))
                        goto err;
 
        if ((c = tb[LEASE_ATTR_DUID])) {
-               size_t duidlen = (blobmsg_data_len(c) - 1) / 2;
-               lease->duid = malloc(duidlen);
-               if (!lease->duid)
-                       goto err;
+               ssize_t len;
 
-               ssize_t len = odhcpd_unhexlify(lease->duid,
-                               duidlen, blobmsg_get_string(c));
+               l->duid = duid;
+               len = odhcpd_unhexlify(l->duid, duidlen, blobmsg_get_string(c));
 
                if (len < 0)
                        goto err;
 
-               lease->duid_len = len;
+               l->duid_len = len;
+       }
+
+       if ((c = tb[LEASE_ATTR_NAME])) {
+               l->hostname = strdup(blobmsg_get_string(c));
+               if (!l->hostname || !odhcpd_valid_hostname(l->hostname))
+                       goto err;
        }
 
+       if ((c = tb[LEASE_ATTR_IP]))
+               if (inet_pton(AF_INET, blobmsg_get_string(c), &l->ipaddr) < 0)
+                       goto err;
+
        if ((c = tb[LEASE_ATTR_HOSTID])) {
                errno = 0;
-               lease->hostid = strtoul(blobmsg_get_string(c), NULL, 16);
+               l->hostid = strtoul(blobmsg_get_string(c), NULL, 16);
                if (errno)
                        goto err;
+       } else {
+               uint32_t i4a = ntohl(l->ipaddr) & 0xff;
+               l->hostid = ((i4a / 100) << 8) | (((i4a % 100) / 10) << 4) | (i4a % 10);
        }
 
        if ((c = tb[LEASE_ATTR_LEASETIME])) {
@@ -362,22 +413,36 @@ static int set_lease(struct uci_section *s)
                if (time < 0)
                        goto err;
 
-               lease->dhcpv4_leasetime = time;
+               l->leasetime = time;
        }
 
-       list_add(&lease->head, &leases);
+       INIT_LIST_HEAD(&l->assignments);
+       vlist_add(&leases, &l->node, l);
        return 0;
 
 err:
-       if (lease)
-               free_lease(lease);
+       if (l)
+               free_lease(l);
 
        return -1;
 }
 
+static int set_lease_from_uci(struct uci_section *s)
+{
+       blob_buf_init(&b, 0);
+       uci_to_blob(&b, s, &lease_attr_list);
+
+       return set_lease_from_blobmsg(b.head);
+}
+
 int config_parse_interface(void *data, size_t len, const char *name, bool overwrite)
 {
+       struct interface *iface;
        struct blob_attr *tb[IFACE_ATTR_MAX], *c;
+       bool get_addrs = false;
+       int mode;
+       const char *ifname = NULL;
+
        blobmsg_parse(iface_attrs, IFACE_ATTR_MAX, tb, data, len);
 
        if (tb[IFACE_ATTR_INTERFACE])
@@ -386,21 +451,31 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
        if (!name)
                return -1;
 
-       struct interface *iface = get_interface(name);
+       iface = avl_find_element(&interfaces, name, iface, avl);
        if (!iface) {
-               iface = calloc(1, sizeof(*iface));
+               char *new_name;
+
+               iface = calloc_a(sizeof(*iface), &new_name, strlen(name) + 1);
                if (!iface)
                        return -1;
 
-               strncpy(iface->name, name, sizeof(iface->name) - 1);
+               iface->name = strcpy(new_name, name);
+               iface->avl.key = iface->name;
+               iface->router_event.uloop.fd = -1;
+               iface->dhcpv6_event.uloop.fd = -1;
+               iface->ndp_event.uloop.fd = -1;
+               iface->ndp_ping_fd = -1;
+               iface->dhcpv4_event.uloop.fd = -1;
+               INIT_LIST_HEAD(&iface->ia_assignments);
+               INIT_LIST_HEAD(&iface->dhcpv4_assignments);
+               INIT_LIST_HEAD(&iface->dhcpv4_fr_ips);
 
                set_interface_defaults(iface);
 
-               list_add(&iface->head, &interfaces);
-               overwrite = true;
+               avl_insert(&interfaces, &iface->avl);
+               get_addrs = overwrite = true;
        }
 
-       const char *ifname = NULL;
        if (overwrite) {
                if ((c = tb[IFACE_ATTR_IFNAME]))
                        ifname = blobmsg_get_string(c);
@@ -409,45 +484,77 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
        }
 
 #ifdef WITH_UBUS
-       if (overwrite || !iface->ifname[0])
+       if (overwrite || !iface->ifname)
                ifname = ubus_get_ifname(name);
 #endif
 
-       if (!iface->ifname[0] && !ifname)
+       if (!iface->ifname && !ifname)
                goto err;
 
-       if (ifname)
-               strncpy(iface->ifname, ifname, sizeof(iface->ifname) - 1);
+       if (ifname) {
+               free(iface->ifname);
+               iface->ifname = strdup(ifname);
 
-       if ((iface->ifindex = if_nametoindex(iface->ifname)) <= 0)
-               goto err;
+               if (!iface->ifname)
+                       goto err;
+
+               if (!iface->ifindex &&
+                   (iface->ifindex = if_nametoindex(iface->ifname)) <= 0)
+                       goto err;
+       }
+
+       if (get_addrs) {
+               ssize_t len = netlink_get_interface_addrs(iface->ifindex,
+                                               true, &iface->addr6);
+
+               if (len > 0)
+                       iface->addr6_len = len;
+
+               len = netlink_get_interface_addrs(iface->ifindex,
+                                               false, &iface->addr4);
+               if (len > 0)
+                       iface->addr4_len = len;
+       }
 
        iface->inuse = true;
 
        if ((c = tb[IFACE_ATTR_DYNAMICDHCP]))
                iface->no_dynamic_dhcp = !blobmsg_get_bool(c);
 
-       if (overwrite && (c = tb[IFACE_ATTR_IGNORE]))
-               iface->ignore = blobmsg_get_bool(c);
-
        if ((c = tb[IFACE_ATTR_LEASETIME])) {
                double time = parse_leasetime(c);
-               if (time < 0)
-                       goto err;
 
-               iface->dhcpv4_leasetime = time;
+               if (time >= 0)
+                       iface->dhcp_leasetime = time;
+               else
+                       syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
+                              iface_attrs[IFACE_ATTR_LEASETIME].name, iface->name);
+
+       }
+
+       if ((c = tb[IFACE_ATTR_PREFERRED_LIFETIME])) {
+               double time = parse_leasetime(c);
+
+               if (time >= 0)
+                       iface->preferred_lifetime = time;
+               else
+                       syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
+                              iface_attrs[IFACE_ATTR_PREFERRED_LIFETIME].name, iface->name);
+
        }
 
        if ((c = tb[IFACE_ATTR_START])) {
                iface->dhcpv4_start.s_addr = htonl(blobmsg_get_u32(c));
+               iface->dhcpv4_end.s_addr = htonl(ntohl(iface->dhcpv4_start.s_addr) +
+                                                       LIMIT_DEFAULT - 1);
 
                if (config.main_dhcpv4 && config.legacy)
-                       iface->dhcpv4 = RELAYD_SERVER;
+                       iface->dhcpv4 = MODE_SERVER;
        }
 
        if ((c = tb[IFACE_ATTR_LIMIT]))
-               iface->dhcpv4_end.s_addr = htonl(
-                               ntohl(iface->dhcpv4_start.s_addr) + blobmsg_get_u32(c));
+               iface->dhcpv4_end.s_addr = htonl(ntohl(iface->dhcpv4_start.s_addr) +
+                                                       blobmsg_get_u32(c) - 1);
 
        if ((c = tb[IFACE_ATTR_MASTER]))
                iface->master = blobmsg_get_bool(c);
@@ -470,35 +577,50 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
                }
        }
 
-       int mode;
        if ((c = tb[IFACE_ATTR_RA])) {
-               if ((mode = parse_mode(blobmsg_get_string(c))) >= 0)
+               if ((mode = parse_mode(blobmsg_get_string(c))) >= 0) {
                        iface->ra = mode;
-               else
-                       goto err;
+
+                       if (iface->ra != MODE_DISABLED)
+                               iface->ignore = false;
+               } else
+                       syslog(LOG_ERR, "Invalid %s mode configured for interface '%s'",
+                              iface_attrs[IFACE_ATTR_RA].name, iface->name);
        }
 
        if ((c = tb[IFACE_ATTR_DHCPV4])) {
                if ((mode = parse_mode(blobmsg_get_string(c))) >= 0) {
-                       if (config.main_dhcpv4)
+                       if (config.main_dhcpv4) {
                                iface->dhcpv4 = mode;
-               }
-               else
-                       goto err;
+
+                               if (iface->dhcpv4 != MODE_DISABLED)
+                                       iface->ignore = false;
+                       }
+               } else
+                       syslog(LOG_ERR, "Invalid %s mode configured for interface %s",
+                              iface_attrs[IFACE_ATTR_DHCPV4].name, iface->name);
        }
 
        if ((c = tb[IFACE_ATTR_DHCPV6])) {
-               if ((mode = parse_mode(blobmsg_get_string(c))) >= 0)
+               if ((mode = parse_mode(blobmsg_get_string(c))) >= 0) {
                        iface->dhcpv6 = mode;
-               else
-                       goto err;
+
+                       if (iface->dhcpv6 != MODE_DISABLED)
+                               iface->ignore = false;
+               } else
+                       syslog(LOG_ERR, "Invalid %s mode configured for interface '%s'",
+                              iface_attrs[IFACE_ATTR_DHCPV6].name, iface->name);
        }
 
        if ((c = tb[IFACE_ATTR_NDP])) {
-               if ((mode = parse_mode(blobmsg_get_string(c))) >= 0)
+               if ((mode = parse_mode(blobmsg_get_string(c))) >= 0) {
                        iface->ndp = mode;
-               else
-                       goto err;
+
+                       if (iface->ndp != MODE_DISABLED)
+                               iface->ignore = false;
+               } else
+                       syslog(LOG_ERR, "Invalid %s mode configured for interface '%s'",
+                              iface_attrs[IFACE_ATTR_NDP].name, iface->name);
        }
 
        if ((c = tb[IFACE_ATTR_ROUTER])) {
@@ -506,10 +628,11 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
                unsigned rem;
 
                blobmsg_for_each_attr(cur, c, rem) {
+                       struct in_addr addr4;
+
                        if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING || !blobmsg_check_attr(cur, false))
                                continue;
 
-                       struct in_addr addr4;
                        if (inet_pton(AF_INET, blobmsg_get_string(cur), &addr4) == 1) {
                                iface->dhcpv4_router = realloc(iface->dhcpv4_router,
                                                (++iface->dhcpv4_router_cnt) * sizeof(*iface->dhcpv4_router));
@@ -518,7 +641,8 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
 
                                iface->dhcpv4_router[iface->dhcpv4_router_cnt - 1] = addr4;
                        } else
-                               goto err;
+                               syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
+                                      iface_attrs[IFACE_ATTR_ROUTER].name, iface->name);
                }
        }
 
@@ -528,12 +652,20 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
 
                iface->always_rewrite_dns = true;
                blobmsg_for_each_attr(cur, c, rem) {
+                       struct in_addr addr4;
+                       struct in6_addr addr6;
+
                        if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING || !blobmsg_check_attr(cur, false))
                                continue;
 
-                       struct in_addr addr4;
-                       struct in6_addr addr6;
                        if (inet_pton(AF_INET, blobmsg_get_string(cur), &addr4) == 1) {
+                               if (addr4.s_addr == INADDR_ANY) {
+                                       syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
+                                              iface_attrs[IFACE_ATTR_DNS].name, iface->name);
+
+                                       continue;
+                               }
+
                                iface->dhcpv4_dns = realloc(iface->dhcpv4_dns,
                                                (++iface->dhcpv4_dns_cnt) * sizeof(*iface->dhcpv4_dns));
                                if (!iface->dhcpv4_dns)
@@ -541,6 +673,13 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
 
                                iface->dhcpv4_dns[iface->dhcpv4_dns_cnt - 1] = addr4;
                        } else if (inet_pton(AF_INET6, blobmsg_get_string(cur), &addr6) == 1) {
+                               if (IN6_IS_ADDR_UNSPECIFIED(&addr6)) {
+                                       syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
+                                              iface_attrs[IFACE_ATTR_DNS].name, iface->name);
+
+                                       continue;
+                               }
+
                                iface->dns = realloc(iface->dns,
                                                (++iface->dns_cnt) * sizeof(*iface->dns));
                                if (!iface->dns)
@@ -548,27 +687,40 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
 
                                iface->dns[iface->dns_cnt - 1] = addr6;
                        } else
-                               goto err;
+                               syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
+                                      iface_attrs[IFACE_ATTR_DNS].name, iface->name);
                }
        }
 
+       if ((c = tb[IFACE_ATTR_DNS_SERVICE]))
+               iface->dns_service = blobmsg_get_bool(c);
+
        if ((c = tb[IFACE_ATTR_DOMAIN])) {
                struct blob_attr *cur;
                unsigned rem;
 
                blobmsg_for_each_attr(cur, c, rem) {
-                       if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING || !blobmsg_check_attr(cur, false))
-                               continue;
-
                        uint8_t buf[256];
                        char *domain = blobmsg_get_string(cur);
                        size_t domainlen = strlen(domain);
+                       int len;
+
+                       if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING || !blobmsg_check_attr(cur, false))
+                               continue;
+
+                       domain = blobmsg_get_string(cur);
+                       domainlen = strlen(domain);
+
                        if (domainlen > 0 && domain[domainlen - 1] == '.')
                                domain[domainlen - 1] = 0;
 
-                       int len = dn_comp(domain, buf, sizeof(buf), NULL, NULL);
-                       if (len <= 0)
-                               goto err;
+                       len = dn_comp(domain, buf, sizeof(buf), NULL, NULL);
+                       if (len <= 0) {
+                               syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
+                                      iface_attrs[IFACE_ATTR_DOMAIN].name, iface->name);
+
+                               continue;
+                       }
 
                        iface->search = realloc(iface->search, iface->search_len + len);
                        if (!iface->search)
@@ -584,24 +736,96 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
                memcpy(iface->filter_class, blobmsg_get_string(c), blobmsg_data_len(c) + 1);
        }
 
+       if ((c = tb[IFACE_ATTR_DHCPV4_FORCERECONF]))
+               iface->dhcpv4_forcereconf = blobmsg_get_bool(c);
+
        if ((c = tb[IFACE_ATTR_DHCPV6_RAW])) {
                iface->dhcpv6_raw_len = blobmsg_data_len(c) / 2;
                iface->dhcpv6_raw = realloc(iface->dhcpv6_raw, iface->dhcpv6_raw_len);
                odhcpd_unhexlify(iface->dhcpv6_raw, iface->dhcpv6_raw_len, blobmsg_get_string(c));
        }
 
+       if ((c = tb[IFACE_ATTR_DHCPV6_ASSIGNALL]))
+               iface->dhcpv6_assignall = blobmsg_get_bool(c);
+
+       if ((c = tb[IFACE_ATTR_DHCPV6_PD]))
+               iface->dhcpv6_pd = blobmsg_get_bool(c);
+
+       if ((c = tb[IFACE_ATTR_DHCPV6_NA]))
+               iface->dhcpv6_na = blobmsg_get_bool(c);
+
        if ((c = tb[IFACE_ATTR_RA_DEFAULT]))
                iface->default_router = blobmsg_get_u32(c);
 
-       if ((c = tb[IFACE_ATTR_RA_MANAGEMENT]))
-               iface->managed = blobmsg_get_u32(c);
+       if (!tb[IFACE_ATTR_RA_FLAGS] && !tb[IFACE_ATTR_RA_SLAAC] &&
+           (c = tb[IFACE_ATTR_RA_MANAGEMENT])) {
+               switch (blobmsg_get_u32(c)) {
+               case 0:
+                       iface->ra_flags = ND_RA_FLAG_OTHER;
+                       iface->ra_slaac = true;
+                       break;
+               case 1:
+                       iface->ra_flags = ND_RA_FLAG_OTHER|ND_RA_FLAG_MANAGED;
+                       iface->ra_slaac = true;
+                       break;
+               case 2:
+                       iface->ra_flags = ND_RA_FLAG_OTHER|ND_RA_FLAG_MANAGED;
+                       iface->ra_slaac = false;
+                       break;
+               default:
+                       break;
+               }
+       }
+
+       if ((c = tb[IFACE_ATTR_RA_FLAGS])) {
+               if (parse_ra_flags(&iface->ra_flags, c) < 0)
+                       syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
+                              iface_attrs[IFACE_ATTR_RA_FLAGS].name, iface->name);
+       }
+
+       if ((c = tb[IFACE_ATTR_RA_REACHABLETIME])) {
+               uint32_t ra_reachabletime = blobmsg_get_u32(c);
+
+               if (ra_reachabletime <= 3600000)
+                       iface->ra_reachabletime = ra_reachabletime;
+               else
+                       syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
+                              iface_attrs[IFACE_ATTR_RA_REACHABLETIME].name, iface->name);
+       }
+
+       if ((c = tb[IFACE_ATTR_RA_RETRANSTIME])) {
+               uint32_t ra_retranstime = blobmsg_get_u32(c);
+
+               if (ra_retranstime <= 60000)
+                       iface->ra_retranstime = ra_retranstime;
+               else
+                       syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
+                              iface_attrs[IFACE_ATTR_RA_RETRANSTIME].name, iface->name);
+       }
+
+       if ((c = tb[IFACE_ATTR_RA_HOPLIMIT])) {
+               uint32_t ra_hoplimit = blobmsg_get_u32(c);
+
+               if (ra_hoplimit <= 255)
+                       iface->ra_hoplimit = ra_hoplimit;
+               else
+                       syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
+                              iface_attrs[IFACE_ATTR_RA_HOPLIMIT].name, iface->name);
+       }
 
        if ((c = tb[IFACE_ATTR_RA_MTU])) {
-               iface->ra_mtu = blobmsg_get_u32(c);
-               if (iface->ra_mtu < 1280)
-                       goto err;
+               uint32_t ra_mtu = blobmsg_get_u32(c);
+
+               if (ra_mtu >= 1280 || ra_mtu <= 65535)
+                       iface->ra_mtu = ra_mtu;
+               else
+                       syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
+                              iface_attrs[IFACE_ATTR_RA_MTU].name, iface->name);
        }
 
+       if ((c = tb[IFACE_ATTR_RA_SLAAC]))
+               iface->ra_slaac = blobmsg_get_bool(c);
+
        if ((c = tb[IFACE_ATTR_RA_OFFLINK]))
                iface->ra_not_onlink = blobmsg_get_bool(c);
 
@@ -620,6 +844,9 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
        if ((c = tb[IFACE_ATTR_RA_USELEASETIME]))
                iface->ra_useleasetime = blobmsg_get_bool(c);
 
+       if ((c = tb[IFACE_ATTR_RA_DNS]))
+               iface->ra_dns = blobmsg_get_bool(c);
+
        if ((c = tb[IFACE_ATTR_RA_PREFERENCE])) {
                const char *prio = blobmsg_get_string(c);
 
@@ -630,7 +857,8 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
                else if (!strcmp(prio, "medium") || !strcmp(prio, "default"))
                        iface->route_preference = 0;
                else
-                       goto err;
+                       syslog(LOG_ERR, "Invalid %s mode configured for interface '%s'",
+                              iface_attrs[IFACE_ATTR_RA_PREFERENCE].name, iface->name);
        }
 
        if ((c = tb[IFACE_ATTR_PD_MANAGER]))
@@ -639,7 +867,8 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
 
        if ((c = tb[IFACE_ATTR_PD_CER]) &&
                        inet_pton(AF_INET6, blobmsg_get_string(c), &iface->dhcpv6_pd_cer) < 1)
-               goto err;
+               syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
+                      iface_attrs[IFACE_ATTR_PD_CER].name, iface->name);
 
        if ((c = tb[IFACE_ATTR_NDPROXY_ROUTING]))
                iface->learn_routes = blobmsg_get_bool(c);
@@ -647,6 +876,24 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
        if ((c = tb[IFACE_ATTR_NDPROXY_SLAVE]))
                iface->external = blobmsg_get_bool(c);
 
+       if ((c = tb[IFACE_ATTR_PREFIX_FILTER])) {
+               const char *str = blobmsg_get_string(c);
+               char *astr = malloc(strlen(str) + 1);
+               char *delim;
+               int l;
+
+               if (!astr || !strcpy(astr, str) ||
+                               (delim = strchr(astr, '/')) == NULL || (*(delim++) = 0) ||
+                               sscanf(delim, "%i", &l) == 0 || l > 128 ||
+                               inet_pton(AF_INET6, astr, &iface->pio_filter_addr) == 0)
+                       iface->pio_filter_length = 0;
+               else
+                       iface->pio_filter_length = l;
+
+               if (astr)
+                       free(astr);
+       }
+
        return 0;
 
 err:
@@ -662,37 +909,194 @@ static int set_interface(struct uci_section *s)
        return config_parse_interface(blob_data(b.head), blob_len(b.head), s->e.name, true);
 }
 
-void odhcpd_reload(void)
+static void lease_delete_assignments(struct lease *l, bool v6)
 {
-       struct uci_context *uci = uci_alloc_context();
+       struct dhcp_assignment *a, *tmp;
+       unsigned int flag = v6 ? OAF_DHCPV6 : OAF_DHCPV4;
+
+       list_for_each_entry_safe(a, tmp, &l->assignments, lease_list) {
+               if (a->flags & flag)
+                       free_assignment(a);
+       }
+}
+
+static void lease_update_assignments(struct lease *l)
+{
+       struct dhcp_assignment *a;
+
+       list_for_each_entry(a, &l->assignments, lease_list) {
+               if (a->hostname)
+                       free(a->hostname);
+               a->hostname = NULL;
+
+               if (l->hostname)
+                       a->hostname = strdup(l->hostname);
+
+               a->leasetime = l->leasetime;
+       }
+}
+
+static int lease_cmp(const void *k1, const void *k2, _unused void *ptr)
+{
+       const struct lease *l1 = k1, *l2 = k2;
+       int cmp = 0;
+
+       if (l1->duid_len != l2->duid_len)
+               return l1->duid_len - l2->duid_len;
+
+       if (l1->duid_len && l2->duid_len)
+               cmp = memcmp(l1->duid, l2->duid, l1->duid_len);
+
+       if (cmp)
+               return cmp;
+
+       return memcmp(l1->mac.ether_addr_octet, l2->mac.ether_addr_octet,
+                     sizeof(l1->mac.ether_addr_octet));
+}
 
-       while (!list_empty(&leases))
-               free_lease(list_first_entry(&leases, struct lease, head));
+static void lease_change_config(struct lease *l_old, struct lease *l_new)
+{
+       bool update = false;
+
+       if ((!!l_new->hostname != !!l_old->hostname) ||
+           (l_new->hostname && strcmp(l_new->hostname, l_old->hostname))) {
+               free(l_old->hostname);
+               l_old->hostname = NULL;
+
+               if (l_new->hostname)
+                       l_old->hostname = strdup(l_new->hostname);
+
+               update = true;
+       }
+
+       if (l_old->leasetime != l_new->leasetime) {
+               l_old->leasetime = l_new->leasetime;
+               update = true;
+       }
+
+       if (l_old->ipaddr != l_new->ipaddr) {
+               l_old->ipaddr = l_new->ipaddr;
+               lease_delete_assignments(l_old, false);
+       }
+
+       if (l_old->hostid != l_new->hostid) {
+               l_old->hostid = l_new->hostid;
+               lease_delete_assignments(l_old, true);
+       }
+
+       if (update)
+               lease_update_assignments(l_old);
+
+       free_lease(l_new);
+}
+
+static void lease_delete(struct lease *l)
+{
+       struct dhcp_assignment *a, *tmp;
+
+       list_for_each_entry_safe(a, tmp, &l->assignments, lease_list)
+               free_assignment(a);
+
+       free_lease(l);
+}
+
+static void lease_update(_unused struct vlist_tree *tree, struct vlist_node *node_new,
+                        struct vlist_node *node_old)
+{
+       struct lease *lease_new = container_of(node_new, struct lease, node);
+       struct lease *lease_old = container_of(node_old, struct lease, node);
+
+       if (node_old && node_new)
+               lease_change_config(lease_old, lease_new);
+       else if (node_old)
+               lease_delete(lease_old);
+}
+
+struct lease *config_find_lease_by_duid(const uint8_t *duid, const uint16_t len)
+{
+       struct lease *l;
+
+       vlist_for_each_element(&leases, l, node) {
+               if (l->duid_len == len && !memcmp(l->duid, duid, len))
+                       return l;
+       }
+
+       return NULL;
+}
+
+struct lease *config_find_lease_by_mac(const uint8_t *mac)
+{
+       struct lease *l;
 
-       struct interface *master = NULL, *i, *n;
+       vlist_for_each_element(&leases, l, node) {
+               if (!memcmp(l->mac.ether_addr_octet, mac,
+                           sizeof(l->mac.ether_addr_octet)))
+                       return l;
+       }
+
+       return NULL;
+}
+
+struct lease *config_find_lease_by_hostid(const uint32_t hostid)
+{
+       struct lease *l;
+
+       vlist_for_each_element(&leases, l, node) {
+               if (l->hostid == hostid)
+                       return l;
+       }
+
+       return NULL;
+}
+
+struct lease *config_find_lease_by_ipaddr(const uint32_t ipaddr)
+{
+       struct lease *l;
+
+       vlist_for_each_element(&leases, l, node) {
+               if (l->ipaddr == ipaddr)
+                       return l;
+       }
+
+       return NULL;
+}
+
+void odhcpd_reload(void)
+{
+       struct uci_context *uci = uci_alloc_context();
+       struct interface *master = NULL, *i, *tmp;
 
        if (!uci)
                return;
 
-       list_for_each_entry(i, &interfaces, head)
+       vlist_update(&leases);
+       avl_for_each_element(&interfaces, i, avl)
                clean_interface(i);
 
        struct uci_package *dhcp = NULL;
        if (!uci_load(uci, "dhcp", &dhcp)) {
                struct uci_element *e;
+
+               /* 1. Global settings */
                uci_foreach_element(&dhcp->sections, e) {
                        struct uci_section *s = uci_to_section(e);
-                       if (!strcmp(s->type, "host"))
-                               set_lease(s);
-                       else if (!strcmp(s->type, "odhcpd"))
+                       if (!strcmp(s->type, "odhcpd"))
                                set_config(s);
                }
 
+               /* 2. DHCP pools */
                uci_foreach_element(&dhcp->sections, e) {
                        struct uci_section *s = uci_to_section(e);
                        if (!strcmp(s->type, "dhcp"))
                                set_interface(s);
                }
+
+               /* 3. Static leases */
+               uci_foreach_element(&dhcp->sections, e) {
+                       struct uci_section* s = uci_to_section(e);
+                       if (!strcmp(s->type, "host"))
+                               set_lease_from_uci(s);
+               }
        }
 
        if (config.dhcp_statefile) {
@@ -702,6 +1106,8 @@ void odhcpd_reload(void)
                free(path);
        }
 
+       vlist_flush(&leases);
+
 #ifdef WITH_UBUS
        ubus_apply_network();
 #endif
@@ -709,78 +1115,79 @@ void odhcpd_reload(void)
        bool any_dhcpv6_slave = false, any_ra_slave = false, any_ndp_slave = false;
 
        /* Test for */
-       list_for_each_entry(i, &interfaces, head) {
+       avl_for_each_element(&interfaces, i, avl) {
                if (i->master)
                        continue;
 
-               if (i->dhcpv6 == RELAYD_HYBRID || i->dhcpv6 == RELAYD_RELAY)
+               if (i->dhcpv6 == MODE_HYBRID || i->dhcpv6 == MODE_RELAY)
                        any_dhcpv6_slave = true;
 
-               if (i->ra == RELAYD_HYBRID || i->ra == RELAYD_RELAY)
+               if (i->ra == MODE_HYBRID || i->ra == MODE_RELAY)
                        any_ra_slave = true;
 
-               if (i->ndp == RELAYD_HYBRID || i->ndp == RELAYD_RELAY)
+               if (i->ndp == MODE_HYBRID || i->ndp == MODE_RELAY)
                        any_ndp_slave = true;
        }
 
        /* Evaluate hybrid mode for master */
-       list_for_each_entry(i, &interfaces, head) {
+       avl_for_each_element(&interfaces, i, avl) {
                if (!i->master)
                        continue;
 
-               enum odhcpd_mode hybrid_mode = RELAYD_DISABLED;
+               enum odhcpd_mode hybrid_mode = MODE_DISABLED;
 #ifdef WITH_UBUS
                if (!ubus_has_prefix(i->name, i->ifname))
-                       hybrid_mode = RELAYD_RELAY;
+                       hybrid_mode = MODE_RELAY;
 #endif
 
-               if (i->dhcpv6 == RELAYD_HYBRID)
+               if (i->dhcpv6 == MODE_HYBRID)
                        i->dhcpv6 = hybrid_mode;
 
-               if (i->dhcpv6 == RELAYD_RELAY && !any_dhcpv6_slave)
-                       i->dhcpv6 = RELAYD_DISABLED;
+               if (i->dhcpv6 == MODE_RELAY && !any_dhcpv6_slave)
+                       i->dhcpv6 = MODE_DISABLED;
 
-               if (i->ra == RELAYD_HYBRID)
+               if (i->ra == MODE_HYBRID)
                        i->ra = hybrid_mode;
 
-               if (i->ra == RELAYD_RELAY && !any_ra_slave)
-                       i->ra = RELAYD_DISABLED;
+               if (i->ra == MODE_RELAY && !any_ra_slave)
+                       i->ra = MODE_DISABLED;
 
-               if (i->ndp == RELAYD_HYBRID)
+               if (i->ndp == MODE_HYBRID)
                        i->ndp = hybrid_mode;
 
-               if (i->ndp == RELAYD_RELAY && !any_ndp_slave)
-                       i->ndp = RELAYD_DISABLED;
+               if (i->ndp == MODE_RELAY && !any_ndp_slave)
+                       i->ndp = MODE_DISABLED;
 
-               if (i->dhcpv6 == RELAYD_RELAY || i->ra == RELAYD_RELAY || i->ndp == RELAYD_RELAY)
+               if (i->dhcpv6 == MODE_RELAY || i->ra == MODE_RELAY || i->ndp == MODE_RELAY)
                        master = i;
        }
 
 
-       list_for_each_entry_safe(i, n, &interfaces, head) {
+       avl_for_each_element_safe(&interfaces, i, avl, tmp) {
                if (i->inuse) {
                        /* Resolve hybrid mode */
-                       if (i->dhcpv6 == RELAYD_HYBRID)
-                               i->dhcpv6 = (master && master->dhcpv6 == RELAYD_RELAY) ?
-                                               RELAYD_RELAY : RELAYD_SERVER;
-
-                       if (i->ra == RELAYD_HYBRID)
-                               i->ra = (master && master->ra == RELAYD_RELAY) ?
-                                               RELAYD_RELAY : RELAYD_SERVER;
-
-                       if (i->ndp == RELAYD_HYBRID)
-                               i->ndp = (master && master->ndp == RELAYD_RELAY) ?
-                                               RELAYD_RELAY : RELAYD_DISABLED;
-
-                       setup_router_interface(i, !i->ignore || i->ra != RELAYD_DISABLED);
-                       setup_dhcpv6_interface(i, !i->ignore || i->dhcpv6 != RELAYD_DISABLED);
-                       setup_ndp_interface(i, !i->ignore || i->ndp != RELAYD_DISABLED);
-                       setup_dhcpv4_interface(i, !i->ignore || i->dhcpv4 != RELAYD_DISABLED);
+                       if (i->dhcpv6 == MODE_HYBRID)
+                               i->dhcpv6 = (master && master->dhcpv6 == MODE_RELAY) ?
+                                               MODE_RELAY : MODE_SERVER;
+
+                       if (i->ra == MODE_HYBRID)
+                               i->ra = (master && master->ra == MODE_RELAY) ?
+                                               MODE_RELAY : MODE_SERVER;
+
+                       if (i->ndp == MODE_HYBRID)
+                               i->ndp = (master && master->ndp == MODE_RELAY) ?
+                                               MODE_RELAY : MODE_DISABLED;
+
+                       router_setup_interface(i, i->ra != MODE_DISABLED);
+                       dhcpv6_setup_interface(i, i->dhcpv6 != MODE_DISABLED);
+                       ndp_setup_interface(i, i->ndp != MODE_DISABLED);
+#ifdef DHCPV4_SUPPORT
+                       dhcpv4_setup_interface(i, i->dhcpv4 != MODE_DISABLED);
+#endif
                } else
                        close_interface(i);
        }
 
-       ndp_handle_addr6_dump();
        uci_unload(uci, dhcp);
        uci_free_context(uci);
 }
@@ -803,7 +1210,7 @@ static void reload_cb(struct uloop_fd *u, _unused unsigned int events)
        odhcpd_reload();
 }
 
-static struct uloop_fd reload_fd = { .cb = reload_cb };
+static struct uloop_fd reload_fd = { .fd = -1, .cb = reload_cb };
 
 void odhcpd_run(void)
 {
@@ -817,14 +1224,10 @@ void odhcpd_run(void)
        signal(SIGHUP, handle_signal);
 
 #ifdef WITH_UBUS
-       while (init_ubus())
+       while (ubus_init())
                sleep(1);
 #endif
 
        odhcpd_reload();
        uloop_run();
-
-       while (!list_empty(&interfaces))
-               close_interface(list_first_entry(&interfaces, struct interface, head));
 }
-