From 710f2ab5c9891d654985f605d5a09061137d8731 Mon Sep 17 00:00:00 2001 From: Hans Dedecker Date: Mon, 7 May 2018 17:59:47 +0200 Subject: [PATCH] dhcpv4: fix out of bound access in dhcpv4_put Detected by Coverity in CID 1433363 and 1432121 Signed-off-by: Hans Dedecker --- src/dhcpv4.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/dhcpv4.c b/src/dhcpv4.c index 81e537d..88727ac 100644 --- a/src/dhcpv4.c +++ b/src/dhcpv4.c @@ -241,7 +241,9 @@ static void dhcpv4_put(struct dhcpv4_message *msg, uint8_t **cookie, uint8_t type, uint8_t len, const void *data) { uint8_t *c = *cookie; - if (*cookie + 2 + len > (uint8_t*)&msg[1]) + uint8_t *end = (uint8_t *)msg + sizeof(*msg); + + if (*cookie + 2 + len > end) return; *c++ = type; -- 2.30.2