opkg_download: print error when fork() fails
authorJo-Philipp Wich <jo@mein.io>
Fri, 14 Dec 2018 07:13:38 +0000 (08:13 +0100)
committerJo-Philipp Wich <jo@mein.io>
Fri, 14 Dec 2018 07:13:51 +0000 (08:13 +0100)
Instead of silently failing and claiming that the signature verification
failed, print out the error status when the initial fork() call fails.

Ref: https://bugs.openwrt.org/index.php?do=details&task_id=1999
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
libopkg/opkg_download.c

index 51d43b3..f9e7e98 100644 (file)
@@ -306,8 +306,10 @@ int opkg_verify_file(char *text_file, char *sig_file)
                return 0;
 
        pid = fork();
-       if (pid < 0)
+       if (pid < 0) {
+               opkg_perror(ERROR, "Failed to fork opkg-key process");
                return -1;
+       }
 
        if (!pid) {
                execl("/usr/sbin/opkg-key", "opkg-key", "verify", sig_file,