uclient-fetch: fix statement may fallt hrough
[project/uclient.git] / uclient-fetch.c
index ebf49ae559ac395fbd069ab53c3d1e29da42f4be..0c7a1232f2565c96beb8a31fd83c460ebb6d987e 100644 (file)
@@ -18,6 +18,7 @@
 
 #define _GNU_SOURCE
 #include <sys/stat.h>
+#include <sys/socket.h>
 #include <unistd.h>
 #include <stdio.h>
 #include <dlfcn.h>
@@ -42,6 +43,7 @@
 
 static const char *user_agent = "uclient-fetch";
 static const char *post_data;
+static const char *post_file;
 static struct ustream_ssl_ctx *ssl_ctx;
 static const struct ustream_ssl_ops *ssl_ops;
 static int quiet = false;
@@ -49,7 +51,7 @@ static bool verify = true;
 static bool proxy = true;
 static bool default_certs = false;
 static bool no_output;
-static const char *output_file;
+static const char *opt_output_file;
 static int output_fd = -1;
 static int error_ret;
 static off_t out_offset;
@@ -96,6 +98,7 @@ get_proxy_url(char *url)
 
 static int open_output_file(const char *path, uint64_t resume_offset)
 {
+       const char *output_file = opt_output_file;
        char *filename = NULL;
        int flags;
        int ret;
@@ -103,7 +106,7 @@ static int open_output_file(const char *path, uint64_t resume_offset)
        if (cur_resume)
                flags = O_RDWR;
        else
-               flags = O_WRONLY;
+               flags = O_WRONLY | O_TRUNC;
 
        if (!cur_resume && !output_file)
                flags |= O_EXCL;
@@ -120,6 +123,11 @@ static int open_output_file(const char *path, uint64_t resume_offset)
                }
        } else {
                filename = uclient_get_url_filename(path, "index.html");
+               if (!filename) {
+                       ret = -ENOMEM;
+                       goto out;
+               }
+
                output_file = filename;
        }
 
@@ -149,6 +157,7 @@ done:
 
 free:
        free(filename);
+out:
        return ret;
 }
 
@@ -224,6 +233,7 @@ static void header_done_cb(struct uclient *cl)
                        error_ret = 8;
                        break;
                }
+               /* fall through */
        case 204:
        case 200:
                if (no_output)
@@ -253,6 +263,7 @@ static void header_done_cb(struct uclient *cl)
 static void read_data_cb(struct uclient *cl)
 {
        char buf[256];
+       ssize_t n;
        int len;
 
        if (!no_output && output_fd < 0)
@@ -260,12 +271,15 @@ static void read_data_cb(struct uclient *cl)
 
        while (1) {
                len = uclient_read(cl, buf, sizeof(buf));
-               if (!len)
+               if (len <= 0)
                        return;
 
                out_bytes += len;
-               if (!no_output)
-                       write(output_fd, buf, len);
+               if (!no_output) {
+                       n = write(output_fd, buf, len);
+                       if (n < 0)
+                               return;
+               }
        }
 }
 
@@ -322,7 +336,7 @@ static int init_request(struct uclient *cl)
 
        msg_connecting(cl);
 
-       rc = uclient_http_set_request_type(cl, post_data ? "POST" : "GET");
+       rc = uclient_http_set_request_type(cl, post_data || post_file ? "POST" : "GET");
        if (rc)
                return rc;
 
@@ -335,6 +349,26 @@ static int init_request(struct uclient *cl)
                uclient_http_set_header(cl, "Content-Type", "application/x-www-form-urlencoded");
                uclient_write(cl, post_data, strlen(post_data));
        }
+       else if(post_file)
+       {
+               FILE *input_file;
+               uclient_http_set_header(cl, "Content-Type", "application/x-www-form-urlencoded");
+
+               input_file = fopen(post_file, "r");
+               if (!input_file)
+                       return errno;
+
+               char tbuf[1024];
+               size_t rlen = 0;
+               do
+               {
+                       rlen = fread(tbuf, 1, sizeof(tbuf), input_file);
+                       uclient_write(cl, tbuf, rlen);
+               }
+               while(rlen);
+
+               fclose(input_file);
+       }
 
        rc = uclient_request(cl);
        if (rc)
@@ -362,7 +396,7 @@ static void request_done(struct uclient *cl)
                        return;
        }
 
-       if (output_fd >= 0 && !output_file) {
+       if (output_fd >= 0 && !opt_output_file) {
                close(output_fd);
                output_fd = -1;
        }
@@ -439,20 +473,24 @@ static int usage(const char *progname)
        fprintf(stderr,
                "Usage: %s [options] <URL>\n"
                "Options:\n"
-               "       -q:                             Turn off status messages\n"
-               "       -O <file>:                      Redirect output to file (use \"-\" for stdout)\n"
-               "       -P <dir>:                       Set directory for output files\n"
+               "       -4                              Use IPv4 only\n"
+               "       -6                              Use IPv6 only\n"
+               "       -q                              Turn off status messages\n"
+               "       -O <file>                       Redirect output to file (use \"-\" for stdout)\n"
+               "       -P <dir>                        Set directory for output files\n"
                "       --user=<user>                   HTTP authentication username\n"
                "       --password=<password>           HTTP authentication password\n"
                "       --user-agent|-U <str>           Set HTTP user agent\n"
                "       --post-data=STRING              use the POST method; send STRING as the data\n"
+               "       --post-file=FILE                use the POST method; send FILE as the data\n"
                "       --spider|-s                     Spider mode - only check file existence\n"
                "       --timeout=N|-T N                Set connect/request timeout to N seconds\n"
                "       --proxy=on|off|-Y on|off        Enable/disable env var configured proxy\n"
                "\n"
                "HTTPS options:\n"
-               "       --ca-certificate=<cert>:        Load CA certificates from file <cert>\n"
-               "       --no-check-certificate:         don't validate the server's certificate\n"
+               "       --ca-certificate=<cert>         Load CA certificates from file <cert>\n"
+               "       --no-check-certificate          don't validate the server's certificate\n"
+               "       --ciphers=<cipherlist>          Set the cipher list string\n"
                "\n", progname);
        return 1;
 }
@@ -460,7 +498,7 @@ static int usage(const char *progname)
 static void init_ca_cert(void)
 {
        glob_t gl;
-       int i;
+       unsigned int i;
 
        glob("/etc/ssl/certs/*.crt", 0, NULL, &gl);
        for (i = 0; i < gl.gl_pathc; i++)
@@ -484,36 +522,47 @@ static void init_ustream_ssl(void)
 
 static int no_ssl(const char *progname)
 {
-       fprintf(stderr, "%s: SSL support not available, please install ustream-ssl\n", progname);
+       fprintf(stderr,
+               "%s: SSL support not available, please install one of the "
+               "libustream-.*[ssl|tls] packages as well as the ca-bundle and "
+               "ca-certificates packages.\n",
+               progname);
+
        return 1;
 }
 
 enum {
        L_NO_CHECK_CERTIFICATE,
        L_CA_CERTIFICATE,
+       L_CIPHERS,
        L_USER,
        L_PASSWORD,
        L_USER_AGENT,
        L_POST_DATA,
+       L_POST_FILE,
        L_SPIDER,
        L_TIMEOUT,
        L_CONTINUE,
        L_PROXY,
        L_NO_PROXY,
+       L_QUIET,
 };
 
 static const struct option longopts[] = {
-       [L_NO_CHECK_CERTIFICATE] = { "no-check-certificate", no_argument },
-       [L_CA_CERTIFICATE] = { "ca-certificate", required_argument },
-       [L_USER] = { "user", required_argument },
-       [L_PASSWORD] = { "password", required_argument },
-       [L_USER_AGENT] = { "user-agent", required_argument },
-       [L_POST_DATA] = { "post-data", required_argument },
-       [L_SPIDER] = { "spider", no_argument },
-       [L_TIMEOUT] = { "timeout", required_argument },
-       [L_CONTINUE] = { "continue", no_argument },
-       [L_PROXY] = { "proxy", required_argument },
-       [L_NO_PROXY] = { "no-proxy", no_argument },
+       [L_NO_CHECK_CERTIFICATE] = { "no-check-certificate", no_argument, NULL, 0 },
+       [L_CA_CERTIFICATE] = { "ca-certificate", required_argument, NULL, 0 },
+       [L_CIPHERS] = { "ciphers", required_argument, NULL, 0 },
+       [L_USER] = { "user", required_argument, NULL, 0 },
+       [L_PASSWORD] = { "password", required_argument, NULL, 0 },
+       [L_USER_AGENT] = { "user-agent", required_argument, NULL, 0 },
+       [L_POST_DATA] = { "post-data", required_argument, NULL, 0 },
+       [L_POST_FILE] = { "post-file", required_argument, NULL, 0 },
+       [L_SPIDER] = { "spider", no_argument, NULL, 0 },
+       [L_TIMEOUT] = { "timeout", required_argument, NULL, 0 },
+       [L_CONTINUE] = { "continue", no_argument, NULL, 0 },
+       [L_PROXY] = { "proxy", required_argument, NULL, 0 },
+       [L_NO_PROXY] = { "no-proxy", no_argument, NULL, 0 },
+       [L_QUIET] = { "quiet", no_argument, NULL, 0 },
        {}
 };
 
@@ -530,11 +579,12 @@ int main(int argc, char **argv)
        bool has_cert = false;
        int i, ch;
        int rc;
+       int af = -1;
 
        signal(SIGPIPE, SIG_IGN);
        init_ustream_ssl();
 
-       while ((ch = getopt_long(argc, argv, "cO:P:qsT:U:Y:", longopts, &longopt_idx)) != -1) {
+       while ((ch = getopt_long(argc, argv, "46cO:P:qsT:U:Y:", longopts, &longopt_idx)) != -1) {
                switch(ch) {
                case 0:
                        switch (longopt_idx) {
@@ -546,6 +596,15 @@ int main(int argc, char **argv)
                                if (ssl_ctx)
                                        ssl_ops->context_add_ca_crt_file(ssl_ctx, optarg);
                                break;
+                       case L_CIPHERS:
+                               if (ssl_ctx) {
+                                       if (ssl_ops->context_set_ciphers(ssl_ctx, optarg)) {
+                                               if (!quiet)
+                                                       fprintf(stderr, "No recognized ciphers in cipher list\n");
+                                               exit(1);
+                                       }
+                               }
+                               break;
                        case L_USER:
                                if (!strlen(optarg))
                                        break;
@@ -564,6 +623,9 @@ int main(int argc, char **argv)
                        case L_POST_DATA:
                                post_data = optarg;
                                break;
+                       case L_POST_FILE:
+                               post_file = optarg;
+                               break;
                        case L_SPIDER:
                                no_output = true;
                                break;
@@ -580,10 +642,19 @@ int main(int argc, char **argv)
                        case L_NO_PROXY:
                                proxy = false;
                                break;
+                       case L_QUIET:
+                               quiet = true;
+                               break;
                        default:
                                return usage(progname);
                        }
                        break;
+               case '4':
+                       af = AF_INET;
+                       break;
+               case '6':
+                       af = AF_INET6;
+                       break;
                case 'c':
                        resume = true;
                        break;
@@ -591,7 +662,7 @@ int main(int argc, char **argv)
                        user_agent = optarg;
                        break;
                case 'O':
-                       output_file = optarg;
+                       opt_output_file = optarg;
                        break;
                case 'P':
                        if (chdir(optarg)) {
@@ -640,9 +711,11 @@ int main(int argc, char **argv)
        uloop_init();
 
        if (username) {
-               if (password)
-                       asprintf(&auth_str, "%s:%s", username, password);
-               else
+               if (password) {
+                       rc = asprintf(&auth_str, "%s:%s", username, password);
+                       if (rc < 0)
+                               return rc;
+               } else
                        auth_str = username;
        }
 
@@ -652,7 +725,8 @@ int main(int argc, char **argv)
        proxy_url = get_proxy_url(argv[0]);
        if (proxy_url) {
                cl = uclient_new(proxy_url, auth_str, &cb);
-               uclient_set_proxy_url(cl, argv[0], NULL);
+               if (cl)
+                   uclient_set_proxy_url(cl, argv[0], NULL);
        } else {
                cl = uclient_new(argv[0], auth_str, &cb);
        }
@@ -660,6 +734,8 @@ int main(int argc, char **argv)
                fprintf(stderr, "Failed to allocate uclient context\n");
                return 1;
        }
+       if (af >= 0)
+           uclient_http_set_address_family(cl, af);
 
        if (ssl_ctx && default_certs)
                init_ca_cert();
@@ -670,7 +746,7 @@ int main(int argc, char **argv)
                /* no error received, we can enter main loop */
                uloop_run();
        } else {
-               fprintf(stderr, "Failed to establish connection\n");
+               fprintf(stderr, "Failed to send request: %s\n", strerror(rc));
                error_ret = 4;
        }