uclient: fix initialized but never read variable
authorPetr Štetiar <ynezz@true.cz>
Tue, 8 Dec 2020 16:41:44 +0000 (17:41 +0100)
committerPetr Štetiar <ynezz@true.cz>
Fri, 11 Dec 2020 10:17:22 +0000 (11:17 +0100)
Fixes following issue reported by clang-12 static analyzer:

 uclient.c:290:22: warning: Value stored to 'url' during its initialization is never read [deadcode.DeadStores]
         struct uclient_url *url = cl->url;
                             ^~~   ~~~~~~~

Signed-off-by: Petr Štetiar <ynezz@true.cz>
uclient.c

index 95e4585..a372d4a 100644 (file)
--- a/uclient.c
+++ b/uclient.c
@@ -287,7 +287,7 @@ int uclient_set_proxy_url(struct uclient *cl, const char *url_str, const char *a
 int uclient_set_url(struct uclient *cl, const char *url_str, const char *auth_str)
 {
        const struct uclient_backend *backend = cl->backend;
-       struct uclient_url *url = cl->url;
+       struct uclient_url *url;
 
        url = uclient_get_url(url_str, auth_str);
        if (!url)