summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHannu Nyman2026-02-01 16:28:57 +0000
committerRobert Marko2026-02-02 08:47:41 +0000
commitb800595a38fc572340bba9bdb851843d38a88aa5 (patch)
treeaffdaafeb3fd9fff34ccbde5c3c869dba3cae13f
parentb7cd16dba3259279643705a6bbed21abe1330586 (diff)
downloadopenwrt-b800595a38fc572340bba9bdb851843d38a88aa5.tar.gz
netifd: ensure netifd_loglevel default value as fallback
Commit 168d5af added the possibility to configure netifd logging level. The option is read from /etc/config/network and validated. Supposedly the validation sets 2 as default. But in case of a syntax error in /etc/config/network, the validation result can be empty. Then the always passed option to netifd is just '-l' instead of '-l 2'. That crashes netifd and prevents network from launching. Add a fallback value to the variable, so that there will always be a proper value after the '-l' option. Improves: 168d5af "netifd: add loglevel config option (fixes #18001)" Fixes: #21816 Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi> Link: https://github.com/openwrt/openwrt/pull/21819 Signed-off-by: Robert Marko <robimarko@gmail.com>
-rwxr-xr-xpackage/network/config/netifd/files/etc/init.d/network2
1 files changed, 1 insertions, 1 deletions
diff --git a/package/network/config/netifd/files/etc/init.d/network b/package/network/config/netifd/files/etc/init.d/network
index 6df43be1ac..8a3bf5b9b1 100755
--- a/package/network/config/netifd/files/etc/init.d/network
+++ b/package/network/config/netifd/files/etc/init.d/network
@@ -19,7 +19,7 @@ start_service() {
procd_open_instance
procd_set_param command /sbin/netifd
- procd_append_param command -l ${netifd_loglevel}
+ procd_append_param command -l ${netifd_loglevel:-2}
procd_set_param respawn
procd_set_param watch network.interface
[ -e /proc/sys/kernel/core_pattern ] && {