buildbot, branch v18

buildworker: start: fix worker startup failure after update

2024-09-26T21:21:09Z

Workers are currently refusing to work: Unhandled Error Traceback (most recent call last): File "/opt/venv/lib/python3.11/site-packages/twisted/application/app.py", line 673, in run runApp(config) File "/opt/venv/lib/python3.11/site-packages/twisted/scripts/twistd.py", line 29, in runApp runner.run() File "/opt/venv/lib/python3.11/site-packages/twisted/application/app.py", line 370, in run self.application = self.createOrGetApplication() File "/opt/venv/lib/python3.11/site-packages/twisted/application/app.py", line 437, in createOrGetApplication application = getApplication(self.config, passphrase) --- --- File "/opt/venv/lib/python3.11/site-packages/twisted/application/app.py", line 446, in getApplication application = service.loadApplication(filename, style, passphrase) File "/opt/venv/lib/python3.11/site-packages/twisted/application/service.py", line 404, in loadApplication application = sob.loadValueFromFile(filename, "application") File "/opt/venv/lib/python3.11/site-packages/twisted/persisted/sob.py", line 174, in loadValueFromFile codeObj = compile(data, filename, "exec") builtins.SyntaxError: keyword argument repeated: connection_string (buildbot.tac, line 49) as the buildbot.tac template changed in commit 4ba1dcb66155 ("worker: Add option --connection-string for create-worker") and in version v3.10.0. So lets use this new `--connection-string` feature and get rid of the sed-fu. Fixes: efbddc90d8e6 ("Bump buildbot to v3.11.1 release") Signed-off-by: Petr Štetiar

ci: fix worker startup issue by adding missing env vars and cleanup unused vars

2024-09-26T21:21:00Z

Workers are currently refusing to work: Unhandled Error Traceback (most recent call last): File "/opt/venv/lib/python3.11/site-packages/twisted/application/app.py", line 673, in run runApp(config) File "/opt/venv/lib/python3.11/site-packages/twisted/scripts/twistd.py", line 29, in runApp runner.run() File "/opt/venv/lib/python3.11/site-packages/twisted/application/app.py", line 370, in run self.application = self.createOrGetApplication() File "/opt/venv/lib/python3.11/site-packages/twisted/application/app.py", line 437, in createOrGetApplication application = getApplication(self.config, passphrase) --- --- File "/opt/venv/lib/python3.11/site-packages/twisted/application/app.py", line 446, in getApplication application = service.loadApplication(filename, style, passphrase) File "/opt/venv/lib/python3.11/site-packages/twisted/application/service.py", line 404, in loadApplication application = sob.loadValueFromFile(filename, "application") File "/opt/venv/lib/python3.11/site-packages/twisted/persisted/sob.py", line 174, in loadValueFromFile codeObj = compile(data, filename, "exec") builtins.SyntaxError: keyword argument repeated: connection_string (buildbot.tac, line 49) and we're not aware about it, so lets fix it by adding the same environment variables we're actually using in production. While at it, cleanup the unused container_verify_string variables. Signed-off-by: Petr Štetiar

buildworker: Drop installation of Python 2

2024-09-26T11:19:17Z

Old releases of OpenWrt would require it but that's something of the past - time is running. Signed-off-by: Paul Spooren

buildworker,buildmaster: Use venv for Pip

2024-09-26T11:19:16Z

Debian 12 complains if using Pip without a virtualenv since it could break the system. Signed-off-by: Paul Spooren

buildworker,buildmaster: bump Debian to version 12

2024-09-26T08:05:21Z

Debian 11 LTS support ends in June 2026, so it's probably around the time when support for the OpenWrt 24.10 release might end. Therefore, let's switch to Debian 12, which should have LTS support until June 2028 and is the latest and greatest. Signed-off-by: Petr Štetiar

Bump buildbot to v3.11.7 release

2024-09-26T08:04:23Z

Changes since current v3.11.1 release: ### Bug Fixes - Fixed `GitPoller` when `repourl` has the port specified (:issue:`7822`). - Fixed `ChoiceStringParameter` fields with `multiple` would not store the selected values. - Fixed unnecessary trimming of spaces in logs shown in the web UI (:issue:`7774`). - Fixed favicon colors on build views in the web UI. - Fixed the icon on the about page in the web UI. - Fixed a regression where builds in waterfall view were no longer linking to the build page. - Transfer build steps (:bb:step:`FileUpload`, :bb:step:`DirectoryUpload`, :bb:step:`MultipleFileUpload`, :bb:step:`FileDownload`, and :bb:step:`StringDownload`) now correctly remove the destination on failure, preventing partial content (:issue:`2860`). - Fixed ReactUI when Buildbot is hosted behind a reverse proxy not at the URL's root (:issue:`7260`, :issue:`7746`). - Fixed results color shown on the builder's header in the waterfall view. - Fixed cases where the waterfall view could be squashed to a pixel high. - Fixed several occasional data update glitches in the web frontend. - Fixed the display of newly added builds in the Workers view in the web frontend. - Fixed a regression where `GitPoller` would no longer register new changes (regression introduced in 3.11.3 in #7554). - Fixed a bug that caused `GitPoller` running with git configured with the `fetch.prune=true` parameter to fail. - Fixed a bug that caused `GitPoller` to miss changes when Buildbot is reconfigured. - Reduced the length of directory names produced by `GitPoller` internally to avoid potential breakage on filesystems with low path and name length limits. - Removed credentials from `repourl` used in the tracker branch name. - Fixed an error in `HgPoller` when repository initialization fails (:issue:`7488`). - Updated the `Makefile` to handle Windows paths and Python. - Fixed the steps raw log download button. - Fixed a regression in the React UI that prevented hosting Buildbot at a custom URL prefix, allowing support for multiple Buildbot instances on a single server. ### Changes - Buildbot will now raise an error when configured with multiple services of the same type and name (:issue:`6987`). - Improved the flexibility of the `scaling_waterfall` setting to support floating-point values for a more condensed view. - Added a web configuration setting to select whether build completion or start times are displayed. - Added a revision info column in the web frontend. ### Features - Added `MessageFormatterFunctionRaw`, allowing complete customization of emitted messages. This feature has been available since 3.11.0 but was only recently announced. ### Deprecations and Removals - The `pollinterval` argument of various change sources has been deprecated with a warning in favor of `pollInterval`. ### Improved Documentation - Documented that `ChangeSource` does not support secrets (or any other renderables) and provided best practices for handling secret values in changes. Up until Buildbot 3.7, `ChangeSource` accidentally supported renderable arguments, which was undocumented behavior. Signed-off-by: Petr Štetiar

buildmaster: add static apk utility

2024-09-25T19:45:02Z

We need a relatively recent `apk` that can sign package indexes. You can find more details in the referenced issue below. However, it has not been released yet and is not available as a prebuilt download. Therefore, until it becomes available, let's build a static version and use that in the meantime. Fixes: a94d4e15fdc1 ("add APK signing logic") References: https://gitlab.alpinelinux.org/alpine/apk-tools/-/issues/11008 Signed-off-by: Petr Štetiar

docker: bump rsync Debian version

2024-08-10T11:19:10Z

Signed-off-by: Paul Spooren

add APK signing logic

2024-08-10T11:19:10Z

With this commit it's possible to sign APK package indexes (packages.adb) via the `signall.sh` script, which is run on the buildmaster. As a consequence `apk` must be available on the buildmaster. This is the final step to replace OPKG with APK. Signed-off-by: Paul Spooren

phase1: make IsNoMasterBuild function more flexible

2024-08-07T08:04:04Z

Work with both master/main Signed-off-by: Paul Spooren Signed-off-by: Christian Marangi