buildbot, branch v7

phase1: dlprune: fix cannot delete ‘dl/’: Not a directory

2023-06-03T07:45:45Z

dlprune currently fails with following error: find: cannot delete ‘dl/’: Not a directory Initial idea was to delete only stuff under download directory and not the download directory itself, so lets adjust the find command accordingly. Fixes: 68b20ed67b5e ("phase1: prune unused files from dl/") Signed-off-by: Petr Štetiar

phase1: satisfy getver.sh requirements

2023-05-23T19:34:21Z

scripts/getver.sh requires upstream branch tracking to correctly compute revision number. Buildbot Git() step does not set branch tracking as it checks out individual commits and then reset the target branch to it, so in order for getver.sh to work, this workaround forcefully sets the upstream branch. This fixes malformed version code in filenames as observed on openwrt-23.05: r23001+3-38c150612c instead of: r23004-7f0db09513 Signed-off-by: Thibaut VARÈNE

phase1: cleanup redundant steps

2023-05-23T02:29:44Z

These 3 rm steps are unnecessary since these folders are already cleaned by the Git() step. Thus reduce clutter in already pretty busy Factory. Signed-off-by: Thibaut VARÈNE

phase1: workaround gitverify 1st build failures on fresh workers

2023-05-17T09:27:23Z

Currently every 1st build on ephemeral build worker results in the failure of the `gitverify` build step as the stock buildbot Git() build step for some reasons just clones the Git repository into detached HEAD state. On the 2nd build using the same build worker Git() checkouts the branch and thus makes `gitverify` step happy and the builds then continues normally. This needs to be fixed properly, either by adjusting the `gitverify` check or adding suitable `mode` into Git() build step, but this needs more time and testing. So for now, lets simply workaround that issue by running Git() step two times. References: #5 Signed-off-by: Petr Štetiar

docker,worker: install g++-multilib

2023-05-17T09:27:07Z

From [openwrt/docker@5484951][1] (GitHub PR [#89][2]): Node fails to cross-compile from a 64-bit build machine to 32-bit host with the following error: ``` In file included from /usr/include/c++/8/memory:62, from ../deps/v8/src/libplatform/default-foreground-task-runner.h:8, from ../deps/v8/src/libplatform/default-foreground-task-runner.cc:5: /usr/include/c++/8/bits/stl_algobase.h:59:10: fatal error: bits/c++config.h: No such file or directory #include ^~~~~~~~~~~~~~~~~~ compilation terminated. ``` On Debian, `g++-multilib` can be installed to fix this. [1]: https://gitlab.com/openwrt/docker/-/commit/54849510d7802028b94757051cca6d004a9ca1d1 [2]: https://github.com/openwrt/docker/pull/89 Fixes: https://github.com/openwrt/packages/issues/18476 Fixes: https://forum.openwrt.org/t/why-arent-the-node-and-node-npm-packages-available-on-arm-cortex-a9-vfpv3-d16-in-22-03-2/142722 Signed-off-by: Alois Klink

ci: add basic config checking with ruff

2023-05-16T14:52:33Z

Signed-off-by: Petr Štetiar

phase1: actually make rsync -4 configurable

2023-05-16T14:52:33Z

54e80d5ce introduced an interpolate bug that would evaluate an empty string as being part of the arguments passed to rsync, resulting in a failure as rsync interprets that empty string as a source. This commit fixes this by instead appending '4' to regular shortopts when necessary. Fixes: 54e80d5ce Signed-off-by: Thibaut VARÈNE Signed-off-by: Petr Štetiar

phase1: perform kmodupload only when needed

2023-05-16T14:52:33Z

Fixes: 909e899 Signed-off-by: Thibaut VARÈNE Signed-off-by: Petr Štetiar

phase1: fix crash on exception during Git update

2023-05-15T15:36:01Z

Fixes following exception: 2023-05-15 14:08:56+0000 [-] build got exception when running step Git(name='git', repourl='https://git.openwrt.org/openwrt/openwrt.git', mode='full', method='fresh', locks=renderer(), haltOnFailure=True) 2023-05-15 14:08:56+0000 [-] Unhandled Error Traceback (most recent call last): File "/usr/local/lib/python3.9/dist-packages/twisted/internet/defer.py", line 1792, in gotResult _inlineCallbacks(r, gen, status, context) File "/usr/local/lib/python3.9/dist-packages/twisted/internet/defer.py", line 1693, in _inlineCallbacks result = context.run( File "/usr/local/lib/python3.9/dist-packages/twisted/python/failure.py", line 518, in throwExceptionIntoGenerator return g.throw(self.type, self.value, self.tb) File "/usr/local/lib/python3.9/dist-packages/buildbot/process/build.py", line 576, in _start_next_step_impl log.err(e) --- --- File "/usr/local/lib/python3.9/dist-packages/buildbot/process/build.py", line 562, in _start_next_step_impl results = yield step.startStep(self.conn) builtins.KeyError: None as None is valid property value, but cant be used as dict index. Signed-off-by: Petr Štetiar

ci: allow pushing of containers during pull requests

2023-05-15T15:36:01Z

Make it possible to push containers in pull requests in private forks, so the container can be actually runtime tested before merging the changes. Signed-off-by: Petr Štetiar