buildbot/phase1, branch v11

phase1: treat all branches equally for building

2023-11-16T08:57:01Z

Following discussion here: https://lists.openwrt.org/pipermail/openwrt-devel/2023-November/041769.html Signed-off-by: Thibaut VARÈNE

phase1: raise priority of tag builds

2023-11-16T08:57:01Z

Currently the buildmaster would only order tag builds within their own branch, meaning that if e.g. a higher priority branch has normal buildrequests (i.e. buildrequests comming from the AnyBranchScheduler), and a lower priority branch has "tag" buildrequests (i.e. from the Triggerable scheduler), the former builderequests would be served first, deferring the build of e.g. release tags. We want forced builds (release tag) to have maximum priority, regardless of branch priority. This commit attempts to solve this problem by leveraging the newly (as of buildbot 3.9.0) introduced "priority" scheduler parameter, by raising the Triggerable scheduler buildrequests priority, and then considering this higher priority in Builders' order. The net result is that Builders are now prioritized if they have pending higher priority buildrequest, still preserving the branch order. In other words, tag requests are front run while preserving branch order, meaning that if two branches have tag buildrequests, the higher priority branch is still served first. This requires buildbot 3.9.0 Signed-off-by: Thibaut VARÈNE

phase1: workaround dlprune recursive directory removal

2023-07-24T09:06:09Z

Workarounds following issue: find: cannot delete ‘dl/ath10k-ct-firmware-2020-11-08’: Directory not empty References: #13 Signed-off-by: Petr Štetiar

phase1: prepareFactory: use variables instead of list index

2023-07-22T09:05:33Z

Thus make the code more readable. Signed-off-by: Petr Štetiar

phase1: populateTargets: log branch name as well

2023-07-22T09:05:32Z

So the progress is more verbose. Signed-off-by: Petr Štetiar

phase1: do not leak targets between branches

2023-07-22T09:05:31Z

Robert noticed, that after rename of `ipq807x` target in main branch to `qualcommax/ipq807x` subtarget, that buildbot is trying to build this new `qualcommax/ipq807x` subtarget on `openwrt-23.05` branch as well. Thibaut later explained, that this is by design, his initial idea was to find exhaustive list of all targets and let the `checkarch` step do the final triaging. I find this approach confusing, because if the subtarget is not present in that branch, we shouldn't have builder for it configured as well. Furthermore wasting roughly 5 minutes of precious buildworker time to checkout all feeds and then just find out, that we're not going to use those seems suboptimal as well. So lets fix it by using builders for targets as present in respective branches. Fixes: #14 Reported-by: Robert Marko Signed-off-by: Petr Štetiar

phase1: reformat with black

2023-06-18T05:52:37Z

Making everything consistent, more readable, CI guarded. Signed-off-by: Petr Štetiar

phase1: dlprune: fix cannot delete ‘dl/’: Not a directory

2023-06-03T07:45:45Z

dlprune currently fails with following error: find: cannot delete ‘dl/’: Not a directory Initial idea was to delete only stuff under download directory and not the download directory itself, so lets adjust the find command accordingly. Fixes: 68b20ed67b5e ("phase1: prune unused files from dl/") Signed-off-by: Petr Štetiar

phase1: satisfy getver.sh requirements

2023-05-23T19:34:21Z

scripts/getver.sh requires upstream branch tracking to correctly compute revision number. Buildbot Git() step does not set branch tracking as it checks out individual commits and then reset the target branch to it, so in order for getver.sh to work, this workaround forcefully sets the upstream branch. This fixes malformed version code in filenames as observed on openwrt-23.05: r23001+3-38c150612c instead of: r23004-7f0db09513 Signed-off-by: Thibaut VARÈNE

phase1: cleanup redundant steps

2023-05-23T02:29:44Z

These 3 rm steps are unnecessary since these folders are already cleaned by the Git() step. Thus reduce clutter in already pretty busy Factory. Signed-off-by: Thibaut VARÈNE