<feed xmlns='http://www.w3.org/2005/Atom'>
<title>buildbot/scripts/signall.sh, branch v28</title>
<subtitle>LEDE buildbot configuration</subtitle>
<id>https://git.openwrt.org/buildbot/atom?h=v28</id>
<link rel='self' href='https://git.openwrt.org/buildbot/atom?h=v28'/>
<link rel='alternate' type='text/html' href='https://git.openwrt.org/buildbot/'/>
<updated>2024-11-18T08:08:57Z</updated>
<entry>
<title>scripts: signall: skip updating hash of previous kmods/</title>
<updated>2024-11-18T08:08:57Z</updated>
<author>
<name>Christian Marangi</name>
</author>
<published>2024-11-17T15:13:02Z</published>
<link rel='alternate' type='text/html' href='https://git.openwrt.org/buildbot/commit/?id=31eb26b97e7cf8f202c8bd2c65d550edd6e28374'/>
<id>urn:sha1:31eb26b97e7cf8f202c8bd2c65d550edd6e28374</id>
<content type='text'>
Handle case where a sha256sums might contain previous kmods/. In such
case packages.adb for previous kmods/ needs to be skipped as not
included in the sign tar and already signed by previous runs.

Skip is limited to kmods/ entry as those are the only entry expected to
be present in the sha256sums but not included in sign tar.

Signed-off-by: Christian Marangi &lt;ansuelsmth@gmail.com&gt;
</content>
</entry>
<entry>
<title>Allow signing of artifacts with key provided by GPG agent</title>
<updated>2024-11-05T05:07:59Z</updated>
<author>
<name>Petr Štetiar</name>
</author>
<published>2024-11-04T20:43:06Z</published>
<link rel='alternate' type='text/html' href='https://git.openwrt.org/buildbot/commit/?id=d014e424f4b440eb4be641e5e408699a63331901'/>
<id>urn:sha1:d014e424f4b440eb4be641e5e408699a63331901</id>
<content type='text'>
In our case the GPG agent serves 0x1D53D1877742E911 key stored on
Nitrokey3 USB dongle. GPG key is bind mounted from the host.

References: https://lists.openwrt.org/pipermail/openwrt-devel/2023-May/041044.html
Signed-off-by: Petr Štetiar &lt;ynezz@true.cz&gt;
</content>
</entry>
<entry>
<title>scripts: signall: silence pushd/popd directory changes</title>
<updated>2024-11-04T20:35:37Z</updated>
<author>
<name>Petr Štetiar</name>
</author>
<published>2024-11-04T20:35:37Z</published>
<link rel='alternate' type='text/html' href='https://git.openwrt.org/buildbot/commit/?id=7a869ad9c968c98a52ba4dcb20a693978f19ad99'/>
<id>urn:sha1:7a869ad9c968c98a52ba4dcb20a693978f19ad99</id>
<content type='text'>
Its not needed to have those visible in the job output as it might be
misleading.

Signed-off-by: Petr Štetiar &lt;ynezz@true.cz&gt;
</content>
</entry>
<entry>
<title>scripts: signall: fix finish function not called when apk adbsign failed</title>
<updated>2024-09-29T18:21:02Z</updated>
<author>
<name>Petr Štetiar</name>
</author>
<published>2024-09-29T18:21:02Z</published>
<link rel='alternate' type='text/html' href='https://git.openwrt.org/buildbot/commit/?id=117e151a2164a47c436436e644514ce2bcf09b07'/>
<id>urn:sha1:117e151a2164a47c436436e644514ce2bcf09b07</id>
<content type='text'>
The `finish 3` was not being called when the `apk adbsign` command
failed within the `find` command using `-exec`. This happened because
`find` does not exit with a non-zero status when the command executed by
`-exec` fails, so the `|| finish 3` condition was not triggered.

So lets replace the `find ... -exec ...` construct with a loop and call
`finish 3` immediately if it fails.

Fixes: a94d4e15fdc1 ("add APK signing logic")
Signed-off-by: Petr Štetiar &lt;ynezz@true.cz&gt;
</content>
</entry>
<entry>
<title>scripts: signall: fix wrong sha256sum on apk packages.adb index</title>
<updated>2024-09-29T17:59:15Z</updated>
<author>
<name>Petr Štetiar</name>
</author>
<published>2024-09-28T12:22:35Z</published>
<link rel='alternate' type='text/html' href='https://git.openwrt.org/buildbot/commit/?id=75b1334a00b099b884e5141fc9c52226c2404fc6'/>
<id>urn:sha1:75b1334a00b099b884e5141fc9c52226c2404fc6</id>
<content type='text'>
Currently the sha256sum verification of apk's packages.adb index
fails as the file is modified with `apk adbsign`.

So lets update sha256sum of all packages.adb indexes after they were
signed with `apk adbsign`.

While at it fix formatting.

Fixes: a94d4e15fdc1 ("add APK signing logic")
Signed-off-by: Petr Štetiar &lt;ynezz@true.cz&gt;
</content>
</entry>
<entry>
<title>scripts: signall: fix wrong GPG signature on apk packages.adb index</title>
<updated>2024-09-28T17:10:39Z</updated>
<author>
<name>Petr Štetiar</name>
</author>
<published>2024-09-28T12:22:35Z</published>
<link rel='alternate' type='text/html' href='https://git.openwrt.org/buildbot/commit/?id=75930d3a890b1f4f4c3df153331a22f60d7429a9'/>
<id>urn:sha1:75930d3a890b1f4f4c3df153331a22f60d7429a9</id>
<content type='text'>
Currently the GPG signature verification of apk's packages.adb index
fails as the file is modified with `apk adbsign` after its GPG signed.

So lets fix it by moving the `apk adbsign` before the GPG signing step.

Fixes: a94d4e15fdc1 ("add APK signing logic")
Signed-off-by: Petr Štetiar &lt;ynezz@true.cz&gt;
</content>
</entry>
<entry>
<title>add APK signing logic</title>
<updated>2024-08-10T11:19:10Z</updated>
<author>
<name>Paul Spooren</name>
</author>
<published>2024-08-06T16:03:21Z</published>
<link rel='alternate' type='text/html' href='https://git.openwrt.org/buildbot/commit/?id=a94d4e15fdc1e9715d7d0cfdcc62227186d0fc45'/>
<id>urn:sha1:a94d4e15fdc1e9715d7d0cfdcc62227186d0fc45</id>
<content type='text'>
With this commit it's possible to sign APK package indexes
(packages.adb) via the `signall.sh` script, which is run on the
buildmaster. As a consequence `apk` must be available on the
buildmaster. This is the final step to replace OPKG with APK.

Signed-off-by: Paul Spooren &lt;mail@aparcar.org&gt;
</content>
</entry>
<entry>
<title>scripts/signall.sh: make branch aware</title>
<updated>2023-05-15T15:36:01Z</updated>
<author>
<name>Thibaut VARÈNE</name>
</author>
<published>2022-10-24T14:56:37Z</published>
<link rel='alternate' type='text/html' href='https://git.openwrt.org/buildbot/commit/?id=bdb822236f2665c86293108a8640990f5932b857'/>
<id>urn:sha1:bdb822236f2665c86293108a8640990f5932b857</id>
<content type='text'>
This commit is a NO-OP if signall.sh is called with a single argument,
as is currently done, and will allow fetching branch-specific signing
credentials if a branch name is passed as second argument.

Signed-off-by: Thibaut VARÈNE &lt;hacks@slashdirt.org&gt;
</content>
</entry>
<entry>
<title>scripts: signall.sh store usign.key as usign.sec</title>
<updated>2020-02-02T18:26:05Z</updated>
<author>
<name>Paul Spooren</name>
</author>
<published>2019-11-14T07:55:30Z</published>
<link rel='alternate' type='text/html' href='https://git.openwrt.org/buildbot/commit/?id=e3c7a98974fe3c29091061acad5758918e832928'/>
<id>urn:sha1:e3c7a98974fe3c29091061acad5758918e832928</id>
<content type='text'>
The signall.sh script signs all files inside a tar via GPG and
signify-openbsd (similar to usign)e and attaches the signatures to the
same archive.

Using more recent versions of signify-openbsd requires a specific naming
schema for keys, private ending with .sec and public with .pub. This was
introduced at 763e1148f68f03cb2fa85d022500acf8c66af222[0].

This patch renames the stored key as usign.sec instead of usign.key. As
of the temporary nature of the key storing, this very unlikely breaks
any existing setups.

[0]: https://github.com/openbsd/src/commit/763e1148f68f03cb2fa85d022500acf8c66af222

Signed-off-by: Paul Spooren &lt;mail@aparcar.org&gt;
[adjusted commit subject]
Signed-off-by: Jo-Philipp Wich &lt;jo@mein.io&gt;
</content>
</entry>
<entry>
<title>scripts: signall.sh: use absolute paths when invoking gpg from find</title>
<updated>2019-07-17T06:13:24Z</updated>
<author>
<name>Jo-Philipp Wich</name>
</author>
<published>2019-07-17T06:13:24Z</published>
<link rel='alternate' type='text/html' href='https://git.openwrt.org/buildbot/commit/?id=b151d3fa1024e8242b56314981dd6cbe0a1fc7d6'/>
<id>urn:sha1:b151d3fa1024e8242b56314981dd6cbe0a1fc7d6</id>
<content type='text'>
Signed-off-by: Jo-Philipp Wich &lt;jo@mein.io&gt;
</content>
</entry>
</feed>
