summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatt Merhar2026-02-11 19:33:15 +0000
committerRobert Marko2026-02-13 20:17:21 +0000
commitfcb07b00ec22b90fc0cd790701982018ee345366 (patch)
tree3cf14f549f574f1308652028552394fe9e89a511
parentdfd15dc725a273cae3484fb9d487dc93ae5b6286 (diff)
downloadopenwrt-fcb07b00ec22b90fc0cd790701982018ee345366.tar.gz
build: propagate errors when generating apk indexes
The build would continue even if the some of the intermediate commands failed, as long as the last command in the final iteration of the loop was successful. Add 'set -e' to the subshell so that we immediately exit. Previously, only the exit status of the final make-index-json.py mattered. Fixes: https://github.com/openwrt/openwrt/issues/21981 Signed-off-by: Matt Merhar <mattmerhar@protonmail.com> Link: https://github.com/openwrt/openwrt/pull/21993 Signed-off-by: Robert Marko <robimarko@gmail.com>
-rw-r--r--package/Makefile1
1 files changed, 1 insertions, 0 deletions
diff --git a/package/Makefile b/package/Makefile
index 7e69b9a0b5..b5581f9859 100644
--- a/package/Makefile
+++ b/package/Makefile
@@ -129,6 +129,7 @@ $(curdir)/index: FORCE
@echo Generating package index...
ifneq ($(CONFIG_USE_APK),)
@for d in $(PACKAGE_SUBDIRS); do \
+ set -e; \
mkdir -p $$d; \
cd $$d || continue; \
ls *.apk >/dev/null 2>&1 || continue; \