Broadcom-s Trusted Firmware A https://git.openwrt.org/project/bcm63xx/atf/atom?h=master 2019-08-13T11:20:25Z 2019-08-13T11:20:25Z Paul Beesley 2019-08-13T11:20:25Z urn:sha1:a8ab58e9b291297f3484624a11b24039cb4e1ee8 * changes: Fix Coverity #261967, Infinite loop Fix Coverity #343017, Missing unlock Fix Coverity #343008, Side affect in assertion Fix Coverity #342970, Uninitialized scalar variable 2019-08-06T12:06:03Z Justin Chadwell 2019-07-23T08:54:07Z urn:sha1:fc6b626c6b6d17993764db9bc14c7c8457835854 All other returns from this function unlock the responses_lock, so we also should release the lock in this case. Change-Id: Ie2cfa8755723fed79e809f9480190d11f373a217 Signed-off-by: Justin Chadwell <justin.chadwell@arm.com> 2019-08-01T20:45:03Z Julius Werner 2019-07-09T21:02:43Z urn:sha1:402b3cf8766fe2cb4ae462f7ee7761d08a1ba56c NOTE: AARCH32/AARCH64 macros are now deprecated in favor of __aarch64__. All common C compilers pre-define the same macros to signal which architecture the code is being compiled for: __arm__ for AArch32 (or earlier versions) and __aarch64__ for AArch64. There's no need for TF-A to define its own custom macros for this. In order to unify code with the export headers (which use __aarch64__ to avoid another dependency), let's deprecate the AARCH32 and AARCH64 macros and switch the code base over to the pre-defined standard macro. (Since it is somewhat unintuitive that __arm__ only means AArch32, let's standardize on only using __aarch64__.) Change-Id: Ic77de4b052297d77f38fc95f95f65a8ee70cf200 Signed-off-by: Julius Werner <jwerner@chromium.org> 2019-08-01T20:14:12Z Julius Werner 2019-07-09T20:49:11Z urn:sha1:d5dfdeb65ff5b7f24dded201d2945c7b74565ce8 NOTE: __ASSEMBLY__ macro is now deprecated in favor of __ASSEMBLER__. All common C compilers predefine a macro called __ASSEMBLER__ when preprocessing a .S file. There is no reason for TF-A to define it's own __ASSEMBLY__ macro for this purpose instead. To unify code with the export headers (which use __ASSEMBLER__ to avoid one extra dependency), let's deprecate __ASSEMBLY__ and switch the code base over to the predefined standard. Change-Id: Id7d0ec8cf330195da80499c68562b65cb5ab7417 Signed-off-by: Julius Werner <jwerner@chromium.org> 2019-04-09T10:10:09Z Paul Beesley 2019-04-08T14:24:43Z urn:sha1:00e51ca312cdf64554ac6c393c7cdf06b1c7a7a7 The spm_sp_get_by_uuid() function is used to look up the secure partition that provides a given service. Within this function, memcmp() is used to compare the service UUIDs but it uses the size of the rdsvc->uuid pointer instead of the size of its content (missing dereference). This means that only a partial comparison is performed as UUIDs are 128 bits in length and rdsvc->uuid is a uint32_t typed pointer. Instead, use the size of the array pointed to by the svc_uuid parameter, which will be the full 128 bits, for the comparison. Change-Id: I258fb0cca3bf19f97b8f2a4c133981647cd050e4 Signed-off-by: Paul Beesley <paul.beesley@arm.com> 2019-04-03T09:51:31Z Antonio Nino Diaz 2019-03-27T13:45:52Z urn:sha1:75f364b3e09c16e67dfca27318bc0fec668d688f Rather than using a fixed virtual address space size, read all regions in the resource description of each partition and restrict the virtual address space size to the one the partition actually needs. This also allows SPM to take advantage of the extension ARMv8.4-TTST if the virtual address space size is small enough. Change-Id: I8646aa95e659136b58b44b040364cdee631f7e82 Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com> 2019-04-03T09:51:31Z Antonio Nino Diaz 2019-03-27T13:04:46Z urn:sha1:014df18b8e6cc2e6accb8230b950d7f3263f497a Right now the virtual address space is fixed to PLAT_VIRT_ADDR_SPACE_SIZE, so all base translation tables are the same size and need the same alignment. The current code allocates the exact space needed by this initial table. However, a following patch is going to allow each partition to choose the size of its address space based on the memory regions defined in their resource description, so it isn't possible to determine this at build time. As this optimization no longer applies, it has to be removed. Change-Id: Ia8d19f4981e1017e4ffe0ba136de73d701044cb0 Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com> 2019-04-03T09:51:31Z Antonio Nino Diaz 2019-03-27T11:10:31Z urn:sha1:6de6965b2fcaffec01b2679118d16eabfde4d9c9 This gives each Secure Partition complete freedom on its address space. Previously, the memory used by the exception vectors was reserved and couldn't be used. Also, it always had to be mapped, forcing SPM to generate translation tables that included the exception vectors as well as the Partition memory regions. With this change, partitions can reduce their address space size easily. Change-Id: I67fb5e9bdf2870b73347f23bff702fab0a8f8711 Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com> 2019-04-02T13:52:55Z Antonio Nino Diaz 2019-03-29T13:48:50Z urn:sha1:5db5930bafe00db095c2aed150fdbc45059b692a Instead of letting the code run until another error is reached, return early. Change-Id: I6277a8c65101d3e39b0540099c2a3063584a7dbd Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com> 2019-04-01T09:43:42Z Ambroise Vincent 2019-02-27T16:01:48Z urn:sha1:7a79328c3a0242466621548802ad03664dca2d47 Fix variable shadowing warnings and prevent code duplication. Change-Id: Idb29cc95d6b6943bc012d7bd430afa0e4a7cbf8c Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com>