fwtool, branch master

CMakeLists: update cmake minimum required version to 3.10

2025-10-03T21:37:07Z

New cmake version 4.0 requires at least 3.5 version as the minimum required version with it increased to 3.10 in to-be-released cmake versions. Set the minimum required version to 3.10 to future-proof for future cmake version. Suggested-by: Hannu Nyman Signed-off-by: Christian Marangi

cmake: use extra compiler warnings only on gcc6+

2019-11-14T21:34:27Z

gcc version 4.8.5 20150623 (Red Hat 4.8.5-39) and -Wextra produces following: fwtool.c:288:9: error: missing initializer for field 'cur' of 'struct data_buf' [-Werror=missing-field-initializers] struct data_buf dbuf = {}; ^ fwtool.c:37:8: note: 'cur' declared here char *cur; ^ Ref: https://github.com/openwrt/openwrt/commit/4ba8f7b1ef1e4c0607185a41c06b51928c625d8b#commitcomment-35906526 Ref: http://lists.infradead.org/pipermail/openwrt-devel/2019-November/020039.html Signed-off-by: Petr Štetiar

fix possible garbage in unitialized char* struct members

2019-11-09T13:28:09Z

scan-build from clang version 9 has reported following issues: crc32.h:44:32: warning: The right operand of '^' is a garbage value val = crc_table[(uint8_t)val ^ *(uint8_t*)buf] ^ (val >> 8); ^ ~~~~~~~~~~~~~~ cppcheck version 1.89 has reported following issues: fwtool.c:260:9: error: Uninitialized variable: dest [uninitvar] memcpy(dest, dbuf->cur + dbuf->cur_len - cur_len, cur_len); ^ fwtool.c:333:27: note: Calling function 'extract_tail', 2nd argument '&tr' value is if (extract_tail(&dbuf, &tr, sizeof(tr))) { ^ Signed-off-by: Petr Štetiar

fix possible copy of null buffer and validation of unitialized header

2019-11-09T13:28:09Z

scan-build from clang version 9 has reported following issues: fwtool.c:257:2: warning: Null pointer passed as an argument to a 'nonnull' parameter memcpy(dest, dbuf->cur + dbuf->cur_len - cur_len, cur_len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fwtool.c:275:20: warning: The left operand of '!=' is a garbage value if (hdr->version != 0) ~~~~~~~~~~~~ ^ Signed-off-by: Petr Štetiar

crc32: add missing stdint.h dependency

2019-11-09T13:28:09Z

In order to fix compile error if using this header standalone, in unit tests for example. Signed-off-by: Petr Štetiar

add cram based unit tests

2019-11-09T13:28:09Z

For improved QA etc. Signed-off-by: Petr Štetiar

add initial GitLab CI support

2019-11-09T13:23:52Z

Uses currently proof-of-concept openwrt-ci[1] in order to: * improve the quality of the codebase in various areas * decrease code review time and help merging contributions faster * get automagic feedback loop on various platforms and tools - out of tree build with OpenWrt SDK on following targets: * ath79-generic * imx6-generic * malta-be * mvebu-cortexa53 - out of tree native build on x86/64 with GCC (versions 7, 8, 9) and Clang 9 - out of tree native x86/64 static code analysis with cppcheck and scan-build from Clang 9 1. https://gitlab.com/ynezz/openwrt-ci/ Signed-off-by: Petr Štetiar

iron out extra compiler warnings

2019-11-09T13:23:52Z

fwtool.c:216:3: error: ignoring return value of ‘ftruncate’, declared with attribute warn_unused_result [-Werror=unused-result] fwtool.c:376:3: error: ignoring return value of ‘ftruncate’, declared with attribute warn_unused_result [-Werror=unused-result] Signed-off-by: Petr Štetiar

convert into CMake project

2019-11-09T13:23:45Z

Aligning it with other C based projects. Signed-off-by: Petr Štetiar

refactor into separate Git project

2019-10-17T22:36:11Z

For improved reusability, testing etc. Signed-off-by: Petr Štetiar