luci/applications/luci-app-ddns/root, branch master

luci-app-ddns: quote the date format passed to the shell

2026-08-03T13:08:34Z

get_date() interpolated the configured date format into a shell command run as root, inside double quotes and without escaping: popen(`date -d @${seconds} "+${format}" 2>/dev/null`, 'r') `format` comes from uci ddns.global.ddns_dateformat and is reached on every status poll via get_ddns_state() -> epoch2date(). A value containing a double quote closes the quoted argument and runs arbitrary commands as root; the expected date is still printed, so nothing looks wrong in the UI. The file already carries a shellquote() helper, used correctly for lookup_host, section and dns_server in get_services_status(). Use it here too. Assisted-by: Claude:claude-opus-5 Signed-off-by: Julius Bairaktaris

luci-app-ddns: control ddns through the rc ubus namespace

2026-08-03T09:58:22Z

rpcd's rc namespace does what luci.setInitAction does, without a shell: rc.init accepts the same enable/disable/start/stop/restart/reload set, execs the init script directly instead of interpolating name and action into a /bin/sh command line, and additionally requires the script to be root-owned and not world-writable. The grant goes in the write scope, not read. rpcd matches ubus ACLs on object and method only, with no per-argument filtering, so a read-scope rc.init would let a session with read-only access to ddns drive any init script on the box. rc.init has no reply payload, so the setInitAction specific `expect: { result: false }` unwrapping goes with it. Declare it with `reject: true` in its place: without that, rpc.declare() resolves with the ubus status code rather than raising, so the .catch() in handleToggleDDns() would never run and the new root-owned and not-world-writable check - a rejection setInitAction could not produce - would leave the button silently doing nothing. handleRestartDDns() gets the same handler its two siblings already have. Assisted-by: Claude:claude-opus-5 Signed-off-by: Julius Bairaktaris

luci-app-ddns: replace dynamic_dns_lucihelper call on handleStopDDnsRule

2026-07-23T12:03:00Z

The ddns service is using procd for service execution. The 'dynamic_dns_lucihelper' ist not needed anymore. Signed-off-by: Florian Eckert

luci-app-ddns: fix syntax error

2026-05-28T17:30:40Z

fix syntax error Signed-off-by: Andy Chiang

luci-app-ddns: correctness fixes

2026-05-27T12:49:45Z

Signed-off-by: Paul Donald

luci-app-ddns: improve accuracy of next update and check times

2025-09-25T12:51:07Z

Depends on https://github.com/openwrt/packages/pull/27473 Refactor their display also. Signed-off-by: Paul Donald

luci-app-ddns: fix ddns uc script for apk

2025-07-11T00:16:28Z

Trim out some commented code, also. Signed-off-by: Paul Donald

luci-app-ddns: remove unused imports

2025-07-09T16:18:00Z

Signed-off-by: Paul Donald

luci-app-ddns: Fix multiple IP display bug

2025-04-23T12:03:50Z

Occasionally, a DNS lookup returns multiple IPs, so the best thing to do isn't to join them together as a unified string, but to separate them with an HTML
. Signed-off-by: Paul Donald

luci-app-ddns: diverse fixes, i18n corrections, and code improvements

2024-12-02T23:02:31Z

-trimmed redundant and repeated code -fixed adding a new service section, which... never worked. -removed some defaults -changed log formatting -opkg -> package-manager Signed-off-by: Paul Donald